From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C1BD71B826 for ; Tue, 15 May 2018 09:58:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2018 00:58:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,403,1520924400"; d="scan'208";a="39999674" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.6.248]) ([10.252.6.248]) by fmsmga008.fm.intel.com with ESMTP; 15 May 2018 00:58:08 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, Olivier Matz , konstantin.ananyev@intel.com, arybchenko@solarflare.com, shreyansh.jain@nxp.com References: <014e66f8e34cb87fa126b7494ad644ef9ac68978.1526313945.git.anatoly.burakov@intel.com> <1848737.7LY3OboWmP@xps> From: "Burakov, Anatoly" Message-ID: <8ef0570b-6459-e0fb-b1a7-eed2aa5dd624@intel.com> Date: Tue, 15 May 2018 08:58:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1848737.7LY3OboWmP@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 07:58:12 -0000 On 14-May-18 7:48 PM, Thomas Monjalon wrote: > 14/05/2018 18:06, Anatoly Burakov: >> Currently, populate_virt will check if mempool is already populated. >> This will cause inability to reserve multi-chunk mempools if >> contiguous memory is not a hard requirement, because if allocating >> all-contiguous memory fails, mempool will retry with virtual addresses >> and will call populate_virt. It seems that the original code never >> anticipated more than one non-physically contiguous area. >> >> Fix it by removing the check in populate virt. populate_anon() function >> calls populate_virt() also, and it can be reasonably inferred that it is >> expecting that virtual area is not already populated. Even though a >> similar check is already in place there, also add the check that was >> part of populate_virt() just in case. >> >> Fixes: aab4f62d6c1c ("mempool: support no hugepage mode") > > If it is really the root cause, you need to add Cc: stable@dpdk.org. Yes. It's not as pressing for previous DPDK versions because this codepath wasn't triggered unless --no-huge was used, but it's still a bug. > >> Cc: olivier.matz@6wind.com >> >> Signed-off-by: Anatoly Burakov > > This patch looks sensible. It will wait some review, > so it is a candidate for -rc4. > > > > > -- Thanks, Anatoly