From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14CA942D07; Tue, 20 Jun 2023 12:19:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9128C4068E; Tue, 20 Jun 2023 12:18:59 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2051.outbound.protection.outlook.com [40.107.243.51]) by mails.dpdk.org (Postfix) with ESMTP id 0BCB9400D6; Tue, 20 Jun 2023 12:18:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nndHAFCFHbmc5qnkx2gnJFE4HXat6WIdZAPT5fBQ9O/DX+TYpizJb1tJs83zDTkhgr5zQS6oSeZ520N/3tKlwDHgWWgQtHUbrD6WU4et5v90BBlE5C9kv7/pfS30yDdEvIgK6CSB08GHe16Ut8P1pI68QzLbWTZivjYahNrZAlX9qnMVRPLv0uTdIGMl/3gauVKxly/pQv0rzUP5ClaRix/E8WGfVoP0b6yROytUNnPRyQjf8XJvUhzgG821LRyHxzv7GWf1ZfdiWvoPEy44YCXLq++SBBx0C7NeF7eDPeWP4TgK5zt8TRei6CuRFTKh7Y/zBPJB0ET5MLXCTkr5rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m7nE9mlt2e1Imy1pbWvX5/XAlhvQ7qhMkipYNGYLUyA=; b=CBG46T8DQPKexsLbWbzjsaMBhRaf8ao7iU/Zo2zJgqcpdAtcG6aMQaRPxuTN1L/l3CPLU9Pkiad819gRLFYiUL7ugdY/BA1Mdkg8nQkr3d0lO0mb1vdYGrT/qTBKSK5ZT51b+zWgBoMfAxCDZeZW/pcwFdsX3hD+l02jdQn3t3xQN5h71wmZCVlaeqn6d/2/dRX6yzmMCy1buCjGKtvJc0CzctLtfVsrepUMemz5P3zBXt6HrEBJ1fVmIlH+AArGXp5tQziITn825fDj9jd4ZRFFlfDhraPuYmkw8t09u0qmMkZEBuha8RIDBgBujWTMP5FdzeULZ9wjQcNkNObsvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m7nE9mlt2e1Imy1pbWvX5/XAlhvQ7qhMkipYNGYLUyA=; b=5r0amCPfyJ/Nv7EbqV4h/05ThCbw3nfDEjZ/0QzULwAK+FOeX6juXiSTMxUltFETXKMmcgv2FTLMB6MQOTRrPi+1lrhPZnaChg8cKsfJGI7aYeLc3sv9AcqnKwBzdmUpvKAWkacgaSJjZcpJUbEVZ0GeV5CNPCReUHwuIwkOBZY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6762.namprd12.prod.outlook.com (2603:10b6:510:1ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Tue, 20 Jun 2023 10:18:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 10:18:54 +0000 Message-ID: <8ef74eaf-3565-cf38-2fd2-8548546c4c30@amd.com> Date: Tue, 20 Jun 2023 11:18:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1 Content-Language: en-US To: "humin (Q)" , Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Zerun Fu , stable@dpdk.org, Peng Zhang , Long Wu References: <20230616071558.1278520-1-chaoyong.he@corigine.com> <20230616072034.1278546-1-chaoyong.he@corigine.com> <3237ae77-bd68-cffa-f1f6-537ff871496e@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0475.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::31) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6762:EE_ X-MS-Office365-Filtering-Correlation-Id: ab7d04a8-389f-4397-759a-08db7177bfbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 13Lq8VK5GHV9cYkWZ29sELoImSxQ2RAh05HQ6Kxs/gn+uDPUEbMqBrpGgjoETqifIk0sDtR67UeYfgUpvwPSZf8eE4c3/lfwP5sKSwlh9LXgY8tNDE68WE80fK6eoKopobyHt4XhtIxVUU8LzcTNmPAcZ2l96niWuy6RX830zLMa9D1fEZQhmG87BJRnC0uETX/iSssAgvl78gOFn+BXssX5tN4CTPg/fw/ovEZDMufdZ4F9PEJpJnrv5j1bB6GCn6yBiKjJtFYHWqyWuTMPLGLdzHe4CqrF+TIj0VS0+gYZ0Oz7ucLC1W1iOIRhFBkUNePrdLqApk+8FSH3aBr64b5P8IvH0fUbFRhiv23lTSg0G2R4RFiYjOOB5sjySDa0AhNGvuJhM2+Dx6wsFxQCv1Tk5ikCv2ZoI2GNE/irJydj0Ue6Qoo3EHmPbAl63q+qNlpKwDvU/cQbR7ngIUSmuYscft2pTGqfuTQqSUe4RI8vBKPElh3Md/q92ylK3sew+q77WTSZShGs7tRGH7U07yTRank04VsHzQyjHg0JOgUUvOrP1AAfoW8ErNzZsXBTM+5kZq7lohbTQMiP2pxJyAq2LG5MfTuERPzqngyC5tPYD5uBQSLfyfTNXF3oSGCZayU+lmy6KtwbEgqrFoLp6A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(5660300002)(44832011)(2906002)(8676002)(8936002)(83380400001)(36756003)(31696002)(86362001)(38100700002)(31686004)(6666004)(66476007)(66556008)(4326008)(6486002)(66946007)(478600001)(110136005)(54906003)(6512007)(186003)(26005)(41300700001)(316002)(2616005)(53546011)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2ZOYURHTlBWQWkxTk1SYzN2aUVxV1RRTmZScGl2dTdHVUNXL2p1Uk1YaUVx?= =?utf-8?B?eFRhL3c4ZzdrVkdudFU5RlRncXlpZUNPVGRBOHpFdkhTVkg5WTJMN3l6YlRQ?= =?utf-8?B?dUI0YlFvZ1M5RG52L0lGMlIwOWVFODRLK2Q1NEhpWW5DQ2tKUXBSRGl1Snlh?= =?utf-8?B?dTM2SW5VMUs4Z2RoOS9oRUt2L0g1ZVNPeXFKcDd0NUVKV3lVV3RtYmV1OExJ?= =?utf-8?B?UmNpU3ZzakYyWnRNZDdkWHlHV1Q5UXZsR0pmR0RIOXhQRzJFeWNCd0dzc1V0?= =?utf-8?B?RXkvQ3BURkdBTy8yeFZ2VnkzQndxNkFsbzA0djNUZVpycGk5RUJ0RXh6VUxj?= =?utf-8?B?YnJRS2ZaRUx2M0lWa29ocis1akRWdUhxRlBGUVJFN1pTS3FJWEhONTNvSkJL?= =?utf-8?B?T2o5bk1XOER2NXh0MnFwZmpFWGJyNnRYS3lvZ2ZudHJQNWcvZFlDNUlZRWhG?= =?utf-8?B?Vmk0eGRFL3hJY1ZCVDhUczd4UndVQWZpbDdWMXdKMEpuZ2FaMEtsM3hrN3h6?= =?utf-8?B?dVdvU1cyQllzem55Z1lHYi9LM0VobzlPUlBGT3JhWXNBY01za0ZpVk1MMUh6?= =?utf-8?B?SzIxbHdFQ0R2RmUvU09NWlNvTlZKMFVQcGZhOTMzSitLZE5kVXhJendGYlhE?= =?utf-8?B?Ri95NjJIWHNBR1FxeUNZWDd3cWthakkzNkhGMVh0U0VRNDNxbjR6RktraEcy?= =?utf-8?B?QlVKME5qczhObWgrN1dBcG5iWVF1WGY3Vk5lZE1hMEdXZ2J2VStNV0t3eWNk?= =?utf-8?B?QkE5VFMzV2JkeWgxcDVTR0JKWWNnazJEV1lEYjRpOUE4NVFheXlLeG5XcXdN?= =?utf-8?B?NDdDMksvSzM5TWJnbjlVWmlCYUp6VlhOaGxyalRYR3BWZ2oxZnZCZnNveVhE?= =?utf-8?B?RDljcVpNaVR6Q3hjd2ZPRzlxVlBSdHBTQmR2eHhLWVd3QWswYW1scGZJcEdy?= =?utf-8?B?NjVBa1ByMGIrWWpMWGY4MGZXdEtyeUE4aXFlYmlpcmsxVjhPMkx6V0hCeEth?= =?utf-8?B?TkxUbU5oMm1sUFZmL3NxaVdrYmU4QzVlckFhRTJaem81MmpMbG9CdUlXN21H?= =?utf-8?B?N1J1UXdtdnkvRXFvdmEvY3luRFpBc0crTDl2eDQ3ak5iWHY0bWRPeHJtT3pZ?= =?utf-8?B?OW5tNTdwL1g2Y2xsVCtFQnpBVEI4bkdvN3FsMENuN2pZR0VIaWlDbVdIOWht?= =?utf-8?B?UTd4WWxlR0xSTUx1L2xHNW5sMS9ZMm5TdkZWVlJLK2l1a0p1ZjFmbWpneDhj?= =?utf-8?B?RHltMldaa2xxelQ4Z3BzbkxLNXB0YXU0MmdJanh3WWVQbUNVUTgxSDM3NFJ4?= =?utf-8?B?VkFIenR2LzVvZTlzQ0Vic2lQT0R2TTE2WnA3R25vaU9KNXNmRUNiVjk2TlFY?= =?utf-8?B?Zzg4dm5KMXFlMUd5bklodkZYRFNVNXNNcTlqUC8vY3p0Vnh4QjhKb2wxa3hL?= =?utf-8?B?d295Y1prVDVPaTc5ZUJpZ2JCYUp0RDF0L0t1ZkpLdWtMRXVOUklJT241eENo?= =?utf-8?B?TDVEaCtkVmdEMWZ0Q0pGaGRncXpMazVtazQ1VVpyZ05obG00MG1QWEJjQlB1?= =?utf-8?B?QW52UE5MSlBxc09OZDlXK0tncGlvUnRGbGZMWHJJRzlMWmowakpSUDhYQUg1?= =?utf-8?B?RDhWNFRCQnRxWTg2dmRuMXJGUVd2ZTR4cHErY2hyOGxWSGNMaUdoM0ZZU1Rv?= =?utf-8?B?QkYrYXg2MXhRMFNqWmkvWlphbVl5aHUzMDJXVUNsUncxNnV5SGNLTXlYekF0?= =?utf-8?B?TGpRcGxpTVY2c0gwa09LNkxoQ2xFNzdBNmliMFNBN0xiQkplRzhxMnFuaGR2?= =?utf-8?B?alhmbHVWUGVZaCtuaElJbGpLK0Q0NjN1aFhJSStBUWNObXlWdXZObjQrb0Nx?= =?utf-8?B?YnNKLzNXelRrR3ZpWUFkdkNCdkl4d2Rzb0cwaGpWRGRCejZGSG82MmhoQTZ5?= =?utf-8?B?K0JTaFY5aE1tNlEweVZlWlpkeHdNenFpb3V0VGZpS2JvTFdFbnlibjlNdGIz?= =?utf-8?B?V3k2ZFhyYUhTNmR4TkhOMm5LNnQzVlBGbjdOS3hWM1dsVnNqbFBWZTFRTGU3?= =?utf-8?B?VHgrTUhvVkMrZkNkVVc5TGtheGlLREJDY0s4aklUdFA0SFRzNkJBQW05cHho?= =?utf-8?Q?TCbIRMnt4yBIc+hSmeJseJB5A?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab7d04a8-389f-4397-759a-08db7177bfbd X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 10:18:54.3838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hd9KMHpamRDXxft/62PWoQqSe45sWghifRPwpqbj4oK0FkaUN/u0TAhkyg7tJFD+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6762 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/20/2023 3:53 AM, humin (Q) wrote: > > 在 2023/6/19 16:57, Ferruh Yigit 写道: >> On 6/16/2023 1:00 PM, humin (Q) wrote: >>> Hi, >>> >>> 在 2023/6/16 15:20, Chaoyong He 写道: >>>> From: Zerun Fu >>>> >>>> After the mainline Linux kernel commit >>>> "fe205d984e7730f4d21f6f8ebc60f0698404ac31" (ACPI: Remove side effect >>>> of partly creating a node in acpi_map_pxm_to_online_node) by >>>> Jonathan Cameron. When the system does not support NUMA architecture, >>>> the "socket_id" is expected to be -1. The valid "socket_id" in >>>> BOND PMD is greater than or equal to zero. So it will cause an error >>>> when DPDK checks the validity of the "socket_id" when starting the >>>> bond. This commit can fix this bug. >>>> >>>> Fixes: f294e04851fd ("net/bonding: fix socket ID check") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Zerun Fu >>>> Reviewed-by: Peng Zhang >>>> Reviewed-by: Chaoyong He >>>> Reviewed-by: Long Wu >>> No need add your colleagues unless they "reviwed-by" through email-list. >>> >> Hi Connor, >> >> This is done time to time, if code is already internally reviewed, send >> review/ack tags within the patch, to reduce noise in the mail list. > > ok. > >> >> It looks like there were additional reviewers of code, which is good, >> but it requires maintainers' (you and Chas) ack to get accepted. > > Acked-by: Min Hu (Connor) > > Applied to dpdk-next-net/main, thanks.