From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 53D281C4A; Fri, 12 May 2017 17:46:56 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 12 May 2017 08:46:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,330,1491289200"; d="scan'208";a="1129542295" Received: from dwdohert-mobl1.ger.corp.intel.com (HELO [163.33.228.190]) ([163.33.228.190]) by orsmga001.jf.intel.com with ESMTP; 12 May 2017 08:46:53 -0700 To: Kyle Larose , "users@dpdk.org" , "dev@dpdk.org" References: <9aabdec0-81b2-689d-9f2e-838d93c67ccb@intel.com> From: Declan Doherty Message-ID: <8f0580c1-532c-83c5-df4b-68bdbb3a5a05@intel.com> Date: Fri, 12 May 2017 16:46:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] active_backup link bonding and mac address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2017 15:46:57 -0000 On 12/05/2017 4:34 PM, Kyle Larose wrote: > > >> -----Original Message----- >> From: Declan Doherty [mailto:declan.doherty@intel.com] >> Sent: Friday, May 12, 2017 10:56 AM >> To: Kyle Larose; users@dpdk.org; dev@dpdk.org >> Subject: Re: active_backup link bonding and mac address >> >> On 12/05/2017 3:31 PM, Kyle Larose wrote: >>> I'm adding the dev mailing list/link bonding maintainer, because I've done >> some more investigation and I'm beginning to think something is wrong. >>> >> >> Kyle, sorry I didn't see the post in the users list. I think the issue is >> that the new primary is missing the bond MAC address on it's valid MACs >> list, hence it is dropping the ingress packets after a fail-over event, >> placing the all the slave devices into promiscuous mode as you suggest in >> option 2 would probably make the issue go away but I don't think it's the >> correct solution. I think we should just be adding the bond MAC to each >> slaves devices valid MAC list. As only one bond slave is only active at any >> time this won't cause any issues to the network, and will mean that fail >> over is transparent to your application and there is no need for MAC >> rewrites, which would invalidate existing ARP table entries at downstream >> end points. > > Hey Declan, > > Thanks for the prompt response. > > I agree with your suggestion. Does this MAC list propagate to the slave NICs' hardware layers? > That is, even if a slave isn't in promiscuous mode, if it receives a frame addressed to any > MAC in its list, it will accept it and deliver it to the software? Or, does it mean we need to > put the slave into promiscuous mode, but filter any MACs not in its list (unless the bond > interface itself is in promiscuous mode)? > > Thanks, > > Kyle > Yes it would be into the hw tables, rte_eth_dev_mac_addr_add() on each slave port should achieve this, so there will be no need to run in promiscuous mode. I'll try and setup a test for this on Monday morning in our lab. Declan