From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 982E1A04B5; Thu, 29 Oct 2020 15:48:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 684A4CE6A; Thu, 29 Oct 2020 15:48:41 +0100 (CET) Received: from qrelay57.mxroute.com (qrelay57.mxroute.com [172.82.139.57]) by dpdk.org (Postfix) with ESMTP id A7C25CE64 for ; Thu, 29 Oct 2020 15:48:38 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay57.mxroute.com (ZoneMTA) with ESMTPA id 17574d4f8580004441.002 for ; Thu, 29 Oct 2020 14:48:35 +0000 X-Zone-Loop: 041d3a5d83124ab92eb59e040cbab47653036a2230dc X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id 5C9FC3EACE; Thu, 29 Oct 2020 14:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BLOXcCLFFc38AOuVakO3T5WvQHL35HDZmJcVD0OeIg4=; b=ItfqYar7xZb0InMnMMJ5WCvlw3 bXRd/hKeIVHI8hnclODWNEN9urFgnLw5tQQCCcrHWluYbqus2C5nELah/XhgkanENuzR5bPmFCrtp CY7BtWDslj4imqsQyhzTVo2mow5tWnZ+pGD3P+QcE9OtSrCMgWOyUoLwCovC/ncexT0hZvzyEr2W0 2Jcq1d74sAkFjRgZeu5DiX7iN627Rbd5moIL5ZYoJQivdTXDXVSX67eXOo7l14CrNBrSeQQ4IkGs5 fbzSXpJ/LSpFx1tqedIv6F5q1fhxQQD7oDgY5kmdAe75jvHZC1z4S8RDHS3O88mTfomhWiVLf0XAI btltloYg==; To: Thomas Monjalon , dev@dpdk.org Cc: ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com, Neil Horman References: <20201029092751.3837177-1-thomas@monjalon.net> <20201029092751.3837177-15-thomas@monjalon.net> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <8f09a4b6-356a-6f11-1e47-4d88b09d7d55@ashroe.eu> Date: Thu, 29 Oct 2020 14:48:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201029092751.3837177-15-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH 14/15] mbuf: remove deprecated timestamp field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29/10/2020 09:27, Thomas Monjalon wrote: > As announced in the deprecation note, the field timestamp > is removed to allow giving more space to the dynamic fields. > The related offload flag PKT_RX_TIMESTAMP is also removed. > > Signed-off-by: Thomas Monjalon > --- > app/test/test_mbuf.c | 1 - > doc/guides/rel_notes/deprecation.rst | 1 - > doc/guides/rel_notes/release_20_11.rst | 4 ++++ > lib/librte_ethdev/rte_ethdev.h | 4 +++- > lib/librte_mbuf/rte_mbuf.c | 2 -- > lib/librte_mbuf/rte_mbuf.h | 1 - > lib/librte_mbuf/rte_mbuf_core.h | 12 +----------- > 7 files changed, 8 insertions(+), 17 deletions(-) > > diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c > index 80d1850da9..85c150d843 100644 > --- a/app/test/test_mbuf.c > +++ b/app/test/test_mbuf.c > @@ -1621,7 +1621,6 @@ test_get_rx_ol_flag_name(void) > VAL_NAME(PKT_RX_FDIR_FLX), > VAL_NAME(PKT_RX_QINQ_STRIPPED), > VAL_NAME(PKT_RX_LRO), > - VAL_NAME(PKT_RX_TIMESTAMP), > VAL_NAME(PKT_RX_SEC_OFFLOAD), > VAL_NAME(PKT_RX_SEC_OFFLOAD_FAILED), > VAL_NAME(PKT_RX_OUTER_L4_CKSUM_BAD), > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 0f6f1df12a..72dbb25b83 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -86,7 +86,6 @@ Deprecation Notices > `this presentation `_. > The following static fields will be moved as dynamic: > > - - ``timestamp`` > - ``seqn`` > > As a consequence, the layout of the ``struct rte_mbuf`` will be re-arranged, > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index 3cec526b6a..deb99d6d98 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -429,6 +429,10 @@ API Changes > * mbuf: Removed the unioned fields ``userdata`` and ``udata64`` > from the structure ``rte_mbuf``. It is replaced with dynamic fields. > > +* mbuf: Removed the field ``timestamp`` from the structure ``rte_mbuf``. > + It is replaced with the dynamic field RTE_MBUF_DYNFIELD_TIMESTAMP_NAME > + which was previously used only for Tx. > + > * pci: Removed the ``rte_kernel_driver`` enum defined in rte_dev.h and > replaced with a private enum in the PCI subsystem. > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 3be0050592..619cbe521e 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1345,6 +1345,8 @@ struct rte_eth_conf { > #define DEV_RX_OFFLOAD_JUMBO_FRAME 0x00000800 > #define DEV_RX_OFFLOAD_SCATTER 0x00002000 > /** > + * Timestamp is set by the driver in RTE_MBUF_DYNFIELD_TIMESTAMP_NAME > + * and RTE_MBUF_DYNFLAG_RX_TIMESTAMP_NAME is set in ol_flags. > * The mbuf field and flag are registered when the offload is configured. > */ > #define DEV_RX_OFFLOAD_TIMESTAMP 0x00004000 > @@ -4654,7 +4656,7 @@ int rte_eth_timesync_write_time(uint16_t port_id, const struct timespec *time); > * rte_eth_read_clock(port, base_clock); > * > * Then, convert the raw mbuf timestamp with: > - * base_time_sec + (double)(mbuf->timestamp - base_clock) / freq; > + * base_time_sec + (double)(*timestamp_dynfield(mbuf) - base_clock) / freq; > * > * This simple example will not provide a very good accuracy. One must > * at least measure multiple times the frequency and do a regression. > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > index 8a456e5e64..09d93e6899 100644 > --- a/lib/librte_mbuf/rte_mbuf.c > +++ b/lib/librte_mbuf/rte_mbuf.c > @@ -764,7 +764,6 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask) > case PKT_RX_QINQ_STRIPPED: return "PKT_RX_QINQ_STRIPPED"; > case PKT_RX_QINQ: return "PKT_RX_QINQ"; > case PKT_RX_LRO: return "PKT_RX_LRO"; > - case PKT_RX_TIMESTAMP: return "PKT_RX_TIMESTAMP"; > case PKT_RX_SEC_OFFLOAD: return "PKT_RX_SEC_OFFLOAD"; > case PKT_RX_SEC_OFFLOAD_FAILED: return "PKT_RX_SEC_OFFLOAD_FAILED"; > case PKT_RX_OUTER_L4_CKSUM_BAD: return "PKT_RX_OUTER_L4_CKSUM_BAD"; > @@ -808,7 +807,6 @@ rte_get_rx_ol_flag_list(uint64_t mask, char *buf, size_t buflen) > { PKT_RX_FDIR_FLX, PKT_RX_FDIR_FLX, NULL }, > { PKT_RX_QINQ_STRIPPED, PKT_RX_QINQ_STRIPPED, NULL }, > { PKT_RX_LRO, PKT_RX_LRO, NULL }, > - { PKT_RX_TIMESTAMP, PKT_RX_TIMESTAMP, NULL }, > { PKT_RX_SEC_OFFLOAD, PKT_RX_SEC_OFFLOAD, NULL }, > { PKT_RX_SEC_OFFLOAD_FAILED, PKT_RX_SEC_OFFLOAD_FAILED, NULL }, > { PKT_RX_QINQ, PKT_RX_QINQ, NULL }, > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index a1414ed7cd..6774c6281b 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -1108,7 +1108,6 @@ __rte_pktmbuf_copy_hdr(struct rte_mbuf *mdst, const struct rte_mbuf *msrc) > mdst->tx_offload = msrc->tx_offload; > mdst->hash = msrc->hash; > mdst->packet_type = msrc->packet_type; > - mdst->timestamp = msrc->timestamp; > rte_mbuf_dynfield_copy(mdst, msrc); > } > > diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h > index a65eaaf692..52ca1c842f 100644 > --- a/lib/librte_mbuf/rte_mbuf_core.h > +++ b/lib/librte_mbuf/rte_mbuf_core.h > @@ -149,11 +149,6 @@ extern "C" { > */ > #define PKT_RX_LRO (1ULL << 16) > > -/** > - * Indicate that the timestamp field in the mbuf is valid. > - */ > -#define PKT_RX_TIMESTAMP (1ULL << 17) > - > /** > * Indicate that security offload processing was applied on the RX packet. > */ > @@ -589,12 +584,7 @@ struct rte_mbuf { > > uint16_t buf_len; /**< Length of segment buffer. */ > > - /** Valid if PKT_RX_TIMESTAMP is set. The unit and time reference > - * are not normalized but are always the same for a given port. > - * Some devices allow to query rte_eth_read_clock that will return the > - * current device timestamp. > - */ > - uint64_t timestamp; > + uint64_t unused; > > /* second cache line - fields only used in slow path or on TX */ > RTE_MARKER cacheline1 __rte_cache_min_aligned; Acked-by: Ray Kinsella