From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E772A0C43; Fri, 22 Oct 2021 17:20:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 052044117E; Fri, 22 Oct 2021 17:20:45 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 17FCB41149 for ; Fri, 22 Oct 2021 17:20:42 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="216488821" X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="216488821" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 08:20:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="595579210" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 22 Oct 2021 08:20:42 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 08:20:41 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 08:20:41 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 08:20:41 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 08:20:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kNBSzIwr+zDmNe3mrJ8HRTBVTn7kr2HT02FcAlMsRZphWcIzHLF6xiy+UesM2NAUtJHsifenHIUiv0DPQ28InGTp0MtRhZe3XYbQIIjve3L3w8pnrjutGt1mrTA0ivwcebkkjVGA8Szy3WHdWzSFma2bd8OeZy4jIYyTYwGEFbs+cawrw//zo+vOt7o1Nyfldls46RfAV6qhat2bqsFppWLLEDanAMxwgJWnZrvyZDmxlGxoxhh/xTw/zq4LGt2EF8qkC7lYwsOm0afMV+RXjMx7ofBLBTUsd6191HVfQiUk4/pvOE4x4OC0hJOu5HSdY6JK3aUImbAr5h1bMJHwNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=95nKnXgKPKfkGbv9b8kY0U1nxXQuBTO64GEvBI3Hhfk=; b=QNc0JXmlMG226FtFZwIMyWB8AQnO8IGGg6Uw+9YK2EsIACOvFP/dYvmDU9HB0LO0JM4EvHrYAxv6ISEvTxmTWG9L50egc6YpQtAkV5fBpu/xwLt/0oiVMzrQDYbWGidbSodPKHgHohFu8FxYPFf+yWQjlSfSnoHPWVi2jf3nIzTqzGXUfpXVJ/LaTemYp/GmAj5+9l1IorO9wNNjLgMTqCzzZxDsfKdwOLfaGn7tpzx952dE+9xEvzjnirCfbJmAHuIlJ/QOKResxq8DcjJg9lKox0jYJA8lGNWXTi7subOpJLm8vN9iKoXTMB4SlDD8j37NrQOdhZb0uszUZmzVSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=95nKnXgKPKfkGbv9b8kY0U1nxXQuBTO64GEvBI3Hhfk=; b=rfwuw1l/C0kB2xI40Z/GJ9zwYPX4jgOwWy9Ul8MCEVwBXelPCJbYhOKRelhKM5yPgySQ1POkRtMt75L+bYxlhl+AAolCJ3On3ff+OQAPKKgo2suv+n+OHss3qd/R/pywYK2e21vPUXJRtLOxgiSB9NblcG2lnt5ciq3GXanIdX4= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4790.namprd11.prod.outlook.com (2603:10b6:510:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Fri, 22 Oct 2021 15:20:37 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 15:20:37 +0000 Message-ID: <8f1804a8-b53a-bb50-6701-e7afd77e8b8d@intel.com> Date: Fri, 22 Oct 2021 16:20:29 +0100 Content-Language: en-US To: "Jiang, YuX" , "Wang, Haiyue" , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "Zhang, Qi Z" , Hyong Youb Kim , Michal Krawczyk , Andrew Rybchenko , Somnath Kotur CC: "dev@dpdk.org" , Thomas Monjalon , David Marchand References: <20211022121708.1591089-1-ferruh.yigit@intel.com> <20211022125716.2706937-1-ferruh.yigit@intel.com> <20211022125716.2706937-2-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB3PR06CA0027.eurprd06.prod.outlook.com (2603:10a6:8:1::40) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR06CA0027.eurprd06.prod.outlook.com (2603:10a6:8:1::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 15:20:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f41faea-0a66-4c13-dca8-08d9956f8001 X-MS-TrafficTypeDiagnostic: PH0PR11MB4790: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ipyy/j0/fPLAOYXB32JSfIEXkNxY+3+wxZTMbL37UkIZcqmMPg8WKxPe0WtJp8gu/A56HCqL1KhtYHnLQzph6NfpCGJxpKWf0S0ZToJ5O1hXvAw2zDOhMoZfo86t59gPpl430Ly8QAq73H+SfmBXCw8TXtYqwKEF4iuGqPpMCuEsw1r3SR/YjV4frftps+VYbBcXFp568d1nHidETfj+bYGWrTHnScaQ4l7gliB0BugnXZOMbWbJGDSHnLv8V1FVLkbO2n48IuMs3djo7N4f7zLmy5p7NR/6pSo+cz5XBCWJpxWmOyqerA8g3rmxLz/xDlzG7louGxYAo3DyxzY7V617zjbAqCIQ9JIhdCmiyBPIVeMP0o0RZjXsYDaVHKIxAdSIPsjGt7QLqz9vzYyzTelezvPrBPA8v2Z5pOF1bNlx4DJOcSY3xDih9G43YV8tqphaxmuBhGMRRCrPWrqJQtdBfR3hPbotE6YezMTbeY0MRuXOG94Tf25MVHLxcaBcc233+ee3GGMWUSwQeCAvhYhifMw2wDnZixJlAw8CQVQRk02bxRAZaXfSmobuGyzSoG7GIUNu86sUpavmgJgd8saZW2sksex99g3ZK7cfa5oYciMFo5zCGToJGeG5lvixvFZhZ7fei4Jpnl/nMtS+vNXwTy08KDryGlB0yMHF/BXLaAQXvAjTH5JzoyYFebYzFD+GwJronXf9q9BnE59tQ7dhKl70E2s8jVU6XAfLV7Zyrho74kM3JCdonvSQWegANCLbDKXGbAljEwyabhIW5mHIpCkXNhFhIXinRkwKTTRjONp/rL8HaEY/JaJsJwHm X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6666004)(110136005)(2616005)(6486002)(83380400001)(54906003)(956004)(31686004)(82960400001)(316002)(66946007)(44832011)(86362001)(4326008)(16576012)(36756003)(31696002)(66476007)(5660300002)(66556008)(508600001)(186003)(26005)(38100700002)(966005)(2906002)(921005)(8936002)(8676002)(53546011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnJrR2lUMG1URHZYTDdaSEVFSVNSQ3BWZ0hZbzVHUjYzd0xnWmJoc3U4dGov?= =?utf-8?B?Qk56MjQzOExwQmh4Sk5tcno3UGhrSWQ3ZDdmUGtGa0liY2ZMdHEyM2kvcGty?= =?utf-8?B?N2lSdHpieTNpeFhwamd1Z0t4RHUvUE9IM2pHcDdxaHNxbWNkMWtCZzF6UnIz?= =?utf-8?B?MUFBaVRiSmE5cmJPTFA1TFVTdlIxbWFkSkRSclBmd1FuYkZQQ1h5cExKREgr?= =?utf-8?B?RE9Sb3RlVmpkaUdzT25ldjlRSHcxY0g1R3U5THRQQzhuV1ZtbkhXZkNqSnUx?= =?utf-8?B?Ty91Rmx2T3Zxczg1bncwR1pVUG1zUjZxTjNsdFgra0JGSlBueTh2R0wzRTN1?= =?utf-8?B?VmJWYVh0QXJBZVBlZ0xGVmNRS3FQMUs5Q2xsSjdNUzVBRkhaZ2hVdmpxd2cr?= =?utf-8?B?d0tIN2tKM2wxUU9mQ3dXN1ViVkZIMUxabTY0b2J0RERWYlliNE1JcjBGZHdW?= =?utf-8?B?dytXWGRDSGt4TVVFN3Z5T0pCazhHTW0wRVhXcGdxTHE0dFl1YitobzhMM1hQ?= =?utf-8?B?YUgyUmx3Y0UyZU9MWjlYVWFqc2hRSWlhVEZlTUhUbDFlM3N0bEx5VVMvcEU2?= =?utf-8?B?VTlEaWw3VkNmRVFoOXIvcU1zb2VJT3RzcWU5Z2FWNGZCeEhiNkNBREtsbVNr?= =?utf-8?B?NHpXZVZQK0l4SjdhajFnQktjNU5EZzZKQ3VtaXE4aVVZWTVvWERIclh1UkF4?= =?utf-8?B?cUpjVEdtL0d5bVNKTVdJN01pU3RwWWNoOFRLYk8vMzlMRy93YUhOa21ZTm1l?= =?utf-8?B?ODVsd0QxK2lxSXFYWER2L2J6QVN2VjZId2x1Z0l6STRGY3dGZDlkdnh3ZVR4?= =?utf-8?B?V1dJZTZqNTRxM0NwWlVnVGNUWDR4U1M5dG1LaUZydW92SE5rYlNVNmFNaFIr?= =?utf-8?B?VVk3Z2RWeGkwMVhXQm03ZHFRTCt5b3FhMVBydERoS3lhVGhZTk5XS3E1QjB5?= =?utf-8?B?czBCMXJnTHhmOWg4UlhQL1U2YjdxUjVIWUltcjM0WWZ3WjU5Zzhkd21DQk9z?= =?utf-8?B?ZUhGcUZZRzMyS2Q4Q0pWZ1BDeCtDbGw4Qy9QRUdLUEVjaTRZNjBBTzZjMUNQ?= =?utf-8?B?aURNUjZld0VWT3JvcThYTWVhNVZOalpLclc5T0J2SXNaSmUyOTJGeG50b3N6?= =?utf-8?B?REFGMnNRWnFiWVZPSWlQNFBPblZsMWhZSUlMbFcrYkV3YXFOKy9vK0EvWXg0?= =?utf-8?B?ZEpxYzJyRHRGM3ZiL05yZzRHVXp6TXI3K1N5ME5oejNhR0dOVFZOQTRvT09R?= =?utf-8?B?VnlpU2lCS0pDL2V2QUxpU0xiVnJjMFUzYTZNWXNROTVMazVOMTRlZTF5LzJY?= =?utf-8?B?V2RZSTZSWHZRRmNkcUo4YTRVb0tSV2xBcFkwd05uMGhiaUhya2ozOWVVTXRT?= =?utf-8?B?MGlPaG81MmtGeFBaSFcrVE50di9raStmQjQ1dVhnditmdmk2aitKS0R6cmNF?= =?utf-8?B?Zjl4ajZUWTJNSTZuQXlRaURBNVNRNVNMVDlLS1QxQzBGUzJBVHJwZVhIK2Z5?= =?utf-8?B?b1hFaWZlcXBDbnAvQUR6TjBIWDJGbTN3d2tXMW1NUDFTc014WXVTdG96SC9H?= =?utf-8?B?aEZuVnZRSlhZV2pEOUlkOW1hUkxvSDl5VUlWYW1WcG9tc2hXVXBxQy9hVWRn?= =?utf-8?B?L2EwRWF2TTdKUERmNjI4VEU4cSttakxOa05QQ3hTeWpHL3poNlN2K1Y0dmVM?= =?utf-8?B?dFJ6Snk2eHozcFBnQmtzNTZ5SDRWMXozM045dU5aUXFrekJQOHkrMloxSkRH?= =?utf-8?B?Wm5FTHVZWnpZRnIySk9oNHN0eEtwQU5TTG1IQmhZd3pQVHVsWDAwaUxtOWlr?= =?utf-8?B?WThRWjhQcHFQY2pwNkVRUnFsWDZaNTFUUmhMc2hPVkpvWFlsQVkzdWYrL3c1?= =?utf-8?B?dlRTbS94bUlUeHF6NVE1bHN1VFc2T1MrNHhUeVZaR1VISFpHTVpIcEdKNHV2?= =?utf-8?Q?xcMXGf0ZcGh0ojWVOEv/AoPjPkeMNvDK?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0f41faea-0a66-4c13-dca8-08d9956f8001 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 15:20:37.3559 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4790 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2021 3:10 PM, Jiang, YuX wrote: >> -----Original Message----- >> From: dev On Behalf Of Ferruh Yigit >> Sent: 2021年10月22日 20:57 >> To: Wang, Haiyue ; Xing, Beilei >> ; Wu, Jingjing ; Yang, Qiming >> ; Zhang, Qi Z ; Hyong Youb >> Kim ; Michal Krawczyk ; Andrew >> Rybchenko ; Somnath Kotur >> >> Cc: Yigit, Ferruh ; dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload >> flag >> >> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo >> frame decisions based on MTU value checks, but some of the checks were >> wrong by mistake, causing device initialization to fail, fixing them. >> >> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag") >> >> Signed-off-by: Ferruh Yigit > > Tested-by: Yu Jiang > Verify patchset v2 https://patches.dpdk.org/project/dpdk/patch/20211022125716.2706937-2-ferruh.yigit@intel.com/ on dpdk main branch(f4acb429d0 (HEAD, origin/main) hash: promote some functions to stable) > Tested on i40e(iavf) and it looks good, will test more on others. > Thanks Yu, I can see it is not fully validated, and most likely it won't be before -rc1, but it would be good to have this fix for -rc1 to not block testing. Since the previous code is clearly wrong, and fixes are similar between drivers, if one is good I will take risk and merge the fix for -rc1.