From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8B4CE3255 for ; Tue, 28 Nov 2017 23:31:06 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2017 14:31:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,468,1505804400"; d="scan'208";a="7274345" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.203]) ([10.241.225.203]) by fmsmga004.fm.intel.com with ESMTP; 28 Nov 2017 14:31:05 -0800 To: Hemant Agrawal Cc: dev@dpdk.org References: <1493810472-668-1-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: <8f1ddb5e-661e-6413-00ab-31814a7d5bf7@intel.com> Date: Tue, 28 Nov 2017 14:31:05 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1493810472-668-1-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC PATCH 1/5] kni: change and configure mac address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 22:31:06 -0000 On 5/3/2017 4:21 AM, Hemant Agrawal wrote: > This patch adds following: > 1. option to configure the mac address during create > 2. inform usespace, if mac address is being changed in linux > > Signed-off-by: Hemant Agrawal Hi Hemant, This RFC is waiting in patchwork for a while, is there plan to send a v1? I will mark patchset as RFC in patchwork. As far as I can follow latest patchset status is: provide initial value and add capability to change 1/5: MAC address 2/5: promisc mode 3/5: MTU There is a change request for 1/5, other two looks OK. But for all three the action done in kni_ops, which means application needs to implement these features. Not sure about pushing these common tasks to application, instead of all applications implement same thing, does it make sense to implement them in kni library? 4/5: add gso_size info Nak because it uses mbuf field with another meaning 5/5: Add cleanup fix for multi process Multi process support is not supported in KNI at first place, if there is a need first it needs to be introduced and tested. Thanks, ferruh