From: Remy Horton <remy.horton@intel.com>
To: Igor Ryzhov <iryzhov@nfware.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] rte_ether: Driver-specific stats getting overwritten
Date: Thu, 14 Jul 2016 16:50:40 +0100 [thread overview]
Message-ID: <8f3d7b0d-6b74-ec2e-94d3-075f1c055bac@intel.com> (raw)
In-Reply-To: <04EE3350-421C-47F9-9D6F-A1D4992FD932@nfware.com>
On 14/07/2016 14:51, Igor Ryzhov wrote:
[..]
> How about deleting rx_nombuf from rte_eth_stats? Do you think this
> counter is necessary? It just shows enormous numbers in case of a
> lack of processing speed. But we already have imissed counter which
> shows real number of packets, dropped for the same reason.
Deleting it has API/ABI breakage issues. There is also lack of
consistency between drivers as to what imissed includes, as some don't
implement it at all whereas others include filtered packets as well.
>> 14 июля 2016 г., в 16:37, Thomas Monjalon
>> <thomas.monjalon@6wind.com> написал(а):
>>
[..]
>> Yes it is strange and has always been like that. Why not moving the
>> assignment before calling the driver callback?
Think I'll do that. Easier than updating all the drivers that don't fill
it in..
prev parent reply other threads:[~2016-07-14 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 13:29 Remy Horton
2016-07-14 13:37 ` Thomas Monjalon
2016-07-14 13:51 ` Igor Ryzhov
2016-07-14 15:50 ` Remy Horton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f3d7b0d-6b74-ec2e-94d3-075f1c055bac@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).