From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 0BCFBF94
 for <dev@dpdk.org>; Thu, 14 Jul 2016 17:50:42 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 14 Jul 2016 08:50:42 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,363,1464678000"; d="scan'208";a="1021753551"
Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.230.104])
 ([163.33.230.104])
 by fmsmga002.fm.intel.com with ESMTP; 14 Jul 2016 08:50:40 -0700
To: Igor Ryzhov <iryzhov@nfware.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1195a38d-8615-03d2-22eb-04f6b071d38b@intel.com>
 <1954062.51W9tGj6hj@xps13> <04EE3350-421C-47F9-9D6F-A1D4992FD932@nfware.com>
Cc: dev@dpdk.org
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
Message-ID: <8f3d7b0d-6b74-ec2e-94d3-075f1c055bac@intel.com>
Date: Thu, 14 Jul 2016 16:50:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <04EE3350-421C-47F9-9D6F-A1D4992FD932@nfware.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] rte_ether: Driver-specific stats getting overwritten
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2016 15:50:43 -0000


On 14/07/2016 14:51, Igor Ryzhov wrote:
[..]
> How about deleting rx_nombuf from rte_eth_stats? Do you think this
> counter is necessary? It just shows enormous numbers in case of a
> lack of processing speed. But we already have imissed counter which
> shows real number of packets, dropped for the same reason.

Deleting it has API/ABI breakage issues. There is also lack of 
consistency between drivers as to what imissed includes, as some don't 
implement it at all whereas others include filtered packets as well.


>> 14 июля 2016 г., в 16:37, Thomas Monjalon
>> <thomas.monjalon@6wind.com> написал(а):
>>
[..]
>> Yes it is strange and has always been like that. Why not moving the
>> assignment before calling the driver callback?

Think I'll do that. Easier than updating all the drivers that don't fill 
it in..