From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E8A1A0548; Mon, 30 Aug 2021 03:04:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B27DF4068A; Mon, 30 Aug 2021 03:04:42 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 26E9E40142 for ; Mon, 30 Aug 2021 03:04:40 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10091"; a="218198637" X-IronPort-AV: E=Sophos;i="5.84,362,1620716400"; d="scan'208";a="218198637" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2021 18:04:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,362,1620716400"; d="scan'208";a="688907491" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga005.fm.intel.com with ESMTP; 29 Aug 2021 18:04:40 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 29 Aug 2021 18:04:39 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 30 Aug 2021 09:04:37 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.010; Mon, 30 Aug 2021 09:04:37 +0800 From: "Zhang, Qi Z" To: Tudor Cornea , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/iavf: fix overflow in maximum packet length config Thread-Index: AQHXie4QcJoRPg1zs0i1LI63QMmeAauLYfWQ Date: Mon, 30 Aug 2021 01:04:37 +0000 Message-ID: <8f48fc483a784502b124b69d6a1dd916@intel.com> References: <1628163323-87134-1-git-send-email-tudor.cornea@gmail.com> In-Reply-To: <1628163323-87134-1-git-send-email-tudor.cornea@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix overflow in maximum packet length config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Tudor Cornea > Sent: Thursday, August 5, 2021 7:35 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: Zhang, Qi Z ; dev@dpdk.org; Tudor Cornea > > Subject: [PATCH] net/iavf: fix overflow in maximum packet length config >=20 > The len variable, used in the computation of max_pkt_len could overflow, = if > used to store the result of the following computation: >=20 > rxq->rx_buf_len * IAVF_MAX_CHAINED_RX_BUFFERS >=20 > Since, we could define the mbuf size to have a large value (i.e 13312), a= nd > IAVF_MAX_CHAINED_RX_BUFFERS is defined as 5, the computation mentioned > above could potentially result in a value which might be bigger than > MAX_USHORT. >=20 > The result will be that Jumbo Frames will not work properly >=20 > A similar fix was submitted for the ice driver Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: stable@dpdk.org >=20 > Signed-off-by: Tudor Cornea Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi