From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77D73A04C0; Thu, 17 Sep 2020 17:54:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 47A951D6B3; Thu, 17 Sep 2020 17:54:56 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id A19471BEB2; Thu, 17 Sep 2020 17:54:54 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.143]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 22B1620080; Thu, 17 Sep 2020 15:54:54 +0000 (UTC) Received: from us4-mdac16-35.at1.mdlocal (unknown [10.110.49.219]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 1CAF88009B; Thu, 17 Sep 2020 15:54:54 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.6]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 9E18840077; Thu, 17 Sep 2020 15:54:53 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 16D76B00066; Thu, 17 Sep 2020 15:54:53 +0000 (UTC) Received: from [127.0.0.27] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 17 Sep 2020 16:54:43 +0100 To: Vipul Ashri , CC: , , , , References: <20200813072837.1468-1-vipul.ashri@oracle.com> <20200916055725.1473-1-vipul.ashri@oracle.com> From: Andrew Rybchenko Message-ID: <8f4ad1d3-bdb3-0c93-4f8f-78941228855b@solarflare.com> Date: Thu, 17 Sep 2020 18:54:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200916055725.1473-1-vipul.ashri@oracle.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25670.006 X-TM-AS-Result: No-1.586400-8.000000-10 X-TMASE-MatchedRID: +c13yJDs903mLzc6AOD8DfHkpkyUphL9PSgberZ8hXIep400rdpOCylA /rS07QvhZAJRHrn2lvF6MBOevfwGOFtv7lVTl559Gi6hW8XaLRkB4JHtiamkLB3RY4pGTCyHEG3 UzQEO6wqVq7gfVdvJl5GTpe1iiCJq71zr0FZRMbBcO65jrNll89mzcdRxL+xwKrauXd3MZDVoDX 4hUJTsxEiCKWGCOZ0N+EWDHqy8SccPlvMg+i4KzVCX8ys2t6QMDp14lngexJmyPm4BrUr9yMkW6 iI8/GT+BETGxetxQ5/ckuSCE1s4MAbEQIfFpkwHBtlgFh29qnpKzBwu5JpklnOUuoTXM7r4Qwym txuJ6y0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--1.586400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25670.006 X-MDID: 1600358094-xcG00aAbitpU Subject: Re: [dpdk-dev] [PATCH v4] net/virtio: fix wrong variable assignment in helper macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/16/20 8:57 AM, Vipul Ashri wrote: > Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always > failing as assignment done using var_ having local scope only. > This leads to TX packets not going out and found broken due to cleanup > malfunctioning. This patch fixes the wrong variable assignment. > > Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions") > Cc: stable@dpdk.org > > Signed-off-by: Vipul Ashri Acked-by: Andrew Rybchenko