From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B68ED5F2B for <dev@dpdk.org>; Thu, 18 Oct 2018 09:12:20 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 80934140063; Thu, 18 Oct 2018 07:12:19 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 18 Oct 2018 08:12:13 +0100 To: Thomas Monjalon <thomas@monjalon.net>, <ferruh.yigit@intel.com> CC: <dev@dpdk.org>, <ophirmu@mellanox.com>, <bernard.iremonger@intel.com>, <rahul.lakkireddy@chelsio.com> References: <20180907233929.21950-1-thomas@monjalon.net> <20181018012402.1240-1-thomas@monjalon.net> <20181018012402.1240-4-thomas@monjalon.net> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <8f6b0aa9-91c3-4469-6c78-adfdc067ae51@solarflare.com> Date: Thu, 18 Oct 2018 10:11:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181018012402.1240-4-thomas@monjalon.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24162.003 X-TM-AS-Result: No-3.733600-8.000000-10 X-TMASE-MatchedRID: u1zqiMeMcroOwH4pD14DsPHkpkyUphL9mX+W7bzPOQEOAHqXajwVGFkx R/OK+HA0u5Uli5Yf9rtB7MMuBT6qhAzyMxeMEX6wOX/V8P8ail2cIZLVZAQa0IwZVlv5NpEAUEh Wy9W70AFYF3qW3Je6+9b5AbTS3sr5RWX6quQmvtLVWhH54SvIM8zSil3Hh2nhXTJjiT6hy8y4dk 5tWocNkBpMbwze/IgtG8VjnnvE8tFmWMstSOG9VfAdfn5DyOPDXC6uJnc/p0SsglkltB8xdGpoz kualSTDO6clcnPxfVB+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.733600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24162.003 X-MDID: 1539846740-fHnMchkPNYaE Subject: Re: [dpdk-dev] [PATCH v5 3/6] ethdev: fix doxygen comments of shared data fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 18 Oct 2018 07:12:21 -0000 On 10/18/18 4:23 AM, Thomas Monjalon wrote: > Some doxygen comments were wrongly associated to the next field > because of syntax /** instead of /**< > > Some other cleanups (like alignment) are done. > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com> Yesterday I made similar patch, but moving corresponding comments before its structure members to make doxygen usage correct. It looks also good when post-comments are indented as you do.