From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2975FA0C55; Mon, 9 Aug 2021 17:32:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB7144068A; Mon, 9 Aug 2021 17:32:28 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 680D64003C for ; Mon, 9 Aug 2021 17:32:26 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="194309360" X-IronPort-AV: E=Sophos;i="5.84,307,1620716400"; d="scan'208";a="194309360" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 08:32:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,307,1620716400"; d="scan'208";a="444537224" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 09 Aug 2021 08:32:25 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 08:32:24 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 08:31:37 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 9 Aug 2021 08:31:37 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 9 Aug 2021 08:31:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dgb9Y2xd18eJ4UURNG67fGD8ishMRpUvQxQ3IcyTPIZbEdY/hfyXFS5tgoj5odyzlK0OZpC+wCk30Z+VtP+XQHOiQS76ZoaI4gkyNNjnOxn8KjfgsDifWLNXAltWg/Hjqjl+l1eoc7dwyT8rE4/ensZcelk30HZtqo6HIzQib+uBdFAsyhvo1KNT3kX7+SR6HbuUTgfbUTvF/y2S7PKzB59VLpbBkAKZY0NFLjKOpmsXuo0ub4kXxni7ku3Kisf1LI9sXYNPmDZ6w/X3omrSLTin1PIO+2ud0al+9b37ldNdMsiblkpk8UTinmhLTGEICsawbGqwSozEzC66/vX5mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTMmKbehfV360eYlQ94Cb4Erqsu7IwFqYEbAdNzRZpQ=; b=C5rJjVKFQF3Fm2324vJxTDoSY1ey/8dDSkuVasDcoIDjZvx+oytq4pHthFF0ROWusbSCcAkn4oXJGI+rYBZ5KYiZxEJUNQwXrREbKZSQpJJ5hz7YFJGGbABJXZSpROQBR2SKJJVdCTckEmPGM/xMFe7u5dtUz9QFviBu078rQbsC6OMRMb95Mw/uaFOJ1U4QLpOzlfkVStMMg1C2CSQm3R/5D6pCvhv2W2nzM8XtAUpM9A5usKKIS9+u1ni3THiF7Xooq82GumPXyfF7Ou7xY8d6p0bOT8uJ4kWBJpDTpA5C2mMtPoUf6APb2UYaX0m2Qc0t29qcjm1TgdYQxfRk/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTMmKbehfV360eYlQ94Cb4Erqsu7IwFqYEbAdNzRZpQ=; b=F3LSWeOMYpdqbrQO/UA47QE7nAsO0aNm0bX3WELC6/D81lZuxPdc0uxoZ2Rs12hYc+CcIyYGLqaApcuxooMnLBG+Liwm0lruW6Hv0UbMTdz4VHuBSxEskGg46/6uEmBltkL3aGvKBZdcwGfJrLAq/Vg1XrqD1Fc5ks96Pm3xero= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5191.namprd11.prod.outlook.com (2603:10b6:510:3e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Mon, 9 Aug 2021 15:31:34 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%6]) with mapi id 15.20.4394.023; Mon, 9 Aug 2021 15:31:34 +0000 To: "Singh, Aman Deep" , Andrew Rybchenko , Xueming Li CC: , Viacheslav Ovsiienko , "Thomas Monjalon" References: <20210727034134.20556-1-xuemingl@nvidia.com> <24309185-57e8-9a21-6b3a-939c4d74f1e7@oktetlabs.ru> <3032fdb1-58a5-5470-9903-09b992c059d4@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <8f8178d5-65e5-43f4-fc17-f753183e8042@intel.com> Date: Mon, 9 Aug 2021 16:31:28 +0100 In-Reply-To: <3032fdb1-58a5-5470-9903-09b992c059d4@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR3P251CA0024.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by PR3P251CA0024.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Mon, 9 Aug 2021 15:31:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a445952e-06a7-4fad-b4f9-08d95b4ac551 X-MS-TrafficTypeDiagnostic: PH0PR11MB5191: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4Td0yzhfwzvAf3wUrF6t9sHXcUu/whgKacZoYwKEeFwupn+bdQC2PbRBH7lOFp5yh6yPDi48DP9GgfF6lsRozyisrmJajYnNJuyp4Fe5Z1OjloGPZIWUvB8kdIE369dMY1aQqahwxlf2uC3T+MS1HT+e4fsGguFIorsAi5kDPAw4/Gj9r2QtDOG1x+D3ieKHYKHaiVV1Gnf78JtDkBQg5xzjdrVf6EkdQZPc26TRYrAUcJQbI4nONQkvKN1j9HHHc2c+KrEkbUFdkDJBw05lru45oX6VrOfb9g08sJhDRwCtLbVeMAb9VKVx63pGuKzg/1bMMmiQk1vwQfqK4g9KosRP83N3ydDx3JzP73hCb5hMQqFRPAC062NB1ZgNPF7woOIdhSnIVxBMtl414sTZJa0WaoKXpBEXVrZKCjSDFzy73RXtLun6pxipgsY/BEoDVTA3y3vkK2b4AuMbGC2Ur/ZKqotyf2V/6IlK7vG+upFn4nJXLSDPiBuGEwq6m1tNiUU/QI22uJJ3uQEBEs/5tpDrq+TjoXGjNimHuZREoaBiHx7LQVaKcwHklov0r8CFjB/xLOxJkC2bhr45EKHpYkpB4sCt9+K5rXjrM2HkZzDaSFpzDSGuutUilzv9pLjpgn7Gr7HOVr12Wb1hxzDnhHdyytzfc1wH7AvXUrQsPYlh6pAAFjPf9AXQszJotKBN0jqJ580OKCOfFk7yaymcWw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(2616005)(4326008)(956004)(26005)(478600001)(186003)(5660300002)(38100700002)(53546011)(6666004)(6486002)(66946007)(54906003)(66556008)(66476007)(110136005)(2906002)(316002)(16576012)(31696002)(8676002)(36756003)(86362001)(31686004)(44832011)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWh1RVJxT1J0dWJqY2ZlT0FnSHVwTXNQS0lONFA5Z0V5UFNLMHc2V0p2WjBH?= =?utf-8?B?a3phZUljemdiNThqbkNadGVUU1B3R2JCaWJzWWxMYVhOY2ZPZ2xvcVExUHZ6?= =?utf-8?B?dzI2enBpbTdOWU56L3M5U1lremZoNjBWMjFMNi9VZDZxOGVjL1JYZ1VUQkpm?= =?utf-8?B?dThaV1o0dTJ5Y2I3L1Z6d1FXMU9tT2RGTVRZOTlzV2JublVuNVI2K2ZCN0JE?= =?utf-8?B?MWVPYWJmMFE4ZlprRHZyZmY5WkxyeXBBMDVVT2Q1Nlk5UDQzSlo5d3hEdnJJ?= =?utf-8?B?enE3d0RkRkF5L3hrV0R4R3I5YUdMRWtNQjRXbnVML215NnFVWlk5dGhCRmQ3?= =?utf-8?B?a0hVWkhKUVRhRjgwZWVXMXY2cnIxdFFHUUVqYmkxNWdsLzdTWXdOOThnTStB?= =?utf-8?B?aWp3TDJ3T1lmVXZodWh0cGdJN1krZ29iTEFpWHNjSEc2Zit2dVRKMzdVWEIw?= =?utf-8?B?SG9lNXViN0V6cEJlaXNlbjBMY25CNC9haFZRTTVMQUR0eFFkZENCemFPUGdF?= =?utf-8?B?RStNcThUMjhhaHlRWjFxNHd6SjFHSXdEQ3k4TzhLWEZnSHNyU0NSS0cwbGFT?= =?utf-8?B?TGhrUjlTcjRPckhCd0VwSzFxUm9qbWRjRk5UYmM1OHhCV2hReWs2L1hBT3VD?= =?utf-8?B?QUN4VFVIWjgwMkx6N1lYWDUwYjJyQVExTWYxR0s0ZjhjR1BHSzlib3ZMNmNM?= =?utf-8?B?TmpnQnFjRmQ2SG4wb0NZUEpNaFBhazRneEUzQk52cjdNODFOTEUrNzlSVEVi?= =?utf-8?B?WGgrRGRVWTBGcHZKSWNTZ0JVRTdMZ2VaTndYaFJGNWhFejd5UVozaC80b05i?= =?utf-8?B?dmkxNEFnZ1JRT1ZqcGVvUHc2elg4RW9acmFwTGNOdlBLRlRBeWhob1I3VEE0?= =?utf-8?B?OEh1TW9nWWRPMVNtbXNDL1ZxYyswZTN5ZFRkYU10b3NmckgxSzAvajdLRkVv?= =?utf-8?B?VEdWV05BZml6NGNnUzdwOG1PVlFIckhIRXlZMUNBeVYxVGJuYjRueWN3R0Vh?= =?utf-8?B?SzMydXAyaFNUSUY1RUpMSEhKRGtjaEJYS2JVTUQ0eWIybFlVNnhRSCt4bUlt?= =?utf-8?B?YVFzZUU2ZzZERy9qQ0ZjeEd4V1Z2dlQ1bE5xb2pJSXVOQ3QwMFFzVXA0OUlX?= =?utf-8?B?Umx6eWFzYXVvd3UydExuNE1wbFBWc215UWdrMXJIbTZxenA3bDJRYXBDSUc3?= =?utf-8?B?YXBuMFJERmRheC9JVStFSWhHSml4QWpNTjRtay9EeFJIV0ZsVWR0cGIyVjFC?= =?utf-8?B?am9KR3RXWVluRnU4NERybC9QN2wvRWw1c0pGTXl4eHR2ZGh3UHpnRjV0R2xi?= =?utf-8?B?Y2Q4Z1A4MEI5OWMybVJXb1drYUM4YTYzQkMrbCt2d1ZGUDRORVVYU1p6Qlh5?= =?utf-8?B?R0NRZ2NPaDJmWjByVGtVU0hEOGxuNkNMNTlKTGY5K2FiUERrbnV2MlZobm1Z?= =?utf-8?B?WStEekZDakZ1ZHcycWplZmF5MWFOOVZBNUNJWGtoR0kyY2FYVVdXVEVVd1Zx?= =?utf-8?B?WVNWVksvWnJ3TkwxK3R1bDNUOXpabUJvdVJ3SUt4KzlJZEQzQnNhOW1WQ2Mv?= =?utf-8?B?S2xxUlN6QktpbTR6Z084T0NqeC9UYU0xbzlWaWJPa1dkSFBIcTZpaGpzU21Z?= =?utf-8?B?Wnh2cFM4T1pRVVRUNDg1dDJoQUlsYkg4TmdMcUIyeDBnMk41NEJ6a1Bqdkc0?= =?utf-8?B?RWhkdlMwbEcwblN2c242YWFCb0pFcXB5K3VvSXBhVzJSTFFZeDFqZ0xidVRL?= =?utf-8?Q?r/dkm2AGMny/Mt9gGowI181GrCGmyqOLGx2ClmO?= X-MS-Exchange-CrossTenant-Network-Message-Id: a445952e-06a7-4fad-b4f9-08d95b4ac551 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2021 15:31:34.6825 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6eY0ki3E69lSqvSXzVo0gCUJK+inr2LwpeOM9I1n6TTYM5QMGbh24RgzQHkFbK9P1F36dsWiapCftEenmKeYsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5191 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/9/2021 3:39 PM, Singh, Aman Deep wrote: > Hi Xueming, > > On 7/28/2021 1:10 PM, Andrew Rybchenko wrote: >> On 7/27/21 6:41 AM, Xueming Li wrote: >>> To align with other eth device queue configuration callbacks, change RX >>> and TX queue release callback API parameter from queue object to device >>> and queue index. >>> >>> Signed-off-by: Xueming Li >> >> In fact, there is no strong reasons to do it, but I think it is a nice >> cleanup to use (dev + queue index) on control path. >> >> Hopefully it will not result in any regressions. > > Combined there are 100+ API's for Rx/Tx queue_release that need to be modified > for it. > > I believe all regression possibilities here will be caught, in compilation phase > itself. > Same here, it is a good cleanup but there is no strong reason for it. Since it is all internal, there is no ABI restriction on the patch, and v21.11 will be full ABI break patches, to not cause conflicts with this change, what would you think to have it on v22.02?