From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 442FAA04FD; Wed, 8 Jun 2022 15:10:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23476406B4; Wed, 8 Jun 2022 15:10:54 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2082.outbound.protection.outlook.com [40.107.236.82]) by mails.dpdk.org (Postfix) with ESMTP id 1BB0240687; Wed, 8 Jun 2022 15:10:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NwiQbN/GCqZsTKbQ1V1fDZA9ALgtPz5sibK2d1pHqeRcaVS+iipUR70D3rptsZW6SlK8VC60ICh6Hs4iVLE9Fhw3T9vRcCAdjk7y5llTsN9GGnbswQT8oV2XvRx6UREouFB4UIUt6LFUxichaJpg0A89X7ojxtAwi9a+ntAQlqsAfvr+ox4OvFbg8aQNS5o7CRUlapcm2P3wLkirVAzpmHY/WaorfOZYCSVFirYByA8+wa5Qgv3O4q9cfTYsX7YMo1kWvn/BM7BmuLvD5aPJFBopp32BjD4Ubh7DRGeGZ9Tt5T8ykwTIfhdFFktxB+m1WNpOX0IW/l6LOLDGrXTAmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VsJI7ZM1y1ZENNfb9KZv0uP0flOr43DXMILG7Z22hEo=; b=U0yJnDgLvpVGZIkioRcttZyjOLI3CsttrTS2HQrkGatbSeYBF7ExTikFjGUQKKrTv7B4zhSDUH+u0HIYpD1T1y9ZnRdoEt/5TUeV3zBpVdOE794zdkzTs1WpLO86k+VBXNNLmkbUeDTMWNjId4jaPET3GMU9Py37RaKDt4bfQ5n+tEczGWjaxmbvU3yDA+N53QTMcs9qmPEKz5rJ5FXI3F6+P0D/f5NMehJS0ugTFmc0q1t+ve9D24calXjlvaF0mgjmUOfiB2LQy7IOXz5zZKH8+jmKF4mCQi3BjC/q+nbGcyAP1dIRAOuACkKfPZedvf7FpKNetmQem6DJogeMMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=oktetlabs.ru smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VsJI7ZM1y1ZENNfb9KZv0uP0flOr43DXMILG7Z22hEo=; b=L9Dd4O1IUGdpwpO1Jn6mOAEcbpBSe5vrgwhauiAlPBomwVwvGgkRTYynWbxUh/shPCrss4KZpPrEDyp+D24zhIUi3sd4HUuFCSBaR4sBsYl015X+BxoIacpzFL7c0MWn+jw4Aic+2LJjGke7TTRQD3UrtUgYY5pVaUmCIysn6/o= Received: from BN9PR03CA0964.namprd03.prod.outlook.com (2603:10b6:408:109::9) by DM5PR02MB2729.namprd02.prod.outlook.com (2603:10b6:3:107::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Wed, 8 Jun 2022 13:10:49 +0000 Received: from BN1NAM02FT023.eop-nam02.prod.protection.outlook.com (2603:10b6:408:109:cafe::22) by BN9PR03CA0964.outlook.office365.com (2603:10b6:408:109::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.15 via Frontend Transport; Wed, 8 Jun 2022 13:10:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT023.mail.protection.outlook.com (10.13.2.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5332.12 via Frontend Transport; Wed, 8 Jun 2022 13:10:48 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 8 Jun 2022 14:10:47 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 8 Jun 2022 14:10:47 +0100 Envelope-to: andrew.rybchenko@oktetlabs.ru, stephen@networkplumber.org, dev@dpdk.org, humin29@huawei.com, ke1x.zhang@intel.com, stable@dpdk.org Received: from [10.71.117.247] (port=56249) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nyvSR-0002BH-39; Wed, 08 Jun 2022 14:10:47 +0100 Message-ID: <8f8a8cb6-4da1-fe52-5ac1-6a1a54b4c258@xilinx.com> Date: Wed, 8 Jun 2022 14:10:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 2/2] kni: fix warning about discarding const qualifier Content-Language: en-US From: Ferruh Yigit To: Andrew Rybchenko , Stephen Hemminger CC: , Min Hu , Ke Zhang , References: <20220531091330.230715-1-ke1x.zhang@intel.com> <20220608121117.1445731-1-andrew.rybchenko@oktetlabs.ru> <20220608121117.1445731-3-andrew.rybchenko@oktetlabs.ru> <6808bb6d-f107-9712-1466-a9adfd00a5c5@xilinx.com> In-Reply-To: <6808bb6d-f107-9712-1466-a9adfd00a5c5@xilinx.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69214b32-4177-4c04-6641-08da49504e60 X-MS-TrafficTypeDiagnostic: DM5PR02MB2729:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qpVI4KwKumh45zGN8Mu+4mWqcQNko91YFBieqeR9MQxXGPEdizIkf85LjwWliFRqr5besMf4nzhDkYBpQ+Z/ezTd+p7AGnorNJlqXbc5oD/R9LOZCUOxFsZu2lsaj+SRS8C8dKWyk39kxIHhu06Y8nyK7PeE/QQS6AKsVZn80e6Fv3lTcD6JA6T4ZxD/Zj3Bb+idV2cvM4HA4qcIg9VxDbK4p4UVFRbhugfjiteHOtWqZyhgvU/sXN5ueQoMeGi5O48y5C+z5F7tpOwjOzZXkDOFxM/kYD9AX+5Mm82VtqCVlPRkEiNw23u85JnPy68f58c9x6zoe+qWyfLb2G2vykQZJ/8TtJDm0NzuHvMJheTpkzDYYMtKVSXxOJXYmu4ZMYBTJeQd/46q1P+TEI1NNvhslrmzrScczQCMx4RH+010g/nk5ANaV1jJHRDzDZkhjqa7rC83yfyqE3CV/FFN/8J+8q5OkNZEtdo3Q9wI12AG5gGBxN8UDtpWfW9cbfyQY2rb2D2hpezDTKwoXbAur225aWGqYQaQdYJzlIiD/VaJewBWCSBninODezsZtgyqomsq3znEQP7M0nT6oMNA3zz7MRF9UjuOJlG3QgQI5HQ0tncmQH8Tk/28L3JW9PAUkA1xpKKc+J2gP88lHVAf+h6FeGFbRIqfTs66n0uSL2vb5FPL2jxpFgT2EE9c+Le1b75NgFZHfNZoMExs5B4uxtB4UJSpAkxFPodasHGKUWSVcBrre5hGmB6E+rYjg1hRfqffmMx3GdXEShb1TExWc2G8gBlbEUpqeBRdRcbef/c+4LXRTbxe2qsfRT7A9Tbi X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(8936002)(54906003)(2616005)(53546011)(4326008)(36860700001)(7636003)(40460700003)(508600001)(31686004)(26005)(186003)(31696002)(426003)(110136005)(44832011)(8676002)(82310400005)(83380400001)(47076005)(5660300002)(356005)(70206006)(2906002)(36756003)(70586007)(966005)(316002)(9786002)(336012)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 13:10:48.5779 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69214b32-4177-4c04-6641-08da49504e60 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT023.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB2729 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/8/2022 1:54 PM, Ferruh Yigit wrote: > On 6/8/2022 1:11 PM, Andrew Rybchenko wrote: > >> >> From: Ke Zhang >> >> The warning info: >> warning: passing argument 1 of ‘memcpy’ discards ‘const’ >> qualifier from pointer target type >> >> Variable dev_addr is done const intentionally in v5.17 to prevent using >> it directly. See kernel series [1] for more information. `dev_addr` is done const in v5.17, but patch checks >= v5.15 because used helpers introduced in v5.15, should this be clarified to not confuse users? No strong opinion from me. >> >> [1] https://lore.kernel.org/netdev/YZYAb4X%2FVQFy0iks@shredder/T/ > > Can you add Linux kernel commit log, instead of the mail list archive? > This helps to check the relevant code change in kernel easier, and > verify in which versions it exists etc.. > I think mentioned commit is following Commit adeef3e32146 ("net: constify netdev->dev_addr") >> >> Fixes: ea6b39b5b847 ("kni: remove ethtool support") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ke Zhang >> Signed-off-by: Andrew Rybchenko > > Acked-by: Ferruh Yigit >