From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33ECF45B57; Thu, 17 Oct 2024 07:38:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90ADB4021F; Thu, 17 Oct 2024 07:38:05 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id C4E7040144 for ; Thu, 17 Oct 2024 07:38:03 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 3CD301BA7A for ; Thu, 17 Oct 2024 07:38:03 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 30F411BBAA; Thu, 17 Oct 2024 07:38:03 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.2 Received: from [192.168.1.85] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 1338E1BA78; Thu, 17 Oct 2024 07:38:00 +0200 (CEST) Message-ID: <8f98f3e9-8a52-4b3f-9df4-048d9e4b0c6d@lysator.liu.se> Date: Thu, 17 Oct 2024 07:38:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 1/7] eal: add static per-lcore memory allocation facility To: Stephen Hemminger , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Konstantin Ananyev , David Marchand , Jerin Jacob , Luka Jankovic , Konstantin Ananyev , Chengwen Feng References: <20241015093344.824073-2-mattias.ronnblom@ericsson.com> <20241016131916.827788-1-mattias.ronnblom@ericsson.com> <20241016131916.827788-2-mattias.ronnblom@ericsson.com> <20241016075341.587e8a95@hermes.local> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20241016075341.587e8a95@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-10-16 16:53, Stephen Hemminger wrote: > On Wed, 16 Oct 2024 15:19:10 +0200 > Mattias Rönnblom wrote: > >> + >> +/** >> + * Allocate space in the per-lcore id buffers for an lcore variable. >> + * >> + * The pointer returned is only an opaque identifier of the variable. To >> + * get an actual pointer to a particular instance of the variable use >> + * @ref RTE_LCORE_VAR or @ref RTE_LCORE_VAR_LCORE. >> + * >> + * The lcore variable values' memory is set to zero. >> + * >> + * The allocation is always successful, barring a fatal exhaustion of >> + * the per-lcore id buffer space. >> + * >> + * rte_lcore_var_alloc() is not multi-thread safe. >> + * >> + * The allocated memory cannot be freed. >> + * >> + * @param size >> + * The size (in bytes) of the variable's per-lcore id value. Must be > 0. >> + * @param align >> + * If 0, the values will be suitably aligned for any kind of type >> + * (i.e., alignof(max_align_t)). Otherwise, the values will be aligned >> + * on a multiple of *align*, which must be a power of 2 and equal or >> + * less than @c RTE_CACHE_LINE_SIZE. >> + * @return >> + * The variable's handle, stored in a void pointer value. The value >> + * is always non-NULL. >> + */ >> +__rte_experimental >> +void * >> +rte_lcore_var_alloc(size_t size, size_t align) >> + __rte_alloc_size(2); > > This is not right, the index is which arg holds the size etc. > should be: > __rte_alloc_size(1) __rte_alloc_align(2) __rte_malloc; Oops. Will fix in v15. Thanks.