From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21F1842805; Wed, 22 Mar 2023 17:50:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02D6040E09; Wed, 22 Mar 2023 17:50:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4202240A84 for ; Wed, 22 Mar 2023 17:50:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679503828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cTtUcU/oyPoREc33up3RaHY8amUEBRLqfU9geOWX2FQ=; b=KOmZPkngYywip91PzbRYau2IN7tyVtc5BlHnLN05/LJi94l75OlAKQ5sRzILfk12Roi2NK DFp8+mKp68HaOFiEwrfe9I5SoqFaijqSCMnSwWW7sGjwZHM0a7LNdZ3hfEC3Gs1xS3C7Bc lcqP42vGphZOfT8xzPY5N5IIlPcrihk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-TdwdQ3X8MXWaRDOqXghVUA-1; Wed, 22 Mar 2023 12:50:27 -0400 X-MC-Unique: TdwdQ3X8MXWaRDOqXghVUA-1 Received: by mail-wr1-f70.google.com with SMTP id c3-20020adfa303000000b002d5737d3835so1241039wrb.21 for ; Wed, 22 Mar 2023 09:50:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679503824; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cTtUcU/oyPoREc33up3RaHY8amUEBRLqfU9geOWX2FQ=; b=Xhk/6lE1X87fQddsRC+q9S8UtfOMM2olHpl50a8pUEh4lIqb2TbsYRWZHc49qh9uGT kGbVvvnKg70FHQfrle6ijUEhr8NQuzahYc8czqdkqwcWWaQtwvqLq7bJn4HuCSUrqN9Z 116m8OuMGeuSq+5G3J60UrBnWKAed48gwdKM/j46q1c7/hPfi4yeV+dMB+fq7AYlRDSC 1qVBMow3rEGnAZIgCODkrKEZKnp7c7d7MreBOG/KLIoUzCIM92vLgTo9tTg/ok21eudO 7quaKnvAjpX5GCwVyMVPA5Gn8+x9J/IAkWZwZa9xlOeyTE78tgGk2pbrtCl549sIghRF C/xA== X-Gm-Message-State: AO0yUKXQnSKC9C7jsDLgFhwJmSisb0LelLY+dsyUFMh9MaUUC3MKXBEQ ylxcV8TdeL1kwm8IzjYLU69CCRs7KjVxCHQNZpu+hNmKAuzKC9jafsD8viWLpbuZAfFlL1gLvkD xy6E= X-Received: by 2002:a05:600c:2256:b0:3ed:8079:27d7 with SMTP id a22-20020a05600c225600b003ed807927d7mr99117wmm.40.1679503823896; Wed, 22 Mar 2023 09:50:23 -0700 (PDT) X-Google-Smtp-Source: AK7set8111mVCjeAvsxlLK7+6Urwq4hV6kXfpJLXAJijGPcRVzpws58De7vh+gUD1HIMBt1IdNwPHQ== X-Received: by 2002:a05:600c:2256:b0:3ed:8079:27d7 with SMTP id a22-20020a05600c225600b003ed807927d7mr99105wmm.40.1679503823605; Wed, 22 Mar 2023 09:50:23 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id o31-20020a05600c511f00b003edd2ec9f85sm12551902wms.6.2023.03.22.09.50.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 09:50:23 -0700 (PDT) Message-ID: <8fecda8e-15b4-63e0-f319-6e4a4a5edf83@redhat.com> Date: Wed, 22 Mar 2023 16:50:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: "Zhang, Qi Z" , "Su, Simei" , "Xing, Beilei" , "Zhang, Yuying" , "david.marchand@redhat.com" , "Jiang, YuX" Cc: "dev@dpdk.org" , "Yang, Qiming" , "stable@dpdk.org" , Luca Boccassi References: <20230202123632.56730-1-simei.su@intel.com> <20230220075952.444153-1-simei.su@intel.com> From: Kevin Traynor Subject: Re: [PATCH v6] net/i40e: rework maximum frame size configuration In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 27/02/2023 00:35, Zhang, Qi Z wrote: > Hi Simei/Qi/Yu > >> -----Original Message----- >> From: Su, Simei >> Sent: Monday, February 20, 2023 4:00 PM >> To: Xing, Beilei ; Zhang, Yuying >> ; Zhang, Qi Z ; >> david.marchand@redhat.com >> Cc: dev@dpdk.org; Yang, Qiming ; Su, Simei >> ; stable@dpdk.org >> Subject: [PATCH v6] net/i40e: rework maximum frame size configuration >> >> One issue is reported by David Marchand that error occurs in OVS due to the >> fix patch in mentioned changes below. The detailed reproduce step and >> result are in https://patchwork.dpdk.org/project/dpdk/patch/ >> 20211207085946.121032-1-dapengx.yu@intel.com/. >> >> This patch removes unnecessary link status check and directly sets mac config >> in dev_start. Also, it sets the parameter "wait to complete" true to wait for >> more time to make sure adminq command execute completed. >> >> Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level") >> Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port level") >> Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") >> Cc: stable@dpdk.org These patches caused an observable regression in multiple 20.11 and 21.11 LTS releases that was only caught a long time after releases. Is there anything being added to LTS validation for regression testing this issue, so we don't get caught again? After reverting the original patch and 2 fixes, I'm a bit reluctant to take more fixes without some form of regression testing in place. thanks, Kevin. >> >> Reported-by: David Marchand >> Signed-off-by: Simei Su > > Acked-by: Qi Zhang > > Applied to dpdk-next-net-intel. > > Thanks > Qi >