From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (unknown [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2FB9460AB; Fri, 17 Jan 2025 04:29:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A5C641140; Fri, 17 Jan 2025 04:29:25 +0100 (CET) Received: from lf-1-16.ptr.blmpb.com (lf-1-16.ptr.blmpb.com [103.149.242.16]) by mails.dpdk.org (Postfix) with ESMTP id 66DAE4113D for ; Fri, 17 Jan 2025 04:29:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2403070942; d=yunsilicon.com; t=1737084556; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=sV49iXvnMBpoes2jV4FC2C3hmh5tChttts3qDBwV07o=; b=MlmYOQRZ9KqDWiXP61mNxOCX390DeaKhzUxNZ0ghb2b7OmrzFHqD/0/ELmaMhDCNkKkWQn C4FHgRFxZqLwXZh2JPXiZACI9mr4Eh9J6fpgmrWZIyPSE/D5UPPU0gdQf8u3PhZNjwunxH OTF43FlrvQ8fQVdXDc5Jx6kY7pLjKDSOO4tDpd7azWpnowHnYAmmDGRMnMTkD11MjFJoDt PO+F9X7u0nzGCH3FYS7Z2bWBobqBFlsKhGYHNDKCHYINdxJxvSSbZ9nWHCnL4zPot6x2MU dM8kWu0Fz/TbB1yS34o/8lLsN/dMpXnilG6yCOrfG3GKD6MJYNjVsNVzHAd1+w== Subject: Re: [PATCH v5 01/15] net/xsc: add xsc PMD framework Date: Fri, 17 Jan 2025 11:29:11 +0800 Mime-Version: 1.0 In-Reply-To: <20250116101812.676ad693@hermes.local> Content-Type: text/plain; charset=UTF-8 To: "Stephen Hemminger" Cc: , , , , , , , , Content-Transfer-Encoding: 7bit Received: from [127.0.0.1] ([218.1.137.133]) by smtp.feishu.cn with ESMTPS; Fri, 17 Jan 2025 11:29:13 +0800 From: "WanRenyong" Message-Id: <8ff1a3c1-f502-4dee-9250-9dfbfd488983@yunsilicon.com> X-Lms-Return-Path: X-Original-From: WanRenyong User-Agent: Mozilla Thunderbird References: <20250107024939.1962467-1-wanry@yunsilicon.com> <20250107024939.1962467-2-wanry@yunsilicon.com> <20250116101812.676ad693@hermes.local> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2025/1/17 2:18, Stephen Hemminger wrote: > On Tue, 07 Jan 2025 10:49:40 +0800 > "WanRenyong" wrote: > >> diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c >> new file mode 100644 >> index 0000000000..a7dca46127 >> --- /dev/null >> +++ b/drivers/net/xsc/xsc_ethdev.c >> @@ -0,0 +1,89 @@ >> +/* SPDX-License-Identifier: BSD-3-Clause >> + * Copyright 2025 Yunsilicon Technology Co., Ltd. >> + */ >> + >> +#include > Why are you including this file (it relates to Linux networking not DPDK)? > If I remove it build works fine. > Thank you for your review. This is codeleftoverfrom early patches that had dependencies on kernel drivers. I will remove it next time. By the way, is there any new incoming review feedback about this patch series? If not, I will address current review comments and resubmit the new revised version of the patches. -- Thanks, WanRenyong