From: Nick Connolly <nick.connolly@mayadata.io>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: William Tu <u9012063@gmail.com>,
dev@dpdk.org, sergey.madaminov@gmail.com
Subject: Re: [dpdk-dev] [PATCH] eal/windows: add sys/queue.h.
Date: Wed, 11 Aug 2021 09:34:05 +0100 [thread overview]
Message-ID: <8ffc3108-49e5-4763-ec46-029b6e39c5cd@mayadata.io> (raw)
In-Reply-To: <20210811013325.34c36220@sovereign>
> What we can do:
>
> 1. Introduce `rte_queue.h` (name can be better) that is env-specific:
>
> 1.1. For Linux and FreeBSD it just includes <sys/queue.h>
> and renames a few macros that are used in headers to RTE_xxx.
> 1.2. For Windows it defines the same RTE_xxx macros in a way
> compatible with the <sys/queue.h> version used to build DPDK.
>
> 2. Add #include <sys/queue.h> in <rte_os_shim.h>:
> Linux and FreeBSD will include a system header,
> Windows will use the bundled one.
>
> This way application are not exposed to non-RTE symbols,
> at the same time RTE_xxx are binary-compatible with what DPDK
> implementation expects (and outside of Windows there is no change in fact).
+1
Nick
next prev parent reply other threads:[~2021-08-11 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 17:33 William Tu
2021-08-10 21:05 ` Nick Connolly
2021-08-10 22:33 ` Dmitry Kozlyuk
2021-08-11 8:34 ` Nick Connolly [this message]
2021-08-11 15:18 ` William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ffc3108-49e5-4763-ec46-029b6e39c5cd@mayadata.io \
--to=nick.connolly@mayadata.io \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=sergey.madaminov@gmail.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).