From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9F90A034F; Wed, 11 Aug 2021 10:34:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E69B40042; Wed, 11 Aug 2021 10:34:09 +0200 (CEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id A9E6C40040 for ; Wed, 11 Aug 2021 10:34:08 +0200 (CEST) Received: by mail-wr1-f46.google.com with SMTP id q11so1879415wrr.9 for ; Wed, 11 Aug 2021 01:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=YRx5LviCZUBbvIc5xHQSQjj0sJAxTdJlllMrzf7CGsA=; b=LBpwGuzNavpEawYOYoUFEmm4wLmuyMl7qosMYgN4JTNE05QyTVGZnnLEH6S+znWkGT ktAmA8UxhMgQUEGpfy+rXp/3Ng9yQVSAyfJzWqU3aFKvZiDAtDfloCmrmuxLLKK8Wfj9 T8MpQPucVGYt0bRzoYr/0h4h4wUkrlbiEvUe1vA6cuMRdlrUnHMQD7OAbS8u9iSKEWz8 nZd4vBb5u9z0843qLo0Qj7ViMfIkHBIheBCHIwXzor8GpcYKoVomVVLUBRwhRqrJrl8Z M6AWd2YNdImhCr4z1sPuUpI6lqLFCbbZs7A6wfH1SUcSMBlo93P+BIbPLLchXO2lGu8S qMDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=YRx5LviCZUBbvIc5xHQSQjj0sJAxTdJlllMrzf7CGsA=; b=R7EDFSrt6CpOoOPlAzYmvUxovsQpReKJjDN+IsOSjrjRfKlRctknbCHbOSAQplRC25 7s48c1QT+2UD17Y/w0lDOIZyVyk4fM1tTXW5YJtxT+DnKNo07NdwK2UsbOUHqEqvZzvi y3wQaqmeZzWBvycvT3Q/aQC1d4ot2HmAhqGSwa6xsIUIfT3dvH3oqPv61VWD6jnREyqL EaNQSqLNU0pnIuRFDuq8/0RhQTyPkzWa+oSuOrJJWTvOyfYK24A5d5Jaay4lu6aMIfzK esm9bWKX7rEzDpsJKwcfG4O3W/6G6Ncd+pJG7pJG04x9rUXoo/qJe5AmfXNqJZaoeOks 4npA== X-Gm-Message-State: AOAM530DB9ik1uX5m5OOO9/N2qXW2n69t1wrmKv4qqOcw5bFBpk/PMcp NvXlS4K3BAYNEfrs4hHPKXcAGg== X-Google-Smtp-Source: ABdhPJyUCIMBPGlRHe3BeHUKd1919JqPsknZpygRF/Spvus97MUP8DL/eTddtNpZkbOy/hQFhIWf+A== X-Received: by 2002:adf:dd05:: with SMTP id a5mr35143026wrm.214.1628670848378; Wed, 11 Aug 2021 01:34:08 -0700 (PDT) Received: from [192.168.0.57] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id u15sm16190879wmq.33.2021.08.11.01.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Aug 2021 01:34:08 -0700 (PDT) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Dmitry Kozlyuk Cc: William Tu , dev@dpdk.org, sergey.madaminov@gmail.com References: <20210805173345.1085-1-u9012063@gmail.com> <20210811013325.34c36220@sovereign> Message-ID: <8ffc3108-49e5-4763-ec46-029b6e39c5cd@mayadata.io> Date: Wed, 11 Aug 2021 09:34:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210811013325.34c36220@sovereign> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] eal/windows: add sys/queue.h. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > What we can do: > > 1. Introduce `rte_queue.h` (name can be better) that is env-specific: > > 1.1. For Linux and FreeBSD it just includes > and renames a few macros that are used in headers to RTE_xxx. > 1.2. For Windows it defines the same RTE_xxx macros in a way > compatible with the version used to build DPDK. > > 2. Add #include in : > Linux and FreeBSD will include a system header, > Windows will use the bundled one. > > This way application are not exposed to non-RTE symbols, > at the same time RTE_xxx are binary-compatible with what DPDK > implementation expects (and outside of Windows there is no change in fact). +1 Nick