From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BDED45D39; Mon, 18 Nov 2024 18:16:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 375FE40698; Mon, 18 Nov 2024 18:16:56 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 0190240290 for ; Mon, 18 Nov 2024 18:16:55 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53223165C; Mon, 18 Nov 2024 09:17:24 -0800 (PST) Received: from [192.168.50.107] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35F863F6A8; Mon, 18 Nov 2024 09:16:53 -0800 (PST) Message-ID: <8ffc537d-b8f9-4857-822f-6e0b6c24ef50@arm.com> Date: Mon, 18 Nov 2024 17:16:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] dts: Rework DPDK Attributes In SUT Node Config Content-Language: en-GB To: Nicholas Pratte , probb@iol.unh.edu, dmarx@iol.unh.edu, jspewock@iol.unh.edu, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech Cc: dev@dpdk.org References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240705171341.23894-10-npratte@iol.unh.edu> From: Luca Vizzarro In-Reply-To: <20240705171341.23894-10-npratte@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Good one. My only comment – aside the usual ones – on top of Juraj's is could try to make the commit subject more concise. For example: dts: isolate config of dpdk arguments