DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Usama Arif <usama.arif@bytedance.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, fam.zheng@bytedance.com,
	liangma@bytedance.com, stable@dpdk.org
Subject: Re: [PATCH] build: encapsulate grep for local_miss_maps in a function
Date: Tue, 08 Mar 2022 22:05:45 +0100	[thread overview]
Message-ID: <9001533.aoefvbuG5b@thomas> (raw)
In-Reply-To: <20220308185243.3629626-1-usama.arif@bytedance.com>

08/03/2022 19:52, Usama Arif:
> check-symbols-maps.sh runs with the -e option to exit as soon as
> there is an error. Currently the build is failing as the search of
> grep -L is empty (which is the case for all version.map files as
> they have the local symbol) which causes the script to return
> with an error.

It depends on the shell I guess because most machines run well.

> This patch encapsulates the grep call in a function, so that only the function
> errors out and the build is successful.

That's a strange workaround. I don't understand why it works.
I am submitting a simpler fix adding " || true"

> -local_miss_maps=$(grep -L 'local: \*;' $@)
> +find_local_miss_maps ()
> +{
> +    local local_miss_maps=$(grep -L 'local: \*;' $@)
> +    echo "$local_miss_maps"
> +
> +}
> +
> +local_miss_maps=$(find_local_miss_maps $@)

Thanks for raising the issue and proposing a solution.



      reply	other threads:[~2022-03-08 21:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 18:52 Usama Arif
2022-03-08 21:05 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9001533.aoefvbuG5b@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fam.zheng@bytedance.com \
    --cc=liangma@bytedance.com \
    --cc=stable@dpdk.org \
    --cc=usama.arif@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).