From: Thomas Monjalon <thomas@monjalon.net>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: dev@dpdk.org, nhorman@tuxdriver.com,
pbhagavatula@caviumnetworks.com, aconole@redhat.com
Subject: Re: [dpdk-dev] [PATCH 1/1] doc: announce API change to lcore role function
Date: Wed, 14 Feb 2018 11:59:12 +0100 [thread overview]
Message-ID: <9001700.V5d3VI6AvN@xps> (raw)
In-Reply-To: <5006829.4uDuJ5LzRD@xps>
14/02/2018 01:09, Thomas Monjalon:
> 12/01/2018 21:45, Erik Gabriel Carrillo:
> > This an API/ABI change notice for DPDK 18.05 announcing a change in
> > the meaning of the return values of the rte_lcore_has_role() function.
> >
> > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> > ---
> > +* eal: The semantics of the return value for the ``rte_lcore_has_role`` function
> > + are planned to change in v18.05. The function currently returns 0 and <0 for
> > + success and failure, respectively. This will change to 1 and 0 for true and
> > + false, respectively, to make use of the function more intuitive.
>
> It will introduce some subtle bugs in applications.
> We must clearly advertise this API change in the release notes.
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied
prev parent reply other threads:[~2018-02-14 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 20:45 Erik Gabriel Carrillo
2018-02-13 14:37 ` Ferruh Yigit
2018-02-13 14:43 ` Van Haaren, Harry
2018-02-13 14:47 ` Pavan Nikhilesh
2018-02-14 0:09 ` Thomas Monjalon
2018-02-14 10:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9001700.V5d3VI6AvN@xps \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).