From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7BC651B3B3 for ; Thu, 11 Oct 2018 14:10:22 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 057BE211E5; Thu, 11 Oct 2018 08:10:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 11 Oct 2018 08:10:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=mb5VNVOLLqjYrUsfPj6lKX1XDLUdhHTgzWWS9LSzoXo=; b=rHrMq/xAKn5q ObXuv5u/mCwE3EdiTo/TlkN2LsPbmixESPnO/9PP+Vm8m5qazetXvy7r+h/UpF7e FSKsTt5jMsVIAbf7O16Zk0wKh6ORDTLDiP9dn90VR9pEKw/aUXCe+YMCeDCXQVra gz8OHWTpyghIyD9KtKilCI0mOxz70kI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=mb5VNVOLLqjYrUsfPj6lKX1XDLUdhHTgzWWS9LSzo Xo=; b=Uw8L8KOb6HyokFZpRyZZcrFhW12xPMurC+ue1FQ1HYWj3rB+asFTuOZwH Ihbik2JBdbM5KWe630/lItag7D0ggIvXrOz+JwVSHmW9U8TVnMTrEAaB1x8yE8w4 Yp5GUSHzjjSefvgbYUjarn4GhDTxDSKlhX8Xc7+PBQpbDW2oUDAZ7yBPqsr8KceE VPrAQDPyVQBkQ3v6uSYCxp9lA0FIbG1VRWRWqwH1qgzGX5DKbP/fh+rrMdFE406M EmscOMew6+BXxnM+gLQkikW3oqW/+MunzpBOgFrQMPUyYHHDzCJxbdDoOg82I+n1 5hoy6alvYAAqVtSCWr/iHIS/J2xQQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 97E94102DD; Thu, 11 Oct 2018 08:10:19 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Stephen Hemminger , gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com, ktraynor@redhat.com Date: Thu, 11 Oct 2018 14:10:18 +0200 Message-ID: <9014753.JheKqXxJ3f@xps> In-Reply-To: <20181008144509.3c3a5933@xeon-e3> References: <20180907222727.20521-1-thomas@monjalon.net> <20181007093244.20659-1-thomas@monjalon.net> <20181008144509.3c3a5933@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 0/5] eal: simplify devargs and hotplug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 12:10:22 -0000 08/10/2018 23:45, Stephen Hemminger: > On Sun, 7 Oct 2018 11:32:39 +0200 > Thomas Monjalon wrote: > > > This is a follow-up of an idea presented at Dublin > > during the "hotplug talk". > > > > Instead of changing the existing hotplug functions, as in the RFC, > > some new experimental functions are added. > > The old functions lose their experimental status in order to provide > > a non-experimental replacement for deprecated attach/detach functions. > > > > It has been discussed briefly in the latest technical board meeting. > > > > > > Changes in v6 - after Gaetan's review: > > - bump ABI version of all buses (because of rte_device change) > > - unroll snprintf loop in rte_eal_hotplug_add > > > > Changes in v5: > > - rte_devargs_remove is fixed in case of null devargs (patch 2) > > - a pointer to the bus is added in rte_device (patch 3) > > - rte_dev_remove is fixed in case of no devargs (patch 5) > > > > Changes in v4 - after Andrew's review: > > - add API changes in release notes (patches 1 & 2) > > - fix memory leak in rte_eal_hotplug_add (patch 4) > > > > Change in v3: > > - fix null dereferencing in error path (patch 2) > > > > > > Thomas Monjalon (5): > > devargs: remove deprecated functions > > devargs: simplify parameters of removal function > > eal: add bus pointer in device structure > > eal: remove experimental flag of hotplug functions > > eal: simplify parameters of hotplug functions > > I like these changes. > > Reviewed-by: Stephen Hemminger Applied