From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 83E041B3FB for ; Thu, 20 Dec 2018 11:10:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2A0F322013; Thu, 20 Dec 2018 05:10:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 05:10:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vRrxTL2pubzxCJqxe8zKGInoevwf874YUBuQvOwyC7E=; b=jkngXEx2jGO6 Wwy8ReQvXrUHtBXsd6ru3AJzwQ+Zp3FXCJ8t65fjMmVuxw6h0hQsQmvBiCSiEV3u VZpbQ08ZY91eaQJYIiiU9VSJWKkFa8RTFrTfZqpRj9pYi/4d07m5CxwRQK/Vfyci 4uJyn6LhdZEG4da5fOXtwU+HGBqTecg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vRrxTL2pubzxCJqxe8zKGInoevwf874YUBuQvOwyC 7E=; b=BwH0YN3hO2XX7EIdlOjhpGCCDXHLAgNc2NXsnvaAjxupnjSrB+HNkr5Co qQcOeKcAZQWIdXJTIjR3SD5UzQLK9eucqk2Wt79oj1rj3zxguRjthJcI6ZC77iLo ylUugkvjktF1fOs2dNKhKnmgUk+Ha68QMaXJ8EWOV7Wp7C4kvyoBR2pkCyQeQlXw qIfcjQpX75ZenCEF3HfWT4qE0PZTU4hjUQAEjNP1s/Oc486ieIpRtyf/KtHQJqOr WSqtnsJ/WO0xXGxngxFSB29gPeq7rTY45TpPk98wNNJaqBS3KcT5nPRnfj9AH0py UNhyoAgaXwbEGnxyN1F6FczANPH2A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejfedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9E5C3E4445; Thu, 20 Dec 2018 05:10:26 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" , bluca@debian.org Cc: "Hunt, David" , Liang Ma , dev@dpdk.org, qian.q.xu@intel.com, ferruh.yigit@intel.com Date: Thu, 20 Dec 2018 11:10:23 +0100 Message-ID: <9037763.qK0Rf51nFT@xps> In-Reply-To: References: <1544786028-10138-1-git-send-email-liang.j.ma@intel.com> <636b6d77-c9d1-8ae7-7999-11e03bf645c8@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 10:10:28 -0000 20/12/2018 10:33, Burakov, Anatoly: > On 20-Dec-18 9:25 AM, Burakov, Anatoly wrote: > > On 19-Dec-18 8:31 PM, Thomas Monjalon wrote: > >> 19/12/2018 10:09, Hunt, David: > >>> On 19/12/2018 3:18 AM, Thomas Monjalon wrote: > >>>> 14/12/2018 14:11, Liang Ma: > >>>>> Previously, in order to use the power library, it was necessary > >>>>> for the user to disable the intel_pstate driver by adding > >>>>> =E2=80=9Cintel_pstate=3Ddisable=E2=80=9D to the kernel command line= for the system, > >>>>> which causes the acpi_cpufreq driver to be loaded in its place. > >>>>> > >>>>> This patch adds the ability for the power library use the intel-pst= ate > >>>>> driver. > >>>>> > >>>>> It adds a new suite of functions behind the current power library A= PI, > >>>>> and will seamlessly set up the user facing API function pointers to > >>>>> the relevant functions depending on whether the system is running w= ith > >>>>> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a gues= t, > >>>>> using kvm. The library API and ABI is unchanged. > >>>>> > >>>>> Signed-off-by: Liang Ma > >>>>> > >>>>> Reviewed-by: Anatoly Burakov > >>>>> --- > >>>> Please write a changelog when sending a new version. > >>>> > >>>> Dave, any comment on this patch? > >>> > >>> > >>> Looks good to me. > >>> > >>> Acked-by: David Hunt > >>> > >>> > >>>>> --- /dev/null > >>>>> +++ b/lib/librte_power/power_pstate_cpufreq.c > >>>>> @@ -0,0 +1,770 @@ > >>>>> +/* SPDX-License-Identifier: BSD-3-Clause > >>>>> + * Copyright(c) 2018-2018 Intel Corporation > >>>> Something wrong here :) > >>> > >>> Yes, should simply be "Copyright(c) 2018 Intel Corporation" > >> > >> > >> There is also a compilation error with meson: > >> > >> lib/librte_power/rte_power_empty_poll.h:20:10: fatal error: > >> rte_timer.h: No such file or directory > >=20 > > That's an EAL header, and this file was not modified or referenced in=20 > > this commit. This sounds like a pre-existing problem (with meson=20 > > build-system?), not related to the patchset. > >=20 > > Is this library not built by default by our patch compilation CI? > >=20 >=20 > Disregard that, the patch has a bug in meson build file. >=20 > Still, why doesn't our CI build meson? I think we should build a new CI for compilation testing. Luca proposed to use OBS. Luca, can we work on it?