From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D6BFA0C50; Sat, 24 Jul 2021 10:10:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25FC540DDE; Sat, 24 Jul 2021 10:10:41 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 17D8D40DDA; Sat, 24 Jul 2021 10:10:40 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 74E275C00D3; Sat, 24 Jul 2021 04:10:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 24 Jul 2021 04:10:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= H8fr+CpU0Bfsb7t2bNO/u8pc1bnpuGRfquVrGelEhfg=; b=OwSUcLpj/aizfUvm dY105uCb2UdEFq7rbh7bLJo12SED8s7K2te+R6YcPqGXVaKlAHbYsvTwvFlC97za cgtcWtLWnhoY7I3yowHNBsWu/6Zpp2rG30a72CncVh1ANQ148/zrT7ZMThVZLjd8 7Hls2j1jCUcPZOzdiXmt/I1zqq41ENp6fAmcrngsBUEttLKh96pxg2jU7sqG4YMc NsQ+EwiIBLNXv+jo/rvhSbVwdp5yA8jJXQ9gU7ZBbxvSJp1W4WKA3cWwNawc10LN veVmjleivH/a0BVT8oxbYqCBA7qB4AzJNuP7QGia7pbb+d18P92Imvi4Pf4EShT3 OapuSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=H8fr+CpU0Bfsb7t2bNO/u8pc1bnpuGRfquVrGelEh fg=; b=unUp3iTyF6GQD5dmD9ceqVfcN8tumnUMEGmBaqAFPSu3eJAAIscYAr1qQ LKGS2B2YuzfYAlVcK+ZAnYNR5kVZrEARWIPctNV2YUwsY4j7jbbmiJwfuclawChh AIrcCK2lhyLihpyASVOp9gS8fP0YkA7qycuJmScYs0k9Cr2y1IfS2DvcPzt5McuP 5FA4De7Ix/VO1SbWukWrVzxtb7+vSdnu1Rhvf451Uv4rHZfUlHMnm5uBC8oO15Xa tnIRO5QtpbI8EZA2RtZ6muM4tuZ2TIY5N+GGLs+poQUMSXwDqkyP/fBA7XlWpPQh N9/pSEYMpX1WXem+CJMs0108W3KSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrgedtucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrth htvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeuieeivdff geehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepth hhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Jul 2021 04:10:37 -0400 (EDT) From: Thomas Monjalon To: Richael Zhuang Cc: dev@dpdk.org, stable@dpdk.org, David Hunt , david.marchand@redhat.com Date: Sat, 24 Jul 2021 10:11:01 +0200 Message-ID: <90397231.fzX3LJKVxB@thomas> In-Reply-To: References: <20210723021313.7085-2-richael.zhuang@arm.com> <20210723022242.8092-2-richael.zhuang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/1] power: check freq count before filling the freqs array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2021 10:37, David Hunt: > Hi Richael, > > On 23/7/2021 3:22 AM, Richael Zhuang wrote: > > The freqs array size is RTE_MAX_LCORE_FREQS. Before filling the > > array with num_freqs elements, restrict the total num to > > RTE_MAX_LCORE_FREQS. This fix aims to fix the coverity scan issue > > like: > > Overrunning array "pi->freqs" of 256 bytes by passing it to a > > function which accesses it at byte offset 464. > > > > Coverity issue: 371913 > > Fixes: ef1cc88f1837 ("power: support cppc_cpufreq driver") > > Cc: richael.zhuang@arm.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Richael Zhuang > > LGTM to fix the coverity issue. > > Acked-by: David Hunt Removed the space before ":" and applied, thanks.