From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B21B32BF7
 for <dev@dpdk.org>; Wed, 11 Oct 2017 15:38:37 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 55F4A2182A;
 Wed, 11 Oct 2017 09:38:37 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Wed, 11 Oct 2017 09:38:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=wYhmMhk4tVJas3qwonVjOpCUxX
 qHMA59rWhVHT08Jh0=; b=OkWbW5IFX2WwQtw9aJ0e93DVN0c8ysJlUR30G3z3Li
 oWFQO4/u03BMbDwedG4fBzIuG9JU0SD2aRo0u1lvOUkY+OmxakYOWxL1prIomXt/
 fHzHKbA3ZuR74xyMHD20NzsJHgNkjOEjMO9ZSQlyLpfaqvmz7QXAeWUgwLcnZtRr
 k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wYhmMh
 k4tVJas3qwonVjOpCUxXqHMA59rWhVHT08Jh0=; b=SJKF8L3DhTQnH9qFcqU3R2
 hORhYe3F4Wx1LmUec8hZrbQXU7Q22B5Zw69J8yKzVuDOi4Aqg6gI3y4ZCJDznmtq
 FpVxbprfHTTxyfJuPAWcX8l7AGEx+1H2JZWfdQcWb28DonikPQ0xccPZm6ZCfox5
 B4bo46E4d7H3lfDbIAfRRM2Azp5f2BJ+ZT4Qd1PZ2yjKZemw9gK1x94kz9Q3Bgaf
 MWTjqNYFwDS6DyfALUyX3akuFf4eFlomf/1hw8WPGDKmIi5rvWattCEIToDVw0JD
 uWc1R6A3iHUDVk2NFcqipJxvO4WBLy+o0UmTmnEkbCtpHGSDW0cLvLNoB23v8pRg
 ==
X-ME-Sender: <xms:3R7eWX0Gf6Y--5rxme73qYBB96-TfvBHUGo_fO4CxwDblTVWwf9Jog>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id EBEBB24735;
 Wed, 11 Oct 2017 09:38:36 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Tomasz Duszynski <tdu@semihalf.com>
Cc: dev@dpdk.org, mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com,
 Jianbo.liu@linaro.org, Jacek Siuda <jck@semihalf.com>
Date: Wed, 11 Oct 2017 15:38:36 +0200
Message-ID: <9041127.34t6OW5FrT@xps>
In-Reply-To: <1507561244-20115-3-git-send-email-tdu@semihalf.com>
References: <1507031500-11473-1-git-send-email-tdu@semihalf.com>
 <1507561244-20115-1-git-send-email-tdu@semihalf.com>
 <1507561244-20115-3-git-send-email-tdu@semihalf.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver
	skeleton
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Oct 2017 13:38:37 -0000

Hi,

09/10/2017 17:00, Tomasz Duszynski:
>  #
> +# Compile Marvell PMD driver
> +#
> +CONFIG_RTE_LIBRTE_MRVL_PMD=n
> +CONFIG_RTE_LIBRTE_MRVL_DEBUG=n
> +CONFIG_RTE_MRVL_MUSDK_DMA_MEMSIZE=41943040

We are trying to remove build-time configurations and behave like
a true library.

The DEBUG config options are now prohibited.
Where is it used in your code?
If it is used for logs, you should switch to the dynamic log config.

What is MUSDK_DMA_MEMSIZE?
If the value cannot change, it must be a constant in the code.
If it can change, it should be a run-time driver option.

Thank you and welcome!