From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 0F6BC9AA6 for ; Tue, 7 Jun 2016 14:53:38 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id v199so18124382wmv.0 for ; Tue, 07 Jun 2016 05:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=yC9fzSeBnu/Rjb4F7zW0lA+EjBp/rWP8jDmFwNrgebU=; b=ptqlti5Vsu2WpSkU2ksZRDdMVKJy2XRMJjlYom3O1eSRsFNje5IrQWpQDlJuzLSaNT USyxAg8wHoDdl68uCDC3DrKAP6wr9Fn30CAX9HeQALlKHIIREOoPCoQgula+fBTgG+bc u6+QmAbAbjJp3W+59jqd6JI9ZJI8CPPERG5SXNC1LndlZ7xUWU7iWRAZX/KMd6A6mh1c X6Kpftza7c3vkz9wGlLlgbRlqdshmRpdbUFSyesT62ppFHGRjjn/cm6Xto2LVZlkGoJ9 XA8xLZyLVUJ6ljiODQYeEqk/ZzcV742iWqTOPxWNEfKsZXDcBEq8mFzMxnBTC6syBn46 jkTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=yC9fzSeBnu/Rjb4F7zW0lA+EjBp/rWP8jDmFwNrgebU=; b=jfGHPXpJqZ+hBA211NLkzgF/nH4LBHCroDSOxloRpu02GEtwEATXhUGoVwxuZ1Gtda G/eHKEMdPVYyIJY+MPSsivTwRs5/mWpD2i2ko9SpnY7hogp/hhp50oEtaY5DkC7B6LJW 7mgLAhvR1nOD0/pbF3SvM4ECB8mFtdwXlbymz7eSQGBV9LwT2+LgmqJNLlONOQ/hReLy ltFs4QReUOm8aYuP0/V6+8sDilUb7gSxu+as6jehAm1M7411QIjoid5/cWluwQJ7vpp8 cvXszig96Ll4fDSbNlKSjQkroXavtM78OPbYGmm9cb4pEfaOHvFO8T7Q5f6buWLJ5Ue3 R/YQ== X-Gm-Message-State: ALyK8tIocM4/5pLzpi8jOJseUilw1GdiuIpbvYuBApFSzU7LwA/jkJxMTKLjq+3NjYj3ZdFT X-Received: by 10.194.83.202 with SMTP id s10mr20688819wjy.17.1465304017724; Tue, 07 Jun 2016 05:53:37 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id dl5sm10630390wjd.32.2016.06.07.05.53.36 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Jun 2016 05:53:37 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, Bruce Richardson , Stephen Hemminger , Panu Matilainen Date: Tue, 07 Jun 2016 14:53:36 +0200 Message-ID: <9045763.zD3817Zzj4@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160607120454.GA3903@hmsreliant.think-freely.org> References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <2333946.Qkm8bLFkOf@xps13> <20160607120454.GA3903@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv6 1/7] pmdinfogen: Add buildtools and pmdinfogen utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 12:53:38 -0000 2016-06-07 08:04, Neil Horman: > On Tue, Jun 07, 2016 at 11:57:42AM +0200, Thomas Monjalon wrote: > > 2016-05-31 09:57, Neil Horman: > > > +++ b/buildtools/Makefile > > > @@ -0,0 +1,36 @@ > > > +# BSD LICENSE > > > +# > > > +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > > > +# All rights reserved. > > > > I really think it is a strange copyright for a new empty file. > > > Its not empty, It lists the subdirectories to build. And given that the DPDK is > licensed under multiple licenses (BSD/GPL/LGPL), it introduces confusion to not > call out the license in a specific file, file size is really irrelevant to that. Neil, please take a drink :) I'm not talking about license but about copyright. Don't you think it's strange to put "2010-2014 Intel" copyright on top of the few lines you wrote? > > > +#if __x86_64__ || __aarch64__ > > > > Better to use CONFIG_RTE_ARCH_64. > > > I'm not sure why, given that every supported compiler defines the arches I use, > but sure, fine. Because it will work for every 64-bit arch in DPDK. > > > --- /dev/null > > > +++ b/mk/rte.buildtools.mk > > > > I'm sorry I really do not agree it is a good practice to create a new > > makefile type just for a new directory. > > My opinion is that you should use and improve rte.hostapp.mk to make > > it usable for possible other host apps. > > > I am so exhausted by this argument. > > They are the same file Thomas. I'm not sure how you don't see that. I've > explained to you that they are, with the exception of whitespace noise, > identical. buildtools is a better nomenclature because it more closely > describes what is being built at the moment. The only reason we still have > hostapp is because you didn't remove it when you removed the applications that, > in your own words from the commit log, are "useless". The argument that we > should keep the build file, and its naming convention on the off chance that > someone might use it in the future really doesn't hold water with me, at least > not to the point that, when we have something that duplicates its function we > should do anything other than take the path of least resistance to make it work. > I'm not sure how you expected anyone to know there is a makefile in place in the > DPDK to build local application, when there are currently no applications in > place, but asking people to use it after the fact is really just the height of > busywork. If it was already building other utilities, I'd feel differently, but > given that its just sitting there, a vestigual file, makes this all just silly. > > But clearly, this isn't going to be done until I do what you want, regardless of > what either of us think of it, So I'll make the change. You can keep it as is if you find someone else to say that having a makefile template named and specific to only the buildtools usage is fine. And no, it is not identical to rte.hostapp.mk. But I was probably not clear enough: I do not like rte.hostapp.mk. I just like its explicit name. I see the same issue in rte.hostapp.mk and rte.buildtools.mk: they should be build in the app/ subdir like any other app. So my suggestion is to replace rte.hostapp.mk with your implementation in a separate patch with the build path changed to app/ instead of hostapp/ or buildtools/.