From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 876411B228 for ; Tue, 14 Nov 2017 23:46:48 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ABE7320DF8; Tue, 14 Nov 2017 17:46:47 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 14 Nov 2017 17:46:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=L8bWl5g43/83nwWQMB35CWcX8O wVuCoK1wfrQ5rBTho=; b=qqEjZ4v6C5lCWLcLnsuijJ/zdLSMT36tZU5vRcCiam nwB81Adz7WP0yll6flJ5WXjgVrSyVHJACe+mdzYfz3ZRNf/Vh/D6Kb2QiD7enipQ Z/EKpBYWUeFQ9rXC+uOQsl/lkrO0ga+VwUKiSn/bQM2rkc3bahVQ5NAU1DpX5OxJ g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=L8bWl5 g43/83nwWQMB35CWcX8OwVuCoK1wfrQ5rBTho=; b=mkyo0LRkXgDbYL8OCmXwlc pqLETFkUQPoWeJsDLc1M4GzehvNNMEKZFcR9lRSDyS6DtkKrvE+f7d3FNeazsSD1 /OP/s9jNk1oMAgfOx9E2efZn8ixvYFSmuYJ4xESQW39bJlzOysuPfMAf52TR2Npy bCBy6EHDq6AiC9C/SXkDq4BuC/7tesmYvL/Y1dXWYAjBa+OiedDB7XSPkmiPZgwp r1lav6yABqaJzhxTOUV5WbFXpDqSQOl9g3anobaZgVuKwkcvuISKmAA6k8i6vwEI KrqoXpii8erQu52pPTX2xKwHlSibzA7xrAqx8yNrFw9Aj7E/5JuT3LcMkx+5uvnw == X-ME-Sender: Received: from xps.localnet (unknown [64.124.208.80]) by mail.messagingengine.com (Postfix) with ESMTPA id 618D77FAF0; Tue, 14 Nov 2017 17:46:47 -0500 (EST) From: Thomas Monjalon To: Ilya Matveychikov Cc: dev@dpdk.org, Olivier MATZ Date: Tue, 14 Nov 2017 23:46:45 +0100 Message-ID: <9049896.KWG8HvEvih@xps> In-Reply-To: <20171114082444.7v2dspzxno2vmbln@platinum> References: <04EF52DF-6CE8-4EF4-96AA-711184F8379F@gmail.com> <3421519.PnyVhdA6Oj@xps> <20171114082444.7v2dspzxno2vmbln@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs types change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2017 22:46:48 -0000 14/11/2017 09:24, Olivier MATZ: > On Tue, Nov 14, 2017 at 06:09:35AM +0100, Thomas Monjalon wrote: > > > > >> Update types of variables to correspond to nb_segs type change from > > > > >> uint8_t to uint16_t. > > > > >> > > > > >> Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments") > > > > >> Cc: olivier.matz@6wind.com > > > > >> > > > > >> Signed-off-by: Ilya V. Matveychikov > > > Acked-by: Olivier Matz > > > > Is there a real benefit to get it in 17.11? > > Without this patch: > > - cloning a mbuf with more than 255 segments will create an mbuf with an > invalid number of segments. > > - chaining mbufs with rte_pktmbuf_chain() will return an error if the > resulting mbuf has more than 255 segments. > > > Is there a risk? > > It is not so critical, since manipulating mbufs with a large number of > segments is a very specific use case. > > But the risk seems low, I think we can put it in 17.11. OK, applied, thanks