From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E12DBA00BE; Tue, 8 Feb 2022 14:14:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76388410FD; Tue, 8 Feb 2022 14:14:10 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 2E5DA410FC for ; Tue, 8 Feb 2022 14:14:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644326049; x=1675862049; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ILj8sQ0nX8bzTspIEW+bJ9YN97IzJ4JXuXcZnFlnjMA=; b=i3Zu4a1d9MaZGHnLO3s9RzsZDY1LwGrFg8RrctrM8AYmmcjdHEamPEpO ZjEIoLWbGpalp5pVZKloXROA6oyUdMbQC42SN04ep5YTFfQal3uj7IjMk /3qS4l+lBJoCu21ceRJmqll9bjb61qq0Ub0OkLMNUp+tq+BKoM5FyX/gP f7OmnK9+9iywK+vs1tzHmyx2zHWXNsOc8jY7WLqihiVLW1vD1e9L4HANW 4fXdAUxcKdLm0lLTAlzSkH5gO+00Cn8m3UVaLtNWUuE7CNI/58nx5xB58 DclGrnkfa2hc9yJ+1ZBqVepuOwhHLrTZ7zt9yGpJs6yyedXrs4QRG3Ytn g==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="335346432" X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="335346432" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 05:14:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="770980063" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 08 Feb 2022 05:14:08 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 05:14:08 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 05:14:07 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 05:14:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dXEcqeXyXVvbc0GiSvf54v7DhkokexEhaJmDfceKsiOhtPfr7+jrfv48dyhofKOsbppzRjwwMwbzq3DCbz6eXznUUBgW8M+GtO6pwHImRhy0Wlheu2mlANm4vhkH/xQfH02rZAfyQZ0sAyBgxG11pmsxvetA+D+A633MnnhsxgcZcazt61wujMwYiTGBNkRpYOOmJKd5dzSnvksr3JrFzaOqfC4EXBUy+wtXJjhky/xUPavoUXX4BsxgtKVAunOuwkHYUP46X2idt91EccZMREFI2chy+3PIdEV+6FSN/GYLOcN1WRxyaJ/DxrD3kxQQXDSIw1hlZswL2zxUfj4OEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RpsKq04rJqUg8rzE8X5fHBopPWR/MVKaP6bitgx8+ro=; b=dbneK3dWyyQM+jTqdz8qxM+mbx6BgqPf3TZHX2dx5MlSAeOqloOeh7mVTZ3J+o7crTgSQuQYrWsbwNWLHEXqxif47ZsMstVgAi9GPAofqXW9D9UPsXMyLLV2+CnfeX8O21mEPp2yiot9OHIt/mDtN34FPvZ5Hqk2pjmtscz9G6aP68n57XujcJtfi6PebOzCBCgSliuCcENh6spo77kUjiXikdnIGv2e2MmjNLuWhVj4GrdsYcboPBC3iNzMb1QNdb1Omeuedoofi+YkRn8pnEfKk3GASEmAXMhptxITeu1mnNd6X9hKWzwZCvstuM1drjEW4FeyV0ojtGGUEaWi3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB4428.namprd11.prod.outlook.com (2603:10b6:5:202::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Tue, 8 Feb 2022 13:14:05 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 13:14:04 +0000 Message-ID: <907ee151-ae4d-cbab-b491-5afebb3c1871@intel.com> Date: Tue, 8 Feb 2022 13:13:58 +0000 Subject: Re: [PATCH v4 1/6] ethdev: add L2TPv2 RSS offload type Content-Language: en-US To: Jie Wang , CC: , , , , , , , , References: <20220129062434.2455711-1-jie1x.wang@intel.com> <20220208083849.510136-1-jie1x.wang@intel.com> <20220208083849.510136-2-jie1x.wang@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220208083849.510136-2-jie1x.wang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0006.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32fd6d21-36eb-43ce-561b-08d9eb04e17f X-MS-TrafficTypeDiagnostic: DM6PR11MB4428:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:843; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GncvCKL5zl8DNaRaKHdSwz/hXEcG8c3UYCy6UuGbT8qQcO2RZppEzcT/Khi3kzJEMAmPSvegPjKql6NzxrQhEb9tSrcZFi8sDjYWZU3v+aLJnVYIPAotU1Plvv8vRykEJufq6H8oyMKq/bE7JnfuKz3LK5+GY7OxkmK1rHNVmXDTDbpMBixdPGWY0yVOJ+La8k6hGFYy+EiVc5v2Ue0Unk5bpC0QZnADVKN6yfsP5F2hKscTn4c+xoONg33+3z0vY35Irrk6BPi1mLfChB3OGgq1LanKuQTj3JUXNSAiUI+JGKYpolQeQ9h/MZ42+syEuj+zcZZkPu8oqEy/FbvtmFzCQsohXVZWCLaPm1i/hXSLWjVowfOa0b24CPwJr47cr3ok/wqg7QZjaDcQLoiuKZnWGKPVh6w295/ESUtGChyWLEqqoI8mXHjWwPFPagwb1H9GajhlUDVApGD3ioiRU0lSoJ2iQlBF2Mj6h4jS+8/amhDowqnWA+m8s4z+lh+bQL/wQ4AerAPkNolia7AyZqEafimwrN0mH/RkSeAA+A/3apakpF4bTyxjXyL0xb8Ia1lCG0DsgwaUpVH1JrGUu+hKwwze9/ZfuLxcOQkvRdRf1Dz4iuiQcQ8/OOGP2SwmwMh3dsNb79kwhyz/E7mGDjMiIesl8yFQ2flMIzM4oSeIy4U/loKEzmyRIQsJk03+yCdco+kbHHv99/OKrLGzdg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(4326008)(316002)(6666004)(82960400001)(55236004)(2906002)(508600001)(53546011)(66946007)(31686004)(66556008)(8676002)(66476007)(8936002)(44832011)(6506007)(5660300002)(6512007)(31696002)(86362001)(186003)(2616005)(36756003)(38100700002)(26005)(83380400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THpqT1Jla0RINndSc1Uxb0NJOVpnR2VEelAySmdFQnh3dm5CczdUbXAyVkFa?= =?utf-8?B?TFVKM1JOemFwTDcwNENWNVNYckxzdjlrV2c3VFhQQXdqdlVRd0pmNVZxSmQy?= =?utf-8?B?Z3hGMFM3b2ZPRDR3SkJuSlVqVGt3Mm10SXFXclp5RWh1M1Qzck1hVzJqNUJh?= =?utf-8?B?ZTZBdU9TYTI0bkkwUGZSelllS2hScHRzaGR5eElFL2k0Rk9aaG5KM3hlZkJM?= =?utf-8?B?eWNvK1RrTktySjlVK0hERm9oaytYWU5oNStYanExS1VMK01IK2tUaTNGb1Fi?= =?utf-8?B?eHlUSWRNNUlURDFRbXhBSnUrbkpIcGZLUHNqemlUdVowTnIzdGwzU1FIdmVi?= =?utf-8?B?cS9Ya2NPWGdqdWozWTVWRWVSYW1Sckg1SlQ1UEMvOERLdERheVdtd0hoUytD?= =?utf-8?B?VWhlc2FMVG4xU3NzNFJDa3RUamtnTVpNSVp3U3NJVmp0MGdIUjY4U1BRR0c1?= =?utf-8?B?KzJiS1REVXd6Q1R4a0VKd21tWUhhbHhaSzVkSWVlUUVDRXpzVlBCdEtKbitn?= =?utf-8?B?aGNoN3g1ZW9vWUJSREpFZWd0c0dCbk9vbEVJcSthVStwRTRHbnkrRUltdzYr?= =?utf-8?B?a0Z1SEU4cGxrcHhWNHdwU3MrWlFoUVltTVBnWHdKenozclNBdzRTaXI5bzkw?= =?utf-8?B?UVFOV3o4VE5YTjUxc0lLRXNHZ05iMkJLdERxWVhmMXZFRXJTVU1hRHp2Tjhk?= =?utf-8?B?MmtTbUJlbTRRNDRLTjMwRjdMcDJIWmsxcTVWM24zWEk5MnVEV2h2UVkvNXNx?= =?utf-8?B?eHdhQ09iWG5rZ0dNOGZXcEhEZklBQmEyV1JncWFMV3VGTFhlM2pVRXkyVHds?= =?utf-8?B?U0dOREhLMW9pMDVRNUFvS1RnUGNtbDlmNzVUYWYrcWd5VUxWalM1MzFkeEZ4?= =?utf-8?B?cExWZWFDWitxQ3NUcEVVcWhSempkU1I4ZUJOZHEvWTRzZVpmdTQzNkh1cHc2?= =?utf-8?B?U3crTXQ0WGJnWUVyUGZqQmRkRWwxZW1vYXJoZ2pFOVlnVUJQTTN2Q3F3eEV5?= =?utf-8?B?RnF6U1NKMnEvYWRna1AzQkUyT212WndXMEExUGRvZERLR2xRS0tGNHo4WTdW?= =?utf-8?B?TXVZOGVDcXBmREJibDRzQU9RQXphbnR5MEdTNjY0WlN6dnlHdTRuT09pbHBY?= =?utf-8?B?L1B3blp1TzAzNUJtSG45STI5VDY4NXJNaGdlOFMyZ0xIa1c1V3JabU9hVGRi?= =?utf-8?B?VjB1RCt2UitYaStFOEtQK3pVL0FiNU9SVk4xbnFzN2hnM0Q5dXBqMUd4VUNt?= =?utf-8?B?VjJxNU5BTTlURUZpbmdRQ2F1L0x2ekJtaHRrQnU2b2tQOFB4L3dwWVFONFhB?= =?utf-8?B?NzM3NEJqbDl3SG5pVkdLMC9PRy9PdHB3TC9VYktrNlQyMGJndThJV2U2ZXJL?= =?utf-8?B?Z3ZwRUdEVWYwRzY0MGp4R2h6SEpocmFZMjZPbHZBTUZlTXZSREpxenZMYXFM?= =?utf-8?B?ZDhzci9YSTVpQXdwVnRscDhmWEo2U3piQlpvTTVBM2pIOENHYU5FNUZzNWRv?= =?utf-8?B?RUt4VDY3c3N5ODRQclA1S0NwdmMydWM4dExnZkpobWFiUTBud0ptZEErdDBq?= =?utf-8?B?VGwzNXluZXk5YWdZZGxud2xhOXdKSm9xdlpSSTFpRVdTWHBnYXlGNFVvOCt0?= =?utf-8?B?ZHVlSzBhNS9wR0RjY2M1VW1lN2tUalMvQmRHdWEyZWhORG1sRzNkRUpSc05N?= =?utf-8?B?STR6NUJBUGlEeEEyaC85R3pFSXJIaGFMc0ZKVHZYbUNicnJ3VXpxcGphWlN5?= =?utf-8?B?SFZjNVhsK2l1V2lUMHFhMStqNjJoWnViWUsrOXJCTVhleXBYNyt0ZGVLN01X?= =?utf-8?B?Qm42N0ZpczhZZ2pxd3k3TXpQRFA5OHpVRGZscXA4R3IybmpYTllEMWZJckJm?= =?utf-8?B?WndCY2V5NVhBdExUSHpFMWh1bkdJb0kzL1BjYVNjQStML0tCTHVYUmlLUC9O?= =?utf-8?B?Nmo1OHhVVGhPNldmZWNlTW5kVFBLMjAzR0plN3BpYzhMYmRlT0FGWEU2M002?= =?utf-8?B?RG5iZnZiNjh6RjdYcU9ZbHYxQjhwTm9LUzQwc0theGJrLzY5V3BsRC9rL0J5?= =?utf-8?B?Mk90dVdrSXIwMVhSWTRHeGVLOTk5TmhoMldITW9Cck13N0ZhZmllS0V5OStW?= =?utf-8?B?SDR4SGZvbUtXd0VyeEgwdmNuRmU3Nm1ET3dEdW1xNmlDaUh3MnVrRnN5VzI1?= =?utf-8?Q?5qMcO8hTaKANieMPQKv6aXs=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 32fd6d21-36eb-43ce-561b-08d9eb04e17f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 13:14:04.7906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ECq0MGnbJsWTgtasKIA0F8+iVk6ajRZpGdrq7YV9bc/QcyPHrPLYWDNhGb3zxVREJPiL7GC5H8OvzIfxMNyYHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4428 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2022 8:38 AM, Jie Wang wrote: > This patch defines new RSS offload type for L2TPv2, which > is required when users want to distribute packets based on > the L2TPv2 session ID field. > > Signed-off-by: Jie Wang > --- > app/test-pmd/cmdline.c | 10 ++++++---- > app/test-pmd/config.c | 3 ++- > doc/guides/rel_notes/release_22_03.rst | 5 +++++ > lib/ethdev/rte_ethdev.h | 6 ++++++ > 4 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index e626b1c7d9..d535311f21 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2178,7 +2178,7 @@ cmd_config_rss_parsed(void *parsed_result, > RTE_ETH_RSS_TCP | RTE_ETH_RSS_UDP | RTE_ETH_RSS_SCTP | > RTE_ETH_RSS_L2_PAYLOAD | RTE_ETH_RSS_L2TPV3 | RTE_ETH_RSS_ESP | > RTE_ETH_RSS_AH | RTE_ETH_RSS_PFCP | RTE_ETH_RSS_GTPU | > - RTE_ETH_RSS_ECPRI; > + RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_L2TPV2; > else if (!strcmp(res->value, "eth")) > rss_conf.rss_hf = RTE_ETH_RSS_ETH; > else if (!strcmp(res->value, "vlan")) > @@ -2256,6 +2256,8 @@ cmd_config_rss_parsed(void *parsed_result, > rss_conf.rss_hf = (rss_hf | RTE_ETH_RSS_LEVEL_INNERMOST); > } else if (!strcmp(res->value, "default")) > use_default = 1; > + else if (!strcmp(res->value, "l2tpv2")) > + rss_conf.rss_hf = RTE_ETH_RSS_L2TPV2; > else if (isdigit(res->value[0]) && atoi(res->value) > 0 && > atoi(res->value) < 64) > rss_conf.rss_hf = 1ULL << atoi(res->value); > @@ -2314,7 +2316,7 @@ cmdline_parse_inst_t cmd_config_rss = { > .help_str = "port config all rss " > "all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|" > "nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|none|level-default|" > - "level-outer|level-inner|ipv4-chksum|", > + "level-outer|level-inner|ipv4-chksum|l2tpv2|", > .tokens = { > (void *)&cmd_config_rss_port, > (void *)&cmd_config_rss_keyword, > @@ -2429,7 +2431,7 @@ cmdline_parse_token_string_t cmd_config_rss_hash_key_rss_type = > "ipv6-tcp-ex#ipv6-udp-ex#" > "l3-src-only#l3-dst-only#l4-src-only#l4-dst-only#" > "l2-src-only#l2-dst-only#s-vlan#c-vlan#" > - "l2tpv3#esp#ah#pfcp#pppoe#gtpu#ecpri#mpls"); > + "l2tpv3#esp#ah#pfcp#pppoe#gtpu#ecpri#mpls#l2tpv2"); > cmdline_parse_token_string_t cmd_config_rss_hash_key_value = > TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, NULL); > > @@ -2442,7 +2444,7 @@ cmdline_parse_inst_t cmd_config_rss_hash_key = { > "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|" > "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|" > "l2-src-only|l2-dst-only|s-vlan|c-vlan|" > - "l2tpv3|esp|ah|pfcp|pppoe|gtpu|ecpri|mpls " > + "l2tpv3|esp|ah|pfcp|pppoe|gtpu|ecpri|mpls|l2tpv2 " > "", > .tokens = { > (void *)&cmd_config_rss_hash_key_port, > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 1722d6c8f8..ec922bd304 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -90,7 +90,7 @@ const struct rss_type_info rss_type_table[] = { > { "all", RTE_ETH_RSS_ETH | RTE_ETH_RSS_VLAN | RTE_ETH_RSS_IP | RTE_ETH_RSS_TCP | > RTE_ETH_RSS_UDP | RTE_ETH_RSS_SCTP | RTE_ETH_RSS_L2_PAYLOAD | > RTE_ETH_RSS_L2TPV3 | RTE_ETH_RSS_ESP | RTE_ETH_RSS_AH | RTE_ETH_RSS_PFCP | > - RTE_ETH_RSS_GTPU | RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_MPLS}, > + RTE_ETH_RSS_GTPU | RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_MPLS | RTE_ETH_RSS_L2TPV2}, > { "none", 0 }, > { "eth", RTE_ETH_RSS_ETH }, > { "l2-src-only", RTE_ETH_RSS_L2_SRC_ONLY }, > @@ -143,6 +143,7 @@ const struct rss_type_info rss_type_table[] = { > { "mpls", RTE_ETH_RSS_MPLS }, > { "ipv4-chksum", RTE_ETH_RSS_IPV4_CHKSUM }, > { "l4-chksum", RTE_ETH_RSS_L4_CHKSUM }, > + { "l2tpv2", RTE_ETH_RSS_L2TPV2 }, > { NULL, 0 }, > }; > > diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst > index 33be3241b9..9a507ab9ea 100644 > --- a/doc/guides/rel_notes/release_22_03.rst > +++ b/doc/guides/rel_notes/release_22_03.rst > @@ -55,6 +55,11 @@ New Features > Also, make sure to start the actual text at the margin. > ======================================================= > > +* **Added new RSS offload types for L2TPv2 in RSS flow.** > + > + Added macro RTE_ETH_RSS_L2TPV2, now L2TPv2 session ID field can be used as > + input set for RSS. > + > * **Updated Cisco enic driver.** > > * Added rte_flow support for matching GENEVE packets. > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 147cc1ced3..b7e78618c8 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -651,6 +651,12 @@ struct rte_eth_rss_conf { > #define RTE_ETH_RSS_L4_CHKSUM RTE_BIT64(35) > #define ETH_RSS_L4_CHKSUM RTE_DEPRECATED(ETH_RSS_L4_CHKSUM) RTE_ETH_RSS_L4_CHKSUM > > +/* > + * Below macro is defined for RSS offload type, it can be used to > + * fill rte_eth_rss_conf.rss_hf or rte_flow_action_rss.types. > + */ Why this comment is duplicated here? (There is exact same above, and it is wrong to have it here.) If this is the only comment, I can remove it while merging. > +#define RTE_ETH_RSS_L2TPV2 RTE_BIT64(36) > + > /* > * We use the following macros to combine with above RTE_ETH_RSS_* for > * more specific input set selection. These bits are defined starting