Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process

[Kevin Traynor <ktraynor@redhat.com>]

On 14/01/2020 19:51, Rasesh Mody wrote:
> Hi Kevin,
> 
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, January 14, 2020 10:52 AM
>>
>> On 14/01/2020 04:51, Jerin Jacob wrote:
>>> On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody <rmody@marvell.com>
>> wrote:
>>>>
>>>> Skip the device re-initialization for secondary process.
>>>>
>>>> Cc: stable@dpdk.com
>>>
>>> Correct Cc: to stable@dpdk.org
>>>
>>
>> Is it a fix, or secondary process was not intended to be supported previously?
>> If it is a fix, please provide the Fixed commit (will save Ferruh searching for it).
> 
> Secondary process was not intended to be supported previously. So it is ok to not backport the change to all ongoing stable releases.

Thanks for confirming.

> However, the change has been tested with DPDK 19.11, I am wondering if it can be pulled in that stable tree.

Cc Luca

> Please see below the fixline tag.
> 
> Fixes: 540a211084a7 ("bnx2x: driver core")
> 

Fixes tag won't be needed now as you've confirmed the code was doing
what it was intending to do.

> Thanks!
> -Rasesh
>>
>>> Applied to dpdk-next-net-mrvl/master. Thanks
>>>
>>>
>>>> Signed-off-by: Rasesh Mody <rmody@marvell.com>
>>>
>>>> ---
>>>>  drivers/net/bnx2x/bnx2x_ethdev.c | 5 +++++
>>>>  1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c
>>>> b/drivers/net/bnx2x/bnx2x_ethdev.c
>>>> index 20b045ff87..7864b5b80a 100644
>>>> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
>>>> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
>>>> @@ -598,6 +598,11 @@ bnx2x_common_dev_init(struct rte_eth_dev
>>>> *eth_dev, int is_vf)
>>>>
>>>>         eth_dev->dev_ops = is_vf ? &bnx2xvf_eth_dev_ops :
>>>> &bnx2x_eth_dev_ops;
>>>>
>>>> +       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
>>>> +               PMD_DRV_LOG(ERR, sc, "Skipping device init from secondary
>> process");
>>>> +               return 0;
>>>> +       }
>>>> +
>>>>         rte_eth_copy_pci_info(eth_dev, pci_dev);
>>>>
>>>>         sc->pcie_bus    = pci_dev->addr.bus;
>>>> --
>>>> 2.18.0
>>>>
>>>
> 
>