DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jeff Guo <jia.guo@intel.com>
To: Shougang Wang <shougangx.wang@intel.com>, dev@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>, Qiming Yang <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix failing to create FDIR flow
Date: Tue, 12 May 2020 18:23:08 +0800	[thread overview]
Message-ID: <9092ea40-5d87-d16e-f089-ae477ea81374@intel.com> (raw)
In-Reply-To: <20200506061455.102358-1-shougangx.wang@intel.com>

hi, shougang

On 5/6/2020 2:14 PM, Shougang Wang wrote:
> This patch fixes the issue that the flow which both source MAC mask
> and destination MAC mask are all zeros can not be created.
>
> Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set")
>
> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
> ---
>   drivers/net/i40e/i40e_flow.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
> index 7e64ae53a..fa6ab4fbf 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -2643,7 +2643,8 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
>   					filter->input.flow.l2_flow.src =
>   						eth_spec->src;
>   					input_set |= (I40E_INSET_DMAC | I40E_INSET_SMAC);
> -				} else {
> +				} else if (!rte_is_zero_ether_addr(&eth_mask->src) ||
> +					!rte_is_zero_ether_addr(&eth_mask->dst)) {


Alignment should be match above parentheses? Other look good, you could 
add my Review-by next.


>   					rte_flow_error_set(error, EINVAL,
>   						      RTE_FLOW_ERROR_TYPE_ITEM,
>   						      item,

  parent reply	other threads:[~2020-05-12 10:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  6:14 Shougang Wang
2020-05-06  8:55 ` Xu, HailinX
2020-05-12 10:23 ` Jeff Guo [this message]
2020-05-13  2:54 ` [dpdk-dev] [PATCH v2] " Shougang Wang
2020-05-13  5:17   ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9092ea40-5d87-d16e-f089-ae477ea81374@intel.com \
    --to=jia.guo@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qiming.yang@intel.com \
    --cc=shougangx.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).