From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3360BA04A2; Tue, 12 May 2020 12:23:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 973AF1BFEE; Tue, 12 May 2020 12:23:13 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6B6C11BFEB for ; Tue, 12 May 2020 12:23:11 +0200 (CEST) IronPort-SDR: BFGjoLkVFti17qfiVVII/wi7tEfVFDNxb8XCzvA1jZmB5gA0FdcDqx81s9Y8OnNz+rxnddTNL7 L+CzxOIPlwmQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 03:23:10 -0700 IronPort-SDR: H/VnzpVQl7k2Wh4EoT8m2UouSgu3ApOQ7bXNtO0BotQxFqlWD471IJCcjLDW8cVrjLMWQz5x5L 0Ef0ilG8Eo6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,383,1583222400"; d="scan'208";a="286599995" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.165]) ([10.67.68.165]) by fmsmga004.fm.intel.com with ESMTP; 12 May 2020 03:23:09 -0700 To: Shougang Wang , dev@dpdk.org Cc: Beilei Xing , Qiming Yang References: <20200506061455.102358-1-shougangx.wang@intel.com> From: Jeff Guo Message-ID: <9092ea40-5d87-d16e-f089-ae477ea81374@intel.com> Date: Tue, 12 May 2020 18:23:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200506061455.102358-1-shougangx.wang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix failing to create FDIR flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, shougang On 5/6/2020 2:14 PM, Shougang Wang wrote: > This patch fixes the issue that the flow which both source MAC mask > and destination MAC mask are all zeros can not be created. > > Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set") > > Signed-off-by: Shougang Wang > --- > drivers/net/i40e/i40e_flow.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c > index 7e64ae53a..fa6ab4fbf 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -2643,7 +2643,8 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, > filter->input.flow.l2_flow.src = > eth_spec->src; > input_set |= (I40E_INSET_DMAC | I40E_INSET_SMAC); > - } else { > + } else if (!rte_is_zero_ether_addr(ð_mask->src) || > + !rte_is_zero_ether_addr(ð_mask->dst)) { Alignment should be match above parentheses? Other look good, you could add my Review-by next. > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ITEM, > item,