From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DBDE416E for ; Wed, 30 May 2018 21:07:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5819121B6D; Wed, 30 May 2018 15:07:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 May 2018 15:07:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=GUrJG701NqFz8g0ETegWkg+FJw rANBHQMPIQr63wbO8=; b=ahSaJBp9fMy8bcjfZ2hhOS8DFE+4Ltgisfwk2yr/Wp NPztp8n7vuUU+yNajv+noUZcs3hGrkQUgofhdNxBhTuTkH/yxvamjK2kFA+c6sG+ hxldgDke1cVktD9W0aGalrSBZ90yXZFymp2zc20xugWQy+lk7Bj0nsxs3931PAih s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GUrJG7 01NqFz8g0ETegWkg+FJwrANBHQMPIQr63wbO8=; b=P93Mv6ni007A7KR63cPZP+ FNRy5ElxbKWVwcSd7YAET6KPt6OU1ycM2ZSphepxQEmyA2ZBXpAzo9FPvScvd0py crOBn2MWyksLec4uSypfp4bpxyOXYwUCYcN52D7C4Cm+BT8bcoh03QU/SreFGKWH dJ7KDsKIJaTs3sQAx3TXyciQPf6lhqLQR0q2I/9FbM0z4m2egF6ETnLDwM1quu+K hYGLhsaoUESZf1YmIwxR2sYTHbiIzhQU6bo0Uwb5dMifw/YpNRQ2aNbJLBLcBT7R 612w2QuE4ftpbD3Ac4fk0nPQ39T6wpdcZk9AKNejWnEYRQTtbbEyit+cTjnA4X7A == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5293FE42B0; Wed, 30 May 2018 15:07:11 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Yongseok Koh , Adrien Mazarguil , =?ISO-8859-1?Q?N=E9lio?= Laranjeiro , Shahaf Shuler Date: Wed, 30 May 2018 21:07:10 +0200 Message-ID: <9098846.r4ODMIHPIA@xps> In-Reply-To: References: <20180530144253.8935-1-david.marchand@6wind.com> <73FA6D64-52F7-4273-971E-6A1579073631@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: only register memory callback when probing a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 19:07:13 -0000 30/05/2018 18:04, David Marchand: > On Wed, May 30, 2018 at 5:59 PM, Yongseok Koh wrote: > >> On May 30, 2018, at 7:42 AM, David Marchand wrote: > >> > >> The callback should be invoked only for memory that has been registered > >> in a device, hence, no need to track cleanup events if no device is > >> present. > >> > >> Bugzilla-ID: 56 > >> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") > >> > >> Signed-off-by: David Marchand > >> --- > > > > Good finding! Thank you so much for the patch. > > Patch is good. Just to be sure, I've run traffic with testpmd and also run > > multi-process test examples with traffic. It runs well. > > > > Acked-by: Yongseok Koh > > Well, this is a quick fix, the mlx5_prepare_shared_data() now does > more than initialising the shared data... > Might be better to revisit later, but this should do the job for 18.05. Applied, thanks