From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
(mail-by2nam03on0061.outbound.protection.outlook.com [104.47.42.61])
by dpdk.org (Postfix) with ESMTP id 1777E939A
for <dev@dpdk.org>; Thu, 8 Sep 2016 07:47:54 +0200 (CEST)
Received: from DM5PR03CA0003.namprd03.prod.outlook.com (10.175.104.13) by
DM5PR03MB2441.namprd03.prod.outlook.com (10.168.233.11) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id
15.1.609.9; Thu, 8 Sep 2016 05:47:52 +0000
Received: from BN1BFFO11FD052.protection.gbl (2a01:111:f400:7c10::1:108) by
DM5PR03CA0003.outlook.office365.com (2603:10b6:3:118::13) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id
15.1.609.9 via Frontend Transport; Thu, 8 Sep 2016 05:47:52 +0000
Authentication-Results: spf=fail (sender IP is 192.88.168.50)
smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com;
Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not
designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com;
client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;
Received: from tx30smr01.am.freescale.net (192.88.168.50) by
BN1BFFO11FD052.mail.protection.outlook.com (10.58.145.7) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6
via Frontend Transport; Thu, 8 Sep 2016 05:47:51 +0000
Received: from [10.232.14.87] ([10.232.14.87])
by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u885ll0v019240;
Wed, 7 Sep 2016 22:47:48 -0700
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>
<1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com>
<1472219823-29486-11-git-send-email-shreyansh.jain@nxp.com>
<3AEA2BF9852C6F48A459DA490692831F01075153@IRSMSX109.ger.corp.intel.com>
CC: "viktorin@rehivetech.com" <viktorin@rehivetech.com>,
"david.marchand@6wind.com" <david.marchand@6wind.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-ID: <90b209c8-338e-a4dd-1d0f-95864b014710@nxp.com>
Date: Thu, 8 Sep 2016 11:18:03 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F01075153@IRSMSX109.ger.corp.intel.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-Matching-Connectors: 131177872717438398;
(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()
X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;
SFV:NSPM;
SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(24454002)(199003)(189002)(377454003)(81156014)(5660300001)(15650500001)(65826007)(87936001)(65956001)(85426001)(15395725005)(77096005)(47776003)(81166006)(65806001)(105606002)(2420400007)(626004)(36756003)(305945005)(7846002)(586003)(8666005)(356003)(15975445007)(106466001)(7110500001)(230700001)(189998001)(8676002)(50466002)(33646002)(50986999)(76176999)(54356999)(31686004)(19580395003)(2950100001)(92566002)(104016004)(93886004)(8936002)(23746002)(10710500007)(2501003)(4326007)(97736004)(11100500001)(5001770100001)(4001350100001)(83506001)(68736007)(64126003)(2906002)(86362001)(31696002)(7059030);
DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2441; H:tx30smr01.am.freescale.net;
FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD052;
1:1D/jqeC66B/BrK7M7jsWu36yfyxgZygAu9ZgeB290ahOhW8HWAeDQd+26bpd2mv1CSUlxXfBq1k45F1MlODjuYSM0BsCQmi1CCp0WW3YN/92VvQ57OZ7mMMqmni3jCSEBQixYqA1iy+MBWk7FIPktrqaQuWz3IyL9bNVk521pS8sWw4m5G6Urf8Nj1h1A0l2Nl+MLWkQgZ0ldFi7xSnH2GZHyVIovu3+S4pzU0FqNUpK/8L57m+789aK9LoHTNfkTSbg/lSfDCnAGkHMBKkVz+K+IRQlBsBLmITgHYZLbfih0CZKfSQTbTZOG4SC5Fxu7OUaqn2Why2N1yxmTeDDvdKpFXwM/q7OAPZfN21fdbDhwzouejmMA5Pc10QxjNnXPT+wql8iojcioNXIph+18MCn+jqG89TtZF/vt944/6ApwZ/IgwW/xZqRmB4bha8U31eKql7KJaHH16au4jFmf8bW3VzJGYJawweXUdoLDLzjfasBBfSse6QQC1SOtn2CJ1IWWNi8jRQX0Q+Xsvq4/qb9IkoGVSDvuhzBItl/DuE1gTcft0NrNlwxGSeAqawnyH5CoC19/g8Rn/IdBcLlOLuBFOp1WnLhaugW6gDUUp2b3hnLspOflMcgEnWG5sMHR0iLagT2ILDRTNfKCk1uvQ==
X-MS-Office365-Filtering-Correlation-Id: 34653a16-4633-48ca-7c60-08d3d7abac2b
X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2441;
2:74x1J4GsrHXAxkVTOxIJaDVXm7q9wmroOGa7Bje1CJO3qxSQTXaG84LUpuSqBdrYFPjKVKscAQJnXZwaiCifOrrcyu1dMzzc0yuq8EViPH6Oxq/+oBJxnfXnXpOSPogsQIed8PCmaL7+p6bVLCDD07zxltIIiWq8etHiTgKkvHX5aKfnnzIUVZNgg6hTiTyL;
3:bbgRT7SrPRfD/u5zoDlZdBV/qwckIGmhUhIVw5Sl6QBg3daEAhClCxU5Uz+FmTeXKxnoIOfbUp1H5mXROGdPEBWJyHEREvq+HTjwxjxxBBuHf7RRkTNL/jeTEN0MJbWProfE7cOSzrlDEijvwqLFMOfuoVWg7diIXQVAKOeVKkBHZnMuzS58WQ8Y8W5pgLTJ5p++SmZwi16CvQMdyTDwYYQp3Mlp9LS3u8WXPXpzZiI=
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR03MB2441;
X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2441;
25:bWbnlyW7UJgF8g0sO1NmnpCnQauDyApb8pyOwXwfZlNua++0gPgx8BUIisq2cD5orfjseXpYfhUrrsxUGHrQ76DpmXnxj4MWtjrz8ItqdkVqnDeD3NSb3F5rZMq//+OP7OB4HDayEJDGHkieTJm5q17isAAtjTsXQbAQdzkR3je9snn/prUJdR8P7H0K8ehHnYSQbIZrjdjTn18DqQcmFE+FOHtoLpiqTzxb2NFF49J/XDUJ3K2OSke27wfT2vbcyM5hXLDlHOOfyGzMU95pmf4lS1HQ9lwp9gIx6mqSZ/wee76cQlnl2N3Fddk3xPT8ROpHQ7x/yf4VtC802lMzw2Z435ef2MyAkcazAujcwEJ5RwVwxjFXAiKvs5y8ZFt5cZeZC9ACxpV5nzIiKe2n04EoBmkT9IOsbuliXTlhZNuXRKhWmiX9fsl4zJXkAfqPPeQ6vzqdwbu2HG1M4MV5BXguTVsyomO/00eV0Y5tAz+73vCbDNLci5dzN5NG6m+aoY+WQQzCgwSSgXWttLgelPJbsW5GQF6kx/jo3AjLof+NKcmg4gqGt6dGs9YwqRlI7eZA3qXCgT3W8l+7JgNOWLe6y6bqbzytl7Fck4oQwmmcWMZSpMrIQECGtCC8H2Iit4GRXxStI/hsPOIoxecm6aUGW2ajVfNIf5diB+VFM5seQI1h0rsAOyFlfsc20depzu42IUiLtcs3oNkIJHthkxPVZQ0Q0KD+cQe/unkCM6fPMvo0DN9O/ur935LTBXQFzuByD3PjHhDvQGTr4TKiWD2nyHg+ydagE/6KhOY/ekGN2VTo3mAKvu8voUFxB8OC
X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2441;
31:zlMKluxZmX/y+zWtzsnSn3D7/Ha3q5xZsBS4gLW3fkMxn7RQafd4TGMThH+6KdGEWxR8U0b0bzZ4cRxEgF6j3chhDycMm5Imd9QjXmwHx/OjpiXS4C4nwUgtEfTM1afZLPcDtWyL93bdE4HPYfcW+q3EbPglxPDxYkbGkJIPZrQRgcF57vy2umzNVzzaVhbVw9KR5+Q+KkKP4C9lPCfADz40SsIEruIAl1R19eN9/U4=;
4:aS+p1KHV7GdnsBDCaLcHAwfSpzBlXGxaLqGUkiYYCk1+TwQH7yUXCN1Rc/TgGsbvgxAhCNSOBwc5vuKffe88li7rlwY2++ubfMESrIchjZ6xAqOg+QmU0GeJ4ZP2M7UGpqplpniUCiUUUxmly1kV7O+cHedRhDjGrc+qMS2pDdh+PPTnzY0On7a1MB6Y7YF335RVD9NvH1UACDNFzt0vgISnP3J+ebZhesHIOAd+8vMdd+rgYFhp9hfCf2vIGuXYDzCxzcubQD3vgKmZ48MyF39byJ+2nP/xm+NVZ3PA9MfIBrcGN/RkGGfF/U1AoeKvcAsdm+RmciLzq++FH0eX+HTKwjIdMoihQ8oLakRANIQyf64yACNXNhYAb5v3xvUQYBw+nf5hdVznF7TJrmOsOQvI8Z9kDqEpysV/bvC8ypecBF4E8fNQsBSsiK+or6Lt/Fzbm7YDoAVJSR2hInWM87G7Ybyhs/H+jfRAH9sC7h7YmRPCVWv/xsyqwJ7wGS5G
X-Microsoft-Antispam-PRVS: <DM5PR03MB244138B8266CD60CDAB115E390FB0@DM5PR03MB2441.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040176)(601004)(2401047)(13017025)(13015025)(13023025)(13024025)(13018025)(8121501046)(5005006)(10201501046)(3002001)(6055026);
SRVR:DM5PR03MB2441; BCL:0; PCL:0; RULEID:(400006); SRVR:DM5PR03MB2441;
X-Forefront-PRVS: 00594E8DBA
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR03MB2441;
23:IVaa/GjnWR3pErhFNqFYOi/Ik4e89SOSiUMJM?=
=?Windows-1252?Q?txjoQrWFMnY1aU+ByjENlzSx2c7CE9aXSSn1UWbTwSsNbe2QCKacbrRD?=
=?Windows-1252?Q?quRVMYZwrRoqPA2a2qrSrGxxfRd82/thnn8f7nvcNzHboW0Jo7oLHr2y?=
=?Windows-1252?Q?JlfxwbP/tZIRuOylqQ10ksblgu5k4UVSavkVhl2Rf5KPHh1beXLyKPvE?=
=?Windows-1252?Q?VxopDEnufOvL4wkq1g9zc7OoGCtLNQLQrTdsys0ak8ydIbsaCCqc4JrN?=
=?Windows-1252?Q?//94Q2NXgGr7yhTboFoHsaFsIWLRp/QzaC8yboilRkFXw/lLwEAqAtK5?=
=?Windows-1252?Q?B4EZiIOWPHxO1qtmUu49og9nw0g3DuezWLr/daVUPpzehZB3OnbZNgHU?=
=?Windows-1252?Q?oIzOw2Pit1YKF7QHCVg43v3FkQgwkdmq8KHWY2tRAbxa/Iu0lCu3tw/L?=
=?Windows-1252?Q?BlOoyrKwey8Ie12wohRe1Xhx4CDylmeC3AVQFDNUs3haKvoTaq9nHnOZ?=
=?Windows-1252?Q?/Dk5p1IrcXm++KIzlZXSngVGGlK8U//IUzTbLxSjeu86TEB3nN5pj1SX?=
=?Windows-1252?Q?87T24GJldSmM2BJiyiSjbGFDvwxu2BI5DtTXR0DRaCnKGILEzPz9Taif?=
=?Windows-1252?Q?rsUgukWED1fE3Go/oeHi02mQQeAy6Mb6SZUzg0mR4ZhKYKk5RSguFndx?=
=?Windows-1252?Q?eh+BmofGwMcR5ziEeURIbMhF5yaoNTV/3l16mACIRZzOSZxeowEn0Ylt?=
=?Windows-1252?Q?iiSqxK8QQS4H2mSMpLh82mHcd+doX+bdFAcyOOBegs7YEf8rItlKHrr9?=
=?Windows-1252?Q?PYSpbWJ7qo46lbXMZ0ByvYLTGnuCXk9v9uGC2qv4hNZkYtDFEcuolsgn?=
=?Windows-1252?Q?KOAMs0SZRLrXpKkSFS6frugWWkxTlkKFsXPZ/iYCtPm67EqgQP4Ige0m?=
=?Windows-1252?Q?ZfhNWhkW2w1x9imYTb+ezvTHPuwkHwToPcQKzwg0ZnJ4yXmkdcCUSjRo?=
=?Windows-1252?Q?fa2CrpUQxiFboOOowFNl0i9H6q3t5Mrjv2hNgn2zN5QwhN5xWZDyv5Dx?=
=?Windows-1252?Q?r7rRT5XbtfEdHQI7UTzABUEriU1r0UP0kFKR1NgkKJ37Ep1ZtpQPDDOr?=
=?Windows-1252?Q?In6ImxCm1R0DpnVOD5dt7YzVNhFyi//NbdCxK0Ikt7RRWN1X36gsKP+A?=
=?Windows-1252?Q?V0F5rgSgBj3ksuALcB3UzOa9Ud2i+AMKT53SSsIzhR9tGCXytQaZxF29?=
=?Windows-1252?Q?Cwtx9O5FgSqWBUDXePi4YQd75ma5AQxNuHcgOsb41oWxBhhAt4M88XQC?=
=?Windows-1252?Q?brQGpo8Nbcb7teXr60AFkZW8oMNBxrPzjrIrg8Cd5Q/dWqanaHNF1s6F?=
=?Windows-1252?Q?7hEIIWJhlnwOIz9Nx5MNH7nVqx3aCJoHmM2UbXqhzz3VYRDASmD1m1tA?=
=?Windows-1252?Q?HcJ9C7GPOUX0ECPQhdzUVKNZ5zanmlyJIQR73BKvX+OaYDiwfAO0EHRC?=
=?Windows-1252?Q?9pW6eOWrQMi3k0FcEmLMICuw9arYrHDyokr9CZ2bG+iDxnCodKKQg3NG?=
=?Windows-1252?Q?d/2wkiM9/snVIMMn28B2LapCUHHusbdlkNO5OzM/fXl2Un5qyqmvLNTU?=
=?Windows-1252?Q?kZ6lh8BEUIVcE9e2OP83hCDMemjzzul7tg0CjuqsHzDKpj8UkZKX9w/0?=
=?Windows-1252?Q?eBsoXq5LCCgtXJwuyLm/BvctzJ9buc=3D?=
X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2441;
6:wHXEvJqbC9RjEdzXdDxA950dhl88E+59wWPtXlTup+1aoDEXiZ+T+mk9tmM0SJNJ8TZXvDOlQsrUfB2jMehZV850dISu8UmktnK5Fg1Tr++jlcdv+4yRBa8s9eOzRo9gY+VXS5jbHr0WNzb/fF5b9fMB4d02oHyjmeYrTx0sT4ZHJTvNUqHRmtCiboQBE1XDDBwUHWPk7fmG0ZG0XalHhDg+ttK4gYUOa0f/oCXfRtfTemeqkX+kpN6DW6xG9FgiH6ZByWdY2xaEuitpAy7Y5VAb8w7rbfyHYKJpdCeFw2s=;
5:cfTZF64p6PDmlaKP1Jfue6mziXGat9Y81Irq873QerBJWq6xIblLs9kjP9PbYvv7N9d6zHM1WWqd0qaEETThg3IB2/BExdCbtOrZO+fOzmQbhaYBnnm/JD+4Cy+OL9CI0BpbiEF1ohRuZ/1SKrJfwlUn0svs5Sg6K3HH+6AJp1c=;
24:62DoiT28l1PeqnizuYp1wCCq6wZRQXv+X3VJt4S7Jhaxcr8Wj33qfXrP9xieZpZY51ES31EMpwf1kSaOZzyx4L9PkIhUevD9+KRwJWSUm7I=;
7:QgQlQdgoXyL9SXlosVmJiwjFEF6TWIMzDLYYQnBxHCuu8QVEPkVLfTTLvGDzh+sl6Gd7hRyNQs1FPDNYYiF1Thp2NMbBEo2pNTgMmNRS5NMg0p52GsBOeVF62nx+gNdYcRI4kT2BLm+r/ZdyOJkQkYias+6tDcTelilkOa/hcjL77M6ZoJpy/sEoHLd5vIBrzd3WCgk6ffUq8b3xTHk2WaaMBKKVy/GcifilKSj8jv364B5+ZAlTUzOV7su7rTMt
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2016 05:47:51.2758 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50];
Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2441
Subject: Re: [dpdk-dev] [PATCH v8 10/25] eal/pci: Helpers for device name
parsing/update
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Sep 2016 05:47:54 -0000
Hi Reshma,
On Tuesday 30 August 2016 10:04 PM, Pattan, Reshma wrote:
> Hi,
>
>> +/**
>> + * Utility function to write a pci device name, this device name can
>> +later be
>> + * used to retrieve the corresponding rte_pci_addr using
>> +eal_parse_pci_*
>> + * BDF helpers.
>> + *
>> + * @param addr
>> + * The PCI Bus-Device-Function address
>> + * @param output
>> + * The output buffer string
>> + * @param size
>> + * The output buffer size
>> + * @return
>> + * 0 on success, negative on error.
>> + */
>
> This function doesn't have any return value. Need to change the @return description.
>
>> +static inline void
>> +rte_eal_pci_device_name(const struct rte_pci_addr *addr,
>> + char *output, size_t size)
>> +{
>> + RTE_VERIFY(size >= PCI_PRI_STR_SIZE);
>> + RTE_VERIFY(snprintf(output, size, PCI_PRI_FMT,
>> + addr->domain, addr->bus,
>> + addr->devid, addr->function) >= 0); }
>> +
>
> Thanks,
> Reshma
>
Updated the comment in v9 [1].
[1] http://dpdk.org/ml/archives/dev/2016-September/046266.html
-
Shreyansh