From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52C33A0513; Wed, 15 Jan 2020 15:02:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F4DA1C045; Wed, 15 Jan 2020 15:02:50 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 16D5C1C020 for ; Wed, 15 Jan 2020 15:02:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579096967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ClrI/saHItAoP6XdwLX2WUfpBxk6hFocEZs34UlJpMk=; b=HG/aUpKlanYvVjXfWXc4NHygpZYXcmnJNCGSXVo516oGYbDoeq9ijYIw0EtEPOKj7YA4Ui gJDheiGjVVM4F1r7/iPEG9DLQotbaR6R4eyXp0RlTnzEiVV1kGgDk9e7/LTdij8gu/VjCg YHoktFReFN2z62vtaHsgbKXVDJ6y/0A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-rSW603v8PzS8mvci2HO37Q-1; Wed, 15 Jan 2020 09:02:43 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8266010054E3; Wed, 15 Jan 2020 14:02:41 +0000 (UTC) Received: from [10.33.36.27] (unknown [10.33.36.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8259D5C28C; Wed, 15 Jan 2020 14:02:39 +0000 (UTC) To: Ferruh Yigit , Rasesh Mody , Jerin Jacob , dpdk stable Cc: dpdk-dev , Jerin Jacob Kollanukkaran , GR-Everest-DPDK-Dev , Luca Boccassi References: <20191221014146.29795-1-rmody@marvell.com> <907f9f62-f492-3fbf-22cb-d1fc654037b7@redhat.com> <1fd17543-28e3-7fca-3052-047753345f70@intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <90c341bf-1795-0088-d5d2-001ce504e858@redhat.com> Date: Wed, 15 Jan 2020 14:02:38 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1fd17543-28e3-7fca-3052-047753345f70@intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: rSW603v8PzS8mvci2HO37Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15/01/2020 13:11, Ferruh Yigit wrote: > On 1/15/2020 12:57 PM, Kevin Traynor wrote: >> On 15/01/2020 12:47, Ferruh Yigit wrote: >>> On 1/15/2020 10:58 AM, Kevin Traynor wrote: >>>> On 14/01/2020 19:51, Rasesh Mody wrote: >>>>> Hi Kevin, >>>>> >>>>>> From: Kevin Traynor >>>>>> Sent: Tuesday, January 14, 2020 10:52 AM >>>>>> >>>>>> On 14/01/2020 04:51, Jerin Jacob wrote: >>>>>>> On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody >>>>>> wrote: >>>>>>>> >>>>>>>> Skip the device re-initialization for secondary process. >>>>>>>> >>>>>>>> Cc: stable@dpdk.com >>>>>>> >>>>>>> Correct Cc: to stable@dpdk.org >>>>>>> >>>>>> >>>>>> Is it a fix, or secondary process was not intended to be supported p= reviously? >>>>>> If it is a fix, please provide the Fixed commit (will save Ferruh se= arching for it). >>>>> >>>>> Secondary process was not intended to be supported previously. So it = is ok to not backport the change to all ongoing stable releases. >>>> >>>> Thanks for confirming. >>>> >>>>> However, the change has been tested with DPDK 19.11, I am wondering i= f it can be pulled in that stable tree. >>>> >>>> Cc Luca >>>> >>>>> Please see below the fixline tag. >>>>> >>>>> Fixes: 540a211084a7 ("bnx2x: driver core") >>>>> >>>> >>>> Fixes tag won't be needed now as you've confirmed the code was doing >>>> what it was intending to do. >>> >>> Since there is a request to backport this into 19.11, I was planning to= add the >>> fixes tag (stable tag is already there) but will it confuse the 18.11 b= ecause >>> the commit in fixes line is older than 18.11? >>> >> >> I think it should not have a Fixes tag. In this case there is nothing >> being fixed, just a new feature being added/supported. It will be picked >> up as a candidate for stable branches through the cc: stable, from there >> it can be discussed. >=20 > OK, I am not changing anything. > But when fixes tag is missing I am not clear how you decide if the fix sh= ould go > into any specific LTS or not, it should be hard to figure it out without > reference point. >=20 Yes, you are correct, for bugfixes it is important because otherwise stable maintainer have to stop, try to figure it out and start email convo with authors to discuss etc. Whereas with Fixes tags, non-relevant ones for a branch can pruned out quickly and discussion is not needed. In this case however, where it's not really a bugfix but more a request to add/support something new, it probably needs discussion anyway and not having the Fixes tag ensures that takes place and it doesn't automatically slip in unnoticed. >> >>>> >>>>> Thanks! >>>>> -Rasesh >>>>>> >>>>>>> Applied to dpdk-next-net-mrvl/master. Thanks >>>>>>> >>>>>>> >>>>>>>> Signed-off-by: Rasesh Mody >>>>>>> >>>>>>>> --- >>>>>>>> drivers/net/bnx2x/bnx2x_ethdev.c | 5 +++++ >>>>>>>> 1 file changed, 5 insertions(+) >>>>>>>> >>>>>>>> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c >>>>>>>> b/drivers/net/bnx2x/bnx2x_ethdev.c >>>>>>>> index 20b045ff87..7864b5b80a 100644 >>>>>>>> --- a/drivers/net/bnx2x/bnx2x_ethdev.c >>>>>>>> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c >>>>>>>> @@ -598,6 +598,11 @@ bnx2x_common_dev_init(struct rte_eth_dev >>>>>>>> *eth_dev, int is_vf) >>>>>>>> >>>>>>>> eth_dev->dev_ops =3D is_vf ? &bnx2xvf_eth_dev_ops : >>>>>>>> &bnx2x_eth_dev_ops; >>>>>>>> >>>>>>>> + if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) { >>>>>>>> + PMD_DRV_LOG(ERR, sc, "Skipping device init from se= condary >>>>>> process"); >>>>>>>> + return 0; >>>>>>>> + } >>>>>>>> + >>>>>>>> rte_eth_copy_pci_info(eth_dev, pci_dev); >>>>>>>> >>>>>>>> sc->pcie_bus =3D pci_dev->addr.bus; >>>>>>>> -- >>>>>>>> 2.18.0 >>>>>>>> >>>>>>> >>>>> >>>>> >>>> >>> >> >=20