From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address
Date: Wed, 9 May 2018 17:59:14 +0530 [thread overview]
Message-ID: <90cd576c-93f6-6398-95bd-e51e02ad0f40@nxp.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CD050B2@IRSMSX108.ger.corp.intel.com>
On Wednesday 09 May 2018 05:00 PM, De Lara Guarch, Pablo wrote:
> Hi,
>
>> -----Original Message-----
>> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
>> Sent: Wednesday, May 9, 2018 12:40 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Cc: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; Hemant Agrawal
>> <hemant.agrawal@nxp.com>
>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for
>> fle address
>>
>> On Wednesday 09 May 2018 03:54 PM, De Lara Guarch, Pablo wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>>>> Sent: Wednesday, May 9, 2018 10:14 AM
>>>> To: Shreyansh Jain <shreyansh.jain@nxp.com>; De Lara Guarch, Pablo
>>>> <pablo.de.lara.guarch@intel.com>
>>>> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal
>>>> <hemant.agrawal@nxp.com>
>>>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova
>>>> conversion for fle address
>>>>
>>>> On 5/9/2018 2:56 PM, Shreyansh Jain wrote:
>>>>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>>
>>>>> fle is already in virtual addressing mode - no need to perform
>>>>> address conversion for it.
>>>>>
>>>>> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
>>>>> Cc: akhil.goyal@nxp.com
>>>>>
>>>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>
>>> ...
>>>
>>>>>
>>>> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>>>
>>> Added Cc: stable@dpdk.org (try remembering this for next time, please).
>>
>> Thanks for doing it this time. I'll take care of this next time.
>
> No worries. Actually, gcc 32 bits is broken:
>
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1264:7:
> error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));
>
> Is this PMD supposed to be compatible for 32-bit targets?
Oh! This is bad. I will send you an update on this in a few minutes.
Ideally, the code was written for 64bit in mind - though, it should
still be able to work (at least compile) for 32 bit.
>
> Thanks,
> Pablo
>
>>
>>>
>>> Applied to dpdk-next-crypto.
>>> Thanks,
>>>
>>> Pablo
>>>
>
next prev parent reply other threads:[~2018-05-09 12:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 9:26 Shreyansh Jain
2018-05-09 9:14 ` Akhil Goyal
2018-05-09 10:24 ` De Lara Guarch, Pablo
2018-05-09 11:39 ` Shreyansh Jain
2018-05-09 11:30 ` De Lara Guarch, Pablo
2018-05-09 12:29 ` Shreyansh Jain [this message]
2018-05-09 12:46 ` Shreyansh Jain
2018-05-09 12:43 ` [dpdk-dev] [PATCH v2] " Shreyansh Jain
2018-05-09 14:35 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90cd576c-93f6-6398-95bd-e51e02ad0f40@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).