From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0050.outbound.protection.outlook.com [104.47.0.50]) by dpdk.org (Postfix) with ESMTP id 484381B16B for ; Wed, 9 May 2018 14:12:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eonej0BM1q93r2lB53/tRBFYVLEc3xiHvxNEvuPX2CI=; b=j7OLa+Dx4uy+F+1vCzjw/iav1fxyII5r+QmvLjw/7ZL2A8rUau0aeRbg52BEk9Wf5bfr+eiTNRM9Px0/Q0oMUTOn/N0ds+12gi33HK5e2RAACAE7N8Bz64Q4ufikolpYixAPfMPKC7eruN3SIpvYUHNEzvaFbULk++5f1ETHirI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by HE1PR0402MB2780.eurprd04.prod.outlook.com (2603:10a6:3:d4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Wed, 9 May 2018 12:12:38 +0000 To: "De Lara Guarch, Pablo" Cc: Akhil Goyal , "dev@dpdk.org" , Hemant Agrawal References: <20180509092642.9092-1-shreyansh.jain@nxp.com> From: Shreyansh Jain Message-ID: <90cd576c-93f6-6398-95bd-e51e02ad0f40@nxp.com> Date: Wed, 9 May 2018 17:59:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR01CA0094.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::34) To HE1PR0402MB2780.eurprd04.prod.outlook.com (2603:10a6:3:d4::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2780; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 3:D74NUElCWCBgIYxu/2+VkZPxMDsDtgaTi52Odz6GkNEzdWmatxEwdEtNsOmtAxaDj0+xYNAt6/NAxzWgqaFEBapWiR76SZrzpPIVlLpDuGGmTnJQsy6c0FUYICNKliAT1BjmRU43KfbWcYonPIDQ83LqFW5y9yJOr8/YM1pHUnz7KEJbKzATdK2TAwXYJnOjbHrx0P+ldW+mBrlZqBWchuy5lmpHOW3sCpn/3UycD1c/Hdgen1BZ/4s8ku15Jeje; 25:70KXSmPNaJ/igYut+uHG1lqMy0Z6Tc/VIX2oxUt7RVndLvFeKvj+vU5rXdlfdsve+dGVSjxg+6mflIUiGT37qrL4iwVDcTWxnB3d30zUZM7xn5/p1usenjqAfy0ARGM0h/2BMqR/zL0SGniV1morAYb+dygBiTZMKoNbedJrKcM8f4rjonXKnoOU5A8pVsuDNqeTxtmVQyw97q9kh+3i0UPoYdNUFapnN0eM7fYRXVFNCwuInUXB4E+OFoWrV6QTp/8BatmBPKF52v6r5HYsw02q57njhlPMm36phl2lY2hN5ITlRUXSnHnYDUQPhp7T90V4iVkrbCQLO3f6mhSITg==; 31:FV0EzrF28vK99CNcJ80Y2WeWWnHiHFwSpXxyZXfRyJbPzSL6MZwAJDG5S4yITO7Eq8hh/K0q7dhJg7xVBwtyoEUZ+t2bf+ZKJWsquB1fh165t2EJaW06RxUOmdLONofvlG3f8I+LdWRWlS+JbYTZ6Mbu6GqNabhQ2A1kufqvqnbI8UDVjLEkejv9CW9PGWJD4aP5r8erIc2jGKPGsuYclCvpFNWhHddvV/mIxmKltgY= X-MS-TrafficTypeDiagnostic: HE1PR0402MB2780: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 20:4wXxnEtyTH1SYlGGUpQWHwL8XtYkrNdTkO3a59k8CnE6Q+2pApr/wxXsdlQLTKPJ7s33wcN+yptPVIJ9vexqezRrqTbmuQIvOq+s1ws8IBSZhfuetN+k+okrcUHKBl+Q0jXPFBz/zr9BWLqgCOmSOwfveWVqSP10eEaE/J+ZYLBfC22hyD3y4v0OWVVlLYNjZ4RrD0pGwOk5OIrAr0D9sqnKC4Co9Ir2uBPdvxK0mYmWZKwsAZpxeTMsTGeLkI2295oNGT2VNn1QL7pYtpYaE/Mp0IpSJ3SrYTgg88Gc12aq2EGeAN5Er4mea/W6D4Na8B6+AjpazQ8Gt9ng0aw0Fu+0p8fBuyYuXGFSf+j0e4rEVjqseUdiX4WxkPGlm3cTGjHHTsMiqBOF5Gdt3pkJ0z7Gr+9NDpCUvCgxXnGlh3NnAZDbF6QRd1Wb5AdZB8GoUD0X9oseQX+gi3Je8FezhcSbkguG1KZhJWxhleJyVL0BhNtyyWyN+WgOnVgq0oLa; 4:rQA/aWrC+++TReaFvhhj5f9/qM0c8Jj1NPDsqSWVJsajw+ojhTlbzPKRJ/kQpuuXZiBBMBy9Y06PgUlEJ74PATlJ0rgUGlzMREcCM/r9hsgmi2kjocinWuxjd3CM72ztJVTe92Z3dEDIRIY0lAF6GaDyggEeu9J4/RDEF8C94T0ezi6BYzXaC+/P94mwzsNH3B33I1wZ8W1Fd8Gavb/Q8NSeSFYay1ydg5haMj3KoZlkz92hySRSV9Ben1JqKPAJ5uyKPUEDYHFeSSwneLZKOozVJahHfXHwEfozUy3wU0baWl/sVqB3o6AFjqw5fIM8o/02FFFQIgCRJnLikqxqYllr5fz4xGxr39Me2ptuZkY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0402MB2780; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2780; X-Forefront-PRVS: 0667289FF8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(376002)(366004)(39860400002)(39380400002)(396003)(346002)(13464003)(43544003)(189003)(199004)(305945005)(25786009)(106356001)(105586002)(230700001)(5009440100003)(36756003)(6246003)(97736004)(50466002)(2906002)(66066001)(65956001)(47776003)(65806001)(31686004)(64126003)(4326008)(53936002)(65826007)(58126008)(54906003)(52116002)(386003)(76176011)(53546011)(59450400001)(16576012)(316002)(5660300001)(6486002)(68736007)(93886005)(67846002)(6916009)(6666003)(31696002)(446003)(478600001)(16526019)(11346002)(23676004)(52146003)(2486003)(476003)(44832011)(2616005)(486006)(956004)(8676002)(3846002)(6116002)(229853002)(8936002)(7736002)(81166006)(81156014)(26005)(86362001)(77096007)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2780; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA0MDJNQjI3ODA7MjM6MUZtMnpNaXdJd2NGeWtvU3NERTR1cTRZ?= =?utf-8?B?dkxJVVNsS0h4ZUFOSnN1WFVNc2NPTFZMNkRBam1mRzVDT0NCZnVuVHZJNXpx?= =?utf-8?B?ZlVRS3JhL09pbFhUV1IzVXhSU3hESmg3NXhWUVRtUEVVOFkzWFpWMUlCdnJX?= =?utf-8?B?cUFod1NHYWt5Z1pjSnN0ZnB3RTlRQVdZZm5FTXlnUzhDUy9teFFIY0I0N0ta?= =?utf-8?B?a2M1a1FDNjBoQkdHVzFFN3lBenQwd3dHK2dJSExYZm9ZOVRrc3FjR1N2bWMw?= =?utf-8?B?NjFqcnc1bXBaVlgyM0FqZzVhMkJHNzhERzdBeGRGbTNNZEZCUUtPUExCN3Fp?= =?utf-8?B?d002Q2phbXkvTlFZYzJpQStXSWpXVEJOcUY5ejBId2pFTGdPU29GemIyN1Bh?= =?utf-8?B?dmY5VTF5Si9jSU9UcU45d0packI1UURPOEd3MDV1SG93ZnlnaWJqRWxGRE56?= =?utf-8?B?RXFocGQydzBkOXNZOU9RTXRLclBvdzh5c0Z1MFJEbWtCVjd2WGtpMVczYmhT?= =?utf-8?B?dWxyQzhoNXpOM2xRL2R3Wm5UZ215SjdEZU9sc2I2VUM2UUVVQ2g2aUJ2QlpZ?= =?utf-8?B?WlM5VXo4Yld6RzJwUS93RWw1VGtZK1FuTXM5c2szbExJOWo3MDg2ZDJQT1ZS?= =?utf-8?B?TXZBRC9vTXRVb2lQTnBwQzlsNWpyZGZoQi9rc2RsV3FSM3k4Rm5pNnNQSHdR?= =?utf-8?B?UXh6V3dML1R2bG9FcXp2cGt6THFLdDFRa1M2TkhNb3kxMTg3RThaNWVkbThJ?= =?utf-8?B?YjlzODl1ZjBzenNEOVliVitMMHNGRVhTSkU2M2c0akVhUUFra3ZiYjlySjJ3?= =?utf-8?B?UU1lNGtpKys0UzNXUXoxQmNDOUk5Zkt3QnVlSndDOEM0NkdjR1FhdXpkQU9t?= =?utf-8?B?K1lKcDdUaGw5UzJnUDNGUDJBU1V5OGpEYVlZQjYvUGw3ZDNsY3pxUE5zQlIr?= =?utf-8?B?S2dsR2o4SFpOVmVmb2xXRFFDTDVVSzVuVURaRFZneFNpamIyMXNhSUFJaUto?= =?utf-8?B?Q3Y2WXhJZlZEWW9SYUJ6TXFWeFBJUUdxN0p6ZUVrek0vRG83bWFkOWRiVzFr?= =?utf-8?B?TDNQR2Y0WXVmRlBiVTU3S09ReFVqdjh4ZmFIYjFYQ092RjByaWpWeXNaeWND?= =?utf-8?B?eTJuZjE5ZTVVT094YXJ6M0VQcHFPQ0pvQ1VUS2x0UUp1akhRSXZBdW03NUtG?= =?utf-8?B?VTNkVFg4Y1VYUEVSTVd5U080bWR5NHljWEhiQm1yV2NZSWE4WEtkMnZLejh1?= =?utf-8?B?OVJSNmM2Vjh2aXVYZ2F5K2ZNa0lRcHNjSlNKbHNieDdmQVJ5RXo4dHdnRE5u?= =?utf-8?B?NXR3UitIdWE2SmdUcHhsa2IxWTl0QTVkcWkwc3I5MGw5WlFmNFpXVU1OTjR2?= =?utf-8?B?S2dhamh4VW9ORk14WER3T3ZJc3FNVUpHVWdpbmhtSWhpSUxJL0o0WUo1WENN?= =?utf-8?B?MDhPUWJHQW9aaDkxZ1F1VXpGN3R6WWh5MHJGSXNhQmNTUzJ6V202MGdMY1Fh?= =?utf-8?B?b2M2M3VDeVp0eWJJWWNVNXZWWThUcXNHeTNYdDVBY3A3ak9la0FETlVZSllv?= =?utf-8?B?d3ozVVVqOWt1Q1F6eEJKUU82QlNZWEExejdPTjJ4blVBNVMvWTZzcG02czJ3?= =?utf-8?B?dkRwZEZpUDQ1TUp1T3BMNXZ5c094NXJhTXBjR3FVQTlabUY0azgwTDFZTDc5?= =?utf-8?B?QTZKMGNWY1lCZ1NRd0o0VytNelEza29ZWUVxSm1aRm84V3pSV29TanBTbDEw?= =?utf-8?B?YVlxb0gySnIvS29HbVhTMmRCbHhZS0RocHIzZERJOU91dnYxeVV5TnFFNmVv?= =?utf-8?B?eXdDRUs2UVE3Z3JpYnM0ZnY2ZGN6TTRqRUdSNEswLzVWajFKRWhFMlNINkgv?= =?utf-8?B?M0pHQWQwQlExU2VlWFh5V01sTlJhdkJCa3dMSUlXRXJJbHVxOExYM2gzcE8z?= =?utf-8?B?VXFNWFpOVkRJbm1RTGdZaXpNaW9NOEtxMVhpMk94UEFPaUVpMTBhMDNha1Jq?= =?utf-8?B?V1RmWTNESEc2L0MzekFpazFOWnZ2QmZUNHFPYS9JaUluVVYvNnZ0VGtXSFd4?= =?utf-8?B?d2d5Z1VkTWVtSXV1TWM3Rmk5NER4Y1V6cERhYzlWc3R1SzFCVXlFTjQrTGow?= =?utf-8?B?Nm5yQy94a1FDSWk2SVhaMDZLQURsZlBiaXFKUURxT3NRNEtnKy92NkIrZi90?= =?utf-8?B?Z2M5VUF6bkErc1UzR2dsUTJnQ3pQaUE9PQ==?= X-Microsoft-Antispam-Message-Info: sY4S1a3h4rSZBbXI5q6f5Bw0hVpyHFRazUhGpb9S2iZi/9LRdEIZOx2meFQ4S8gpzopjmfuJry3q8LPoyObAO6tPjk+C7dg+3p/r691NHsaXq2XwBgjRo2/GmDyk9+ZkgJw4je3dTibJ1MPTytM0XcCFpM6SMKtYnWAGS24giLChjHU9gbq2qX2FA81JUiXt X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 6:s8WhSXHT4V5MhHbiRdJOGatB59YmG4xiIT5U9urwBV4VQ0WCrXlXTdfT5Og2L8CAncpbfOEkeBosrYxFFxegg47VW2tsOqrLVoNC6HODw7kq1H9KiH9qkIa7MRvy/c3CDxDuJFKZU1mai6ncnHuhfwseWnZRs8hauYGVCZ5KvWf1n4GEbYJmhLdvWV3r6xrdVAnsh3sq6EuofqH85yRbLUqbWe/UttM9QlzA1SQ9V/8KstYB8KFcpEFEeNlTWDPObpavuFR4SIfV/XhMRbvZ/bLgBQT83ZFQ6fIqa000sUJPeFub86zdiJkBfkPqZSdCAUuM0Hm3tBa8ojsWyy+5wIltWatkZXWkFH1Jge5zwikzC3+W+MD/j8jOMbBDLezpBqCYzELKdzGaCy46e04XWmd/PAaHL7itKF5PqjCX3x+5DDmyZkWOGDzw+8hC+/LPsIlzp6tbJqCp2GQj40jYww==; 5:Ch1Ql5N2os6IV7wuUT0jYduJt6ZJi5pYkmr2LQmjy2/jN7k3FVZNzIcbuvP0z76Ur5BiJiTz/exo5sJwRWSQJq+I4k685mRKQRbOINH5xeWwZMSpxiCRhJQZJxaLHRAU/yECbgp1jwQ21B6F4Vf2+7vJBQTsP8yxqT/1llaAM2U=; 24:MjGyK4vEZrZAAcNfz/jWZD6UMFykKvwN3BzN+qHN2HBgBPwUQlvk0oRln5ZDazY6Qv0zRWv7lxHkry0fMqSEZAMUSXcy7V06E0rMIYsaCbI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 7:W9FS/KbA53p4bNfgh9faRgjhVsL4u2TKpJ6nG3mAwlt9g/oXpYi8jc5aHbYOsWaBtTmgE/VtYIlW5pmAELa6WwhePWyrcTkylE28XZ0HGWRyCGm8JwbK5dbcMGN2VIF6ADFIDWoaVW6r+apsMa7gP/6zHOaiRogNHptzBLPQHY3aNhBOFxeJiqSYZM6oO5U8VsFsM++AxwpGxXbKkYcHBIC3sq0/FxgWYs0/Wp/mZGm1vO7SqH1pa8mCkPFljBeg X-MS-Office365-Filtering-Correlation-Id: 9457c7dd-aa28-4db8-e117-08d5b5a628db X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2018 12:12:38.7490 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9457c7dd-aa28-4db8-e117-08d5b5a628db X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2780 Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 12:12:41 -0000 On Wednesday 09 May 2018 05:00 PM, De Lara Guarch, Pablo wrote: > Hi, > >> -----Original Message----- >> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com] >> Sent: Wednesday, May 9, 2018 12:40 PM >> To: De Lara Guarch, Pablo >> Cc: Akhil Goyal ; dev@dpdk.org; Hemant Agrawal >> >> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for >> fle address >> >> On Wednesday 09 May 2018 03:54 PM, De Lara Guarch, Pablo wrote: >>> >>> >>>> -----Original Message----- >>>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >>>> Sent: Wednesday, May 9, 2018 10:14 AM >>>> To: Shreyansh Jain ; De Lara Guarch, Pablo >>>> >>>> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal >>>> >>>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova >>>> conversion for fle address >>>> >>>> On 5/9/2018 2:56 PM, Shreyansh Jain wrote: >>>>> From: Hemant Agrawal >>>>> >>>>> fle is already in virtual addressing mode - no need to perform >>>>> address conversion for it. >>>>> >>>>> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") >>>>> Cc: akhil.goyal@nxp.com >>>>> >>>>> Signed-off-by: Hemant Agrawal >>> >>> ... >>> >>>>> >>>> Acked-by: Akhil Goyal >>> >>> Added Cc: stable@dpdk.org (try remembering this for next time, please). >> >> Thanks for doing it this time. I'll take care of this next time. > > No worries. Actually, gcc 32 bits is broken: > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1264:7: > error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] > op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1)); > > Is this PMD supposed to be compatible for 32-bit targets? Oh! This is bad. I will send you an update on this in a few minutes. Ideally, the code was written for 64bit in mind - though, it should still be able to work (at least compile) for 32 bit. > > Thanks, > Pablo > >> >>> >>> Applied to dpdk-next-crypto. >>> Thanks, >>> >>> Pablo >>> >