From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CF6B1A034F;
	Sat,  9 Oct 2021 03:29:24 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5913A40142;
	Sat,  9 Oct 2021 03:29:24 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 47C1A40042
 for <dev@dpdk.org>; Sat,  9 Oct 2021 03:29:22 +0200 (CEST)
Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HR6ml1QbMzbn1Z;
 Sat,  9 Oct 2021 09:24:55 +0800 (CST)
Received: from dggema767-chm.china.huawei.com (10.1.198.209) by
 dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id
 15.1.2308.8; Sat, 9 Oct 2021 09:29:14 +0800
Received: from [10.67.103.231] (10.67.103.231) by
 dggema767-chm.china.huawei.com (10.1.198.209) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.2308.8; Sat, 9 Oct 2021 09:29:13 +0800
Message-ID: <90eacc43-1de2-d660-acaf-621be9c00ed6@huawei.com>
Date: Sat, 9 Oct 2021 09:29:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
To: Thomas Monjalon <thomas@monjalon.net>
CC: <dev@dpdk.org>, <ferruh.yigit@intel.com>, <aman.deep.singh@intel.com>,
 <andrew.rybchenko@oktetlabs.ru>, <anatoly.burakov@intel.com>
References: <1627908397-51565-1-git-send-email-lihuisong@huawei.com>
 <20211008082114.22468-1-lihuisong@huawei.com> <1723716.XTA6elxnGa@thomas>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <1723716.XTA6elxnGa@thomas>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 dggema767-chm.china.huawei.com (10.1.198.209)
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix eth device released repeatedly
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


在 2021/10/8 18:23, Thomas Monjalon 写道:
> 08/10/2021 10:21, Huisong Li:
>> In secondary process, because it doesn't clear eth_dev->data, the "eth_dev"
>> above will not be NULL when rte_eth_dev_close() has been called before this
>> interface is called. In this case, Ethernet device will be released
>> repeatedly. The state of the Ethernet device is equal to RTE_ETH_DEV_UNUSED
>> after calling rte_eth_dev_close(). Using this state resolves problem.
> Sorry I have difficulties to understand.
> The use of "it" everywhere doesn't help.
> You should name things instead of refering to "it".
ok. I will fix it. Thanks.
>> Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names")
> For sure that's not the root cause.
>
>
>
> .