From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8F7E31D104 for ; Fri, 6 Apr 2018 15:47:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2018 06:47:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,415,1517904000"; d="scan'208";a="44000365" Received: from awalabdu-mobl.ger.corp.intel.com (HELO [163.33.228.156]) ([163.33.228.156]) by fmsmga004.fm.intel.com with ESMTP; 06 Apr 2018 06:47:17 -0700 To: Thomas Monjalon , Declan Doherty Cc: dev@dpdk.org, Alex Rosenbaum , Ferruh Yigit , Shahaf Shuler , Qi Zhang , Alejandro Lucero , Andrew Rybchenko , Remy Horton , John McNamara , Rony Efraim , Jingjing Wu , Wenzhuo Lu , Yuanhan Liu , Bruce Richardson References: <20180405135148.16388-1-declan.doherty@intel.com> <20180405135148.16388-5-declan.doherty@intel.com> <2392634.y0Dprd7BRi@xps> From: Mohammad Abdul Awal Message-ID: <90f813f1-6306-e6ed-26ea-4f0931bdebaf@intel.com> Date: Fri, 6 Apr 2018 14:47:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2392634.y0Dprd7BRi@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 13:47:22 -0000 On 05/04/2018 17:49, Thomas Monjalon wrote: > 05/04/2018 15:51, Declan Doherty: >> +struct rte_flow_item_metadata { >> + uint32_t id; /**< field identifier */ >> + uint32_t size; /**< field size */ >> + uint8_t bytes[]; /**< field value */ >> +}; > Spotted C99 syntax of flexible array. > Are we OK with all supported compilers? > Used "uint8_t *bytes;" instead of "uint8_t bytes[];"