From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF728A04BB; Tue, 6 Oct 2020 13:03:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A0F1F64; Tue, 6 Oct 2020 13:03:00 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5F69DA3 for ; Tue, 6 Oct 2020 13:02:57 +0200 (CEST) IronPort-SDR: lrm4Ve5Sz4Oi2HcNzvpuRG3ldiS4baCYiR3dza7mVRz9G/5vtDwDuj51jYovwo6SXGVY1Qd8OW V0mDJ2p3hJgg== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="226045819" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="226045819" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 04:02:55 -0700 IronPort-SDR: fbq0EC2uUW70PzIgy0lKkgwB132mQYYWTkOIuH/HySSJeaG3/uPNM1Z6dausnOJeycUyXkyfZ5 +YWOaiFlR6Bg== X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="342194989" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.102]) ([10.213.241.102]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 04:02:54 -0700 To: Jiawen Wu , dev@dpdk.org References: <20201005120910.189343-1-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: <9111b3e0-45b7-922f-00d6-08ac0fbeedd7@intel.com> Date: Tue, 6 Oct 2020 12:02:51 +0100 MIME-Version: 1.0 In-Reply-To: <20201005120910.189343-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 00/56] net: txgbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/5/2020 1:08 PM, Jiawen Wu wrote: > v2: re-order patches and fix some known problems > v1: introduce txgbe PMD > > jiawenwu (56): > net/txgbe: add build and doc infrastructure > net/txgbe: add ethdev probe and remove > net/txgbe: add device init and uninit > net/txgbe: add error types and registers > net/txgbe: add mac type and bus lan id > net/txgbe: add HW infrastructure and dummy function > net/txgbe: add EEPROM functions > net/txgbe: add HW init and reset operation > net/txgbe: add PHY init > net/txgbe: add module identify > net/txgbe: add PHY reset > net/txgbe: add info get operation > net/txgbe: add interrupt operation > net/txgbe: add device configure operation > net/txgbe: add link status change > net/txgbe: add multi-speed link setup > net/txgbe: add autoc read and write > net/txgbe: add MAC address operations > net/txgbe: add unicast hash bitmap > net/txgbe: add RX and TX init > net/txgbe: add RX and TX queues setup and release > net/txgbe: add RX and TX start and stop > net/txgbe: add packet type > net/txgbe: fill simple transmit function > net/txgbe: fill transmit function with hardware offload > net/txgbe: fill TX prepare funtion > net/txgbe: fill receive functions > net/txgbe: add device start operation > net/txgbe: add RX and TX data path start and stop > net/txgbe: add device stop and close operations > net/txgbe: support RX interrupt > net/txgbe: add RX and TX queue info get > net/txgbe: add device stats get > net/txgbe: add device xstats get > net/txgbe: add queue stats mapping > net/txgbe: add VLAN handle support > net/txgbe: add SWFW semaphore and lock > net/txgbe: add PF module init and uninit for SRIOV > net/txgbe: add process mailbox operation > net/txgbe: add PF module configure for SRIOV > net/txgbe: add VMDq configure > net/txgbe: add RSS support > net/txgbe: add DCB support > net/txgbe: add flow control support > net/txgbe: add FC auto negotiation support > net/txgbe: add priority flow control support > net/txgbe: add device promiscuous and allmulticast mode > net/txgbe: add MTU set operation > net/txgbe: add FW version get operation > net/txgbe: add EEPROM info get operation > net/txgbe: add register dump support > net/txgbe: support device LED on and off > net/txgbe: add mirror rule operations > net/txgbe: add PTP support > net/txgbe: add DCB info get operation > net/txgbe: add Rx and Tx descriptor status > Hi Jiawen, Before going into more detailed reviews, the patchset conflicts with some recent changes in the main repo [1], can you please rebase on top of the latest head of the repo? Also DPDK syntax/style check scripts are giving errors, can you please fix them too? You should run following to check: ./devtools/checkpatches.sh -n56 ./devtools/check-git-log.sh -n56 (This one needs codespell package to show spelling errors) [1] mainly the list is: 1) PMD close behavior change, - .dev_close changes - RTE_ETH_DEV_CLOSE_REMOVE flag removed 2) Some dev_ops moved to ethdev struct - .rx_queue_count - .rx_descriptor_done - .rx_descriptor_status - .tx_descriptor_status