From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED9F242368; Wed, 11 Oct 2023 19:27:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 906EA400EF; Wed, 11 Oct 2023 19:27:39 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062.outbound.protection.outlook.com [40.107.220.62]) by mails.dpdk.org (Postfix) with ESMTP id E48E0400D7 for ; Wed, 11 Oct 2023 19:27:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R7nuK4mWvcMStE9p5FfSyTD+jvXUZKCzwQKkmiPu2pjHxgV1zxVKA3UHqvEF8sOxIHh+NEgvvGHCautHS0FFzjVhrHo6VhoIwGEvL+rTgkh2pNHDrs4iU65sQAM3L7tedJdNS9Zatlu97Y+eSsdLUmQ4g3bqwFf8JgInPTAKS3GWxONiDDFbTF/S0IJN/hDrKnFFk9Rup1/86wGn2Wd4uw9EW60+HixmmBeHBRqsYxDA5E6L3IH+Ga3Ow6gpxHYo1HDzDoRX7j6Z9JA7HYRjZNvrBmkGhMwML6lhegXhh8wvfYzj+6XFjyIXqxhcBeg/vxG5MzS9EsORqPjVQnjuQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u65vHdOiGrjd06Iz18BDXXIuIda10RGv/Vlru2iM6bA=; b=odh+lfs68JnbqTSLnzw9J/iO70kX5Ln1TVEHLE/3/8s5AT/ohp6wPmjME7W3UMzlxQa7gkoJt6+mOqO8hO8smI+nHd5k0plzSaXwNQH2EmV2uSf0z/nuTYJM6J5WRJ4nPVDLV9M01zVDYxagXBTHoWWRcsljdO3zWQvHIJwJ4RorvPYSsu0/hwFeRbXpb8PFNRX2RoBgUFXuZZZ7vKWVd3Gp53T9vPCPken+36lK5Bd26mhng82m7BFx2kxQ9xj8hk8z6MbVU4ATZmnKqPomTjCjTx8S+iFFuwJRrqkOoVTTeFbF64dt6dPBg2Yj97+GSXUq4dOqIpWiOOg2c8ItBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u65vHdOiGrjd06Iz18BDXXIuIda10RGv/Vlru2iM6bA=; b=FGt+NKGU1hjRdw0BXmNCcPNW4Ri7Sfp0lh9vYgRkm+oOuEpdO5AiJrTYoqYupbcx+WVedCKxrQ/rNILxznJjWIR56eSQBXX8JzXHsB2d1UgkgjUopT1EE97GOgR8xRGCd5QDM5VfhQjh8vgCGNa5dcFMmE40Lpt+e2se6UEnwvU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6640.namprd12.prod.outlook.com (2603:10b6:8:8f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.40; Wed, 11 Oct 2023 17:27:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Wed, 11 Oct 2023 17:27:34 +0000 Message-ID: <911441a4-d94f-434b-8663-bb8e9d574392@amd.com> Date: Wed, 11 Oct 2023 18:27:28 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 13/40] net/ena: check RSS hash algorithms Content-Language: en-US To: Jie Hai , dev@dpdk.org, Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Ron Beider Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-14-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231011092805.693171-14-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P193CA0044.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:51::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6640:EE_ X-MS-Office365-Filtering-Correlation-Id: b1f9e92d-c21d-4001-27a7-08dbca7f5ae0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GdeAQAcFWTj7w/4TjQRQJe0/feAO+qJqNmOTMym+xcfr+7eNOx37QGT187KPX24U7xJbRDOG/hkxyb73ogxXB+3Fgm8LLB4FHffnjtr5JiN8BOHrcrJuQI7eqKwo743ieEezkLQQr4foUIgNd9TzpgrF4ZHgTHABJX0Rf2mtu+orCx4usNwldFUy87k9kdSDR1bAFXQ9px07wY6DtxsOsZKaixgpwYGP1JwMRgfktpkoqgA2RzU8ELBhFM6zkGzUvIKOy+Nxn/2f1UazaqrL9GISOTahlOq7gglG8gh4AMcW7J6lV/a77aqspHXHOE0hc2oYVQGv3zM3Gxr1i04aip+Za/ab6GOZG/6eAUqz/YKbNud3I+Ut6OVjiiS2oFTkQ6E8s66F4GOP3xUIgrNY1kroUlwHDGctKTQTkO/MgxY1kT8P0oZ8dxpzpJ10uW/JRjHpxzqh11E98jEF8KNZBpeJWaqJOvxqNRakpUZC54PwwLXtcCbXjsutI34i/o4tp/W0OZoYrFFhFKSGl7o0foLetF5Sb1nurn5robMSem9Z+8frcnjROFcRtMpQN7lP7ICeYCOF5chb29tJ62IhTmXtbv+w/vbFsPsvleLZkh5ij/WwNdE5xKp1i2tLefDMyIJIlxcOZMb8bpAP97ZMNg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(366004)(376002)(136003)(39860400002)(230922051799003)(1800799009)(451199024)(64100799003)(186009)(110136005)(316002)(66946007)(66556008)(6486002)(5660300002)(41300700001)(44832011)(7416002)(8676002)(8936002)(4326008)(66476007)(31686004)(2906002)(83380400001)(26005)(53546011)(6512007)(31696002)(2616005)(86362001)(38100700002)(6666004)(36756003)(6506007)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlJtMGoxK2M5WmNieWZkbDVtVGltSGY0eTJGQjhRWGVxUkxxUmdGcldOcFY0?= =?utf-8?B?bVduR2EvMXZ6b3ZJMzV2UnZjc1ZNNHpBOUFoeTJPMzFYNXRmOXI5NG9NZEVw?= =?utf-8?B?cWNFM2pjSDYvUG5ucFVtKzhMK3MzNVpubWVnVEZxajBZa2JSN1hJdEhDZlRz?= =?utf-8?B?Q1FzL0pQNXlTc3oyNVRwRmd1enhhcnNPT3RjQk43ZlJHcnZ3SEdkcTMrY2hI?= =?utf-8?B?VUFWQmVmaHI1Nm9pdVRYbXFVWmk2RHR3NlduSC93TU5ZQ1lUVS84RW5OSlN4?= =?utf-8?B?a21VK1hKZDVaUmlkbkxFL3dHSER3U29HNWcybkd6bEt3eUQzLzlpc29pTHVT?= =?utf-8?B?czQ4VG1EdXNDZjFhcDVkN3NLK00xK1dqOFpFNklaVmNjYUlQNU5uR21ITG9h?= =?utf-8?B?blpzVVl1YTA1VDdYK3lDZmV2NTE1cE9XZHd5NEdoeXdhY1U4QkMyVUlRZVZV?= =?utf-8?B?MnErVlIvcUhFaXpzam9ma1B3OWdwYWs4YnpXWmtUdlcyVFU2QjlDeEE4M055?= =?utf-8?B?SUpwcWc1WmJqNVZhOVVWMnJYRDlKRFZseW5wQUNDZmdNM1M2TERybmtyZTha?= =?utf-8?B?V1BEUG9KOStNNm5yS1BWNGgzZ0p5T2hwenM4RmMxS3V2TUdxcGN2Uyt2amtW?= =?utf-8?B?TG9jVU95eFJhVzBmS2RHU2JPM3dsb3FLQi93dFRLM3RTYXZnS0M1STlRRjFj?= =?utf-8?B?d3BkUzJQR3dqd0E3TEd0a05HLy9GOFc3d3dUOTJKNVh6LzFHMmptOFZ0L2N0?= =?utf-8?B?T0E3aGM3TC9EU01aVDg1d0djcmUxV1BqSVQvRWhkSnd3WXRyWTNBMW82TVdP?= =?utf-8?B?K2NzbWlWcnpZS21GOHVKUGlTYm5ZVC9IZ2VGc1lwZGNZdzNPK3RrY2d5MnJD?= =?utf-8?B?dHZjOHJqeWxGMWR4YkQ4OGh1SmJlOW4xU2xZQUkrMlgzcGNlemNkNHVMbG83?= =?utf-8?B?aVFTNThseVFkMDZHeE54OTVyMDd3SlE2VWVlQ0ZuOVhLVXJFcnZoY2g3enRK?= =?utf-8?B?RU1qaWJXOVN1UUs2YzFJamc1b2Q3RWV3dXlZTFFmOXFHSjBGYW40aGttaXNX?= =?utf-8?B?NW1vSUhjZ01ya0Q4aUE0QWtSb0ZTM0FHc3M1Zkd3eEUraUZZSkNMV2VUcG9J?= =?utf-8?B?eTUxSXZOVHhybWxrRXpjejdFWExqMG9yUWlnbjVVQk8rYnA3a25ScldPZWYw?= =?utf-8?B?SU9FTGR0U0RFeUh0MElEcGd4TURGVVN2OFByY2hnRDduMVhZVWU0OFY4ampP?= =?utf-8?B?RGZnMmcvdlJiK0VqN3NWUlExbG5sTWRHb1ZoVXBPKzNKOG0wU1R5UlFuYkVO?= =?utf-8?B?NFhJRXBCdFpidEk3TUZMekpJU1RYcTNCL0NxaU83dmVnMk1jb0dnYnJHdlQ3?= =?utf-8?B?Wlc1WGprNy9TWHpNM0ppMTlhU3JFRnhiSjhlQlZGQ1JXUkVCTG45eVBQbHdQ?= =?utf-8?B?a1JPaFpjM2JDOGlkSkQ0Q050M2l4MXBoRDJpRFhYMUhKQnp0WHA4REFyWFpx?= =?utf-8?B?b1R1SjI0Zis0QmRQYnY0Slcya1ZoYUxvQmQvUDBjWXNXVXE5Qmo3aEYwYkty?= =?utf-8?B?ZVFTcEtOVFllYTFmQ25PcDZtc0tFUGsvR0UrdVlvMlVHMlpYS0ZqVEhGOWYx?= =?utf-8?B?SHRvYVE2TUMrYWhITERqd2ZQbGwzZmlzcDk4VzVWSVEwblArb3lOdVlkYTVE?= =?utf-8?B?U1VjUEJPb2hXMDIxbmNwSGhGLzFxajR6d3MweUZSNWd5N0Vpc0IxNWVpSXFN?= =?utf-8?B?ZS9MUWU5dSt3UnlYczV4bTQ3eExXSWdIUFJXTXV1SHlldkdmVlE1dG54dDZH?= =?utf-8?B?dFZiL21LeDJRc3RDMFl5d0RTS2RxbVh4MlBGTTlVS1IrWU9YNndEVklyL0Jr?= =?utf-8?B?QThOZDlRM3Z4NktHYXZhMk1yMUVYTEdZNXlBcGNjUjNuWHYwZEVzNkpuQ2FY?= =?utf-8?B?NC9mUXI5b0lVenF4YkorWEE0K1NJTzhnQ1U1UHU2YTVjbDVld0hTdlZlaTlq?= =?utf-8?B?d2t3VWZyeHdxL2FLcSsxdjZlZCswb3BTSDk2SlJHS0RJNjlnM1NVajEwZVd3?= =?utf-8?B?NkVrRVZyK2RWZnVqMEdzNkFQb05VWkpLN3FKMUVQZGJ1L2RMNWc3akhkYnVX?= =?utf-8?Q?ywFkjJR5lre6Ojl3lCEUZHsGB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1f9e92d-c21d-4001-27a7-08dbca7f5ae0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 17:27:34.3822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nyqCdovH3Tm0+8zZAE/C4M4rI4996P376fFR8Z4QHsQYXnwcMLo0a14HpDYiOtfb X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6640 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/ena/ena_rss.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c > index d0ba9d5c0a14..06aff9f3bd49 100644 > --- a/drivers/net/ena/ena_rss.c > +++ b/drivers/net/ena/ena_rss.c > @@ -398,6 +398,9 @@ static int ena_rss_hash_set(struct ena_com_dev *ena_dev, > uint8_t *rss_key; > int rc; > > + if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT) > + return -EINVAL; > + > if (rss_conf->rss_key != NULL) { > /* Reorder the RSS key bytes for the hardware requirements. */ > ena_reorder_rss_hash_key(hw_rss_key, rss_conf->rss_key, I can see in some drivers configure() ops is not updated, I assume these are the ones don't have any RSS related config in it, it is not clear still to add check, but I guess what you are doing is reasonable, I am OK with this approach.