From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matan Azrad <matan@mellanox.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] ethdev: silence error message on rte_eth_dev_owner_unset
Date: Mon, 27 Aug 2018 14:01:12 +0100 [thread overview]
Message-ID: <9116ac40-5d84-5962-7432-a09cc66a947c@intel.com> (raw)
In-Reply-To: <AM0PR0502MB4019CA920C027AF3EFC2D2E5D2310@AM0PR0502MB4019.eurprd05.prod.outlook.com>
On 8/21/2018 4:53 PM, Matan Azrad wrote:
> Hi
>
> From: Stephen Hemminger
>> From 74ad4c60262b1451a5a2fabf79a2df89c6c5373d Mon Sep 17 00:00:00 2001
>> From: Stephen Hemminger <stephen@networkplumber.org>
>> Date: Thu, 16 Aug 2018 15:37:14 -0700
>> Subject: [PATCH 1/5] ethdev: silence error message on
>> rte_eth_dev_owner_unset
>>
>> The rte_eth_dev_owner_unset function always generates a log message
>> because the unset value for owner id is 0.
>>
>> Also, when rte_eth_dev_owner_delete is called with a valid owner id, the
>> log message should be at NOTICE not ERROR severity.
>>
>> Fixes: 5b7ba31148a8 ("ethdev: add port ownership")
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
<...>
> I think the title should be:
> ethdev: fix port ownership logs
>
> while adding the fixes commits (at list 2 because of the NOTICE change)
> and updating stable.
>
> Besides that,
> Acked-by: Matan Azrad <matan@mellanox.com>
Applied to dpdk-next-net/master, thanks.
(Used suggested title.)
next prev parent reply other threads:[~2018-08-27 13:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 0:19 [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset Stephen Hemminger
2018-08-14 5:52 ` Matan Azrad
2018-08-14 16:55 ` Stephen Hemminger
2018-08-14 19:46 ` Matan Azrad
2018-08-24 13:55 ` Ferruh Yigit
2018-08-24 14:42 ` Stephen Hemminger
2018-08-16 22:44 ` [dpdk-dev] [PATCH 0/2] ethdev: minor ownership changes Stephen Hemminger
2018-08-16 22:44 ` [dpdk-dev] [PATCH 1/2] ethdev: silence error message on rte_eth_dev_owner_unset Stephen Hemminger
2018-08-21 10:04 ` Matan Azrad
2018-08-21 15:45 ` [dpdk-dev] [PATCH v3] " Stephen Hemminger
2018-08-21 15:53 ` Matan Azrad
2018-08-27 13:01 ` Ferruh Yigit [this message]
2018-08-16 22:44 ` [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool Stephen Hemminger
2018-08-21 10:20 ` Matan Azrad
2018-08-21 15:06 ` Stephen Hemminger
2018-08-21 15:48 ` Matan Azrad
2018-08-21 18:31 ` Stephen Hemminger
2018-08-26 7:49 ` Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9116ac40-5d84-5962-7432-a09cc66a947c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).