From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B11BA32A3 for ; Fri, 25 Oct 2019 14:23:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C10C1C12C; Fri, 25 Oct 2019 14:23:48 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 8A65C1C0DD for ; Fri, 25 Oct 2019 14:23:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2019 05:23:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,228,1569308400"; d="scan'208";a="210707710" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.104]) ([10.237.220.104]) by orsmga002.jf.intel.com with ESMTP; 25 Oct 2019 05:23:43 -0700 To: "Damjan Marion (damarion)" , Thomas Monjalon Cc: David Marchand , Shahaf Shuler , Ray Kinsella , dev , Neil Horman , John McNamara , Marko Kovacevic , Bruce Richardson References: <2302363.xZHtmyloc2@xps> <5980E9BB-2D78-43C5-890A-05B6BAC30071@cisco.com> From: "Burakov, Anatoly" Message-ID: <911c9f45-ef00-0a9c-1e03-473ccbc89b9c@intel.com> Date: Fri, 25 Oct 2019 13:23:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <5980E9BB-2D78-43C5-890A-05B6BAC30071@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 25-Oct-19 12:13 PM, Damjan Marion (damarion) wrote: > > >> On 25 Oct 2019, at 00:32, Thomas Monjalon wrote: >> >> 24/10/2019 21:09, David Marchand: >>> On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov >>> wrote: >>>> >>>> The rte_vfio_dma_map/unmap API's have been marked as deprecated in >>>> release 19.05. Remove them. >>>> >>>> Signed-off-by: Anatoly Burakov >>>> --- >>>> >>>> Notes: >>>> Although `rte_vfio_dma_map` et al. was marked as deprecated in our documentation, >>>> it wasn't marked as __rte_deprecated in code. Should we still remove it? >>> >>> I can see that vpp is still using this api. >>> I would prefer we get some ack from their side. >>> >>> Shahaf? >>> Ray? >>> >>> Do you guys have contact with VPP devs? >> >> +Cc Damjan > > Thanks for looping me in. If I remember correctly that was used only to get mlx PMDs working. > We can remove that calls but then mlx PMDs will stop working unless there is alternative solution. > > From my perspective it is not big issue as we already have native rdma based mlx support, but i would expect that other people will complain. > > Is there alternative way to tell DPDK about DMA mapping? The rte_vfio_container_dma_map(VFIO_DEFAULT_CONTAINER, ...) is the exact equivalent of the functions being removed. Also, rte_dev_dma_map() is supposed to be the more general DMA mapping API that works with VFIO and with any other bus/device-specific DMA mapping. So yes, a simple search and replace for "rte_vfio_dma_(un)?map(" to "rte_vfio_container_dma_(un)?map(VFIO_DEFAULT_CONTAINER, " should trigger exactly the same behavior. > > Thanks, > > — > Damjan > -- Thanks, Anatoly