From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23CCC433EB; Tue, 28 Nov 2023 03:09:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01800402BF; Tue, 28 Nov 2023 03:09:21 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 6D27D4029E for ; Tue, 28 Nov 2023 03:09:19 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SfQlm0z08z1P8sL; Tue, 28 Nov 2023 10:05:40 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 28 Nov 2023 10:09:15 +0800 Message-ID: <912c84da-d869-b130-3eb6-b55ad2d73f75@huawei.com> Date: Tue, 28 Nov 2023 10:09:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v4 0/5] doc/features: fix some features and add new features To: Ferruh Yigit , , CC: References: <20231123135916.33315-1-lihuisong@huawei.com> <20231127141659.46600-1-lihuisong@huawei.com> <5a7ee575-2bd7-48e6-8179-ad513da58e03@amd.com> From: "lihuisong (C)" In-Reply-To: <5a7ee575-2bd7-48e6-8179-ad513da58e03@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/11/28 0:44, Ferruh Yigit 写道: > On 11/27/2023 2:16 PM, Huisong Li wrote: >> The support for setting RSS hash algorithm has been introduced to 23.11, >> but doesn't add feature for it. So this series add this feature to RSS hash >> and perfect RSS other features by the way. >> >> In addition, serval features or interface, like "set link up/down", "TM", >> "link speeds" and "dump device private information" had beed supported, >> but they are absent from the freatures list. >> >> --- >> -v4: >> - fix RSS releated feaures description based on Ferruh >> - add new features to default.ini >> - remove loopback patch. >> - move "dump device private information" to "dev ops" block. >> >> -v3: >> - fix description of the patchset cover >> - remove '/features' in 'doc/features' tag for every patch. >> - add Acked-by: Chengwen Feng >> - retrigger CI build because of wrong CI warning >> >> -v2: >> - add loopback mode feature. >> >> Huisong Li (5): >> doc: fix the description of RSS related feature >> doc: add link up/down feature >> doc: add features for link speeds >> doc: add Traffic Manager feature >> doc: add dump device private information ops >> > As mentioned before I don't know about adding link speed feature or not, > would like to get more comment. ok, let us to get more comment. it is better that we send a separated patch about link speed feature to discuss and get more comment. In this way, other patch in this series also go ahead to upload. what do you think? > > But for the new features added, driver .ini files also needs to be > updated for that new feature, and drivers support it should mark the > support. agree. I will add "Traffic Manager" feature to driver.ini for the supported TM driver. But I'm not sure if I am supposed to do this in patch 4/5 or send independent patch for every supported driver. what do you think of that? > That is why it is best to start documenting a feature when it is first > introduced, otherwise it is more work to update it later. agree with you. we should remind someone to add it to this feature doc when a new feature is introduced. > > .