From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0077A0524; Sat, 9 Jan 2021 03:15:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AFE2140EB3; Sat, 9 Jan 2021 03:15:46 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 8A4E8140E8B; Sat, 9 Jan 2021 03:15:45 +0100 (CET) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DCNpF64M5z15p7Z; Sat, 9 Jan 2021 10:14:45 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Sat, 9 Jan 2021 10:15:32 +0800 To: Ruifeng Wang , "Wei Hu (Xavier)" , "Min Hu (Connor)" , "Yisen Zhuang" , Huisong Li , Chengchang Tang , Chengwen Feng CC: , , , , , , References: <20201218101210.356836-1-ruifeng.wang@arm.com> <20210108082523.1062058-1-ruifeng.wang@arm.com> <20210108082523.1062058-3-ruifeng.wang@arm.com> From: oulijun Message-ID: <912e60d0-fcd3-c7d8-7591-b8a0be78138e@huawei.com> Date: Sat, 9 Jan 2021 10:15:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20210108082523.1062058-3-ruifeng.wang@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: fix build with sve enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/1/8 16:25, Ruifeng Wang 写道: > Building with SVE extension enabled stopped with error: > > error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’ > 18 | #define PG64_256BIT svwhilelt_b64(0, 4) > > This is caused by unintentional cflags reset. > Fixed the issue by appending required flag to cflags instead of > overriding it. > > Fixes: 952ebacce4f2 ("net/hns3: support SVE Rx") > Cc: xavier.huwei@huawei.com > Cc: stable@dpdk.org > > Signed-off-by: Ruifeng Wang > --- > drivers/net/hns3/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build > index 45cee34d9..798086357 100644 > --- a/drivers/net/hns3/meson.build > +++ b/drivers/net/hns3/meson.build > @@ -32,7 +32,7 @@ deps += ['hash'] > if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') > sources += files('hns3_rxtx_vec.c') > if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' > - cflags = ['-DCC_SVE_SUPPORT'] > + cflags += ['-DCC_SVE_SUPPORT'] Hi I noticed this patch, but I checked that the hns3 driver did not use this function.How did you compile it? Thanks Lijun Ou > sources += files('hns3_rxtx_vec_sve.c') > endif > endif >