From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id BE5377F40
 for <dev@dpdk.org>; Thu, 20 Nov 2014 17:31:55 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga102.jf.intel.com with ESMTP; 20 Nov 2014 08:40:12 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,425,1413270000"; d="scan'208";a="640523617"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by orsmga002.jf.intel.com with ESMTP; 20 Nov 2014 08:42:24 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.128]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.244]) with mapi id 14.03.0195.001;
 Thu, 20 Nov 2014 16:42:23 +0000
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
Thread-Topic: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
Thread-Index: AQHQBMziygfWbk3DdkOPf0+Tw/LTYZxpkLgAgAAffaA=
Date: Thu, 20 Nov 2014 16:42:23 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004EC5751@IRSMSX108.ger.corp.intel.com>
References: <1416493033-13450-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <20141120142040.GE2609@hmsreliant.think-freely.org>
In-Reply-To: <20141120142040.GE2609@hmsreliant.think-freely.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.237.220.43]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2014 16:31:56 -0000

> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Thursday, November 20, 2014 2:21 PM
> On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote:
> > Some features of the cmdline were broken in FreeBSD as a result of
> > termios not being compiled.
> >
> > Signed-off-by: Sergio Gonzalez Monroy
> > <sergio.gonzalez.monroy@intel.com>
>=20
> Not sure I understand the changelog above.  You're removing ifdefs below
> which makes sense, but are you now assuming that BSD will be built with
> termios support, or do you need to add some alternate dependency check
> during the configuration of DPDK?
> Neil
>=20
Yes, I was assuming that BSD has termios support.
Is it not a fair assumption?

Sergio