From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id DB5959600
 for <dev@dpdk.org>; Mon, 22 Dec 2014 15:01:20 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 22 Dec 2014 06:01:12 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="432143818"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by FMSMGA003.fm.intel.com with ESMTP; 22 Dec 2014 05:49:44 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.71]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.113]) with mapi id 14.03.0195.001;
 Mon, 22 Dec 2014 14:01:09 +0000
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH 1/4] compat: Add infrastructure to support symbol
 versioning
Thread-Index: AQHQHJg12rLEWN4aDkWgeBalVz1on5ybodog
Date: Mon, 22 Dec 2014 14:01:10 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004F20D71@IRSMSX108.ger.corp.intel.com>
References: <1419109299-9603-1-git-send-email-nhorman@tuxdriver.com>
 <1419109299-9603-2-git-send-email-nhorman@tuxdriver.com>
In-Reply-To: <1419109299-9603-2-git-send-email-nhorman@tuxdriver.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support
 symbol versioning
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Dec 2014 14:01:21 -0000

Hi Neil,

Just a couple of minor comments.

> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Saturday, December 20, 2014 9:02 PM
> Subject: [PATCH 1/4] compat: Add infrastructure to support symbol
> versioning
>=20
> Add initial pass header files to support symbol versioning.
>=20
 [...]
>
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 81bf8e1..2299cbe 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -40,8 +40,12 @@ VPATH +=3D $(SRCDIR)
>=20
>  ifeq ($(RTE_BUILD_SHARED_LIB),y)
>  LIB :=3D $(patsubst %.a,%.so,$(LIB))
> +
> +CPU_LDFLAGS +=3D --version-script=3D$(EXPORT_MAP)

What about setting --version-script=3D$(SRCDIR)/$(EXPORT_MAP) so we can do:
Ie. 'EXPORT_MAP =3D rte_eal_version.map' instead of 'EXPORT_MAP =3D $(RTE_S=
DK)/lib/librte_eal/linuxapp/eal/rte_eal_version.map'=20

> +
>  endif
>=20
> +
>  _BUILD =3D $(LIB)
>  _INSTALL =3D $(INSTALL-FILES-y) $(SYMLINK-FILES-y)
> $(RTE_OUTPUT)/lib/$(LIB)  _CLEAN =3D doclean @@ -161,7 +165,9 @@ endif
>  $(RTE_OUTPUT)/lib/$(LIB): $(LIB)
>  	@echo "  INSTALL-LIB $(LIB)"
>  	@[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib
> +ifneq ($(LIB),)
>  	$(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib
> +endif
>=20
We could move the ifneq($(LIB),) to the _INSTALL variable (top of the same =
file).
Something like this:

-_INSTALL =3D $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/lib/$(LIB=
)
+_INSTALL =3D $(INSTALL-FILES-y) $(SYMLINK-FILES-y)
+ifneq ($(LIB),)
+_INSTALL +=3D $(RTE_OUTPUT)/lib/$(LIB)
+endif

Thanks,
Sergio

>  #
>  # Clean all generated files
> --
> 1.9.3