From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 86F8E9627
 for <dev@dpdk.org>; Mon, 22 Dec 2014 18:10:22 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 22 Dec 2014 09:09:58 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="502713867"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by orsmga003.jf.intel.com with ESMTP; 22 Dec 2014 09:05:20 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.71]) by
 IRSMSX151.ger.corp.intel.com ([163.33.192.59]) with mapi id 14.03.0195.001;
 Mon, 22 Dec 2014 17:09:56 +0000
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
Thread-Topic: [PATCH 1/4] compat: Add infrastructure to support symbol
 versioning
Thread-Index: AQHQHJg12rLEWN4aDkWgeBalVz1on5ybodoggAAvYoCAAAWiYA==
Date: Mon, 22 Dec 2014 17:09:55 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004F20DD4@IRSMSX108.ger.corp.intel.com>
References: <1419109299-9603-1-git-send-email-nhorman@tuxdriver.com>
 <1419109299-9603-2-git-send-email-nhorman@tuxdriver.com>
 <91383E96CE459D47BCE92EFBF5CE73B004F20D71@IRSMSX108.ger.corp.intel.com>
 <20141222163453.GD26669@hmsreliant.think-freely.org>
In-Reply-To: <20141222163453.GD26669@hmsreliant.think-freely.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support
 symbol versioning
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Dec 2014 17:10:22 -0000

> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Monday, December 22, 2014 4:35 PM
>=20
> On Mon, Dec 22, 2014 at 02:01:10PM +0000, Gonzalez Monroy, Sergio wrote:
> >
> > > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > > Sent: Saturday, December 20, 2014 9:02 PM
> > We could move the ifneq($(LIB),) to the _INSTALL variable (top of the s=
ame
> file).
> > Something like this:
> >
> > -_INSTALL =3D $(INSTALL-FILES-y) $(SYMLINK-FILES-y)
> > $(RTE_OUTPUT)/lib/$(LIB)
> > +_INSTALL =3D $(INSTALL-FILES-y) $(SYMLINK-FILES-y) ifneq ($(LIB),)
> > +_INSTALL +=3D $(RTE_OUTPUT)/lib/$(LIB) endif
> >
> Actually, as I look at it, this second one doesn't seem to make any sense=
 to
> me.
> _INSTALL as a variable doesn't seem to get used anywhere that I can see,
> certainly not in the capacity of copying shared libraries into the build/=
lib area
> so that the example apps can get linked with them.  So I'm not sure this
> makes sense.
>=20
The _INSTALL var gets expanded for the rule '_install' in mk/internal/rte.i=
nstall-post.mk if I am not mistaken.
That would trigger the rule $(RTE_OUTPUT)/lib/$(LIB) which in turn builds a=
nd copy the shared/static library to build/lib.

If we do not add $(RTE_OUTPUT)/lib/$(LIB) to _INSTALL, then the rule will n=
ot trigger.

Regards,
Sergio

> Neil
>=20