From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 9EA4A6886
 for <dev@dpdk.org>; Tue, 23 Dec 2014 14:27:37 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 23 Dec 2014 05:27:35 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="432576711"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by FMSMGA003.fm.intel.com with ESMTP; 23 Dec 2014 05:16:02 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.71]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.244]) with mapi id 14.03.0195.001;
 Tue, 23 Dec 2014 13:27:32 +0000
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2 1/4] compat: Add infrastructure to support symbol
 versioning
Thread-Index: AQHQHiVSPXiG8QGsdUiv1b2H5vJX+5ydKe2Q
Date: Tue, 23 Dec 2014 13:27:32 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004F210D1@IRSMSX108.ger.corp.intel.com>
References: <1419109299-9603-1-git-send-email-nhorman@tuxdriver.com>
 <1419279860-16985-1-git-send-email-nhorman@tuxdriver.com>
In-Reply-To: <1419279860-16985-1-git-send-email-nhorman@tuxdriver.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 1/4] compat: Add infrastructure to support
 symbol versioning
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Dec 2014 13:27:38 -0000

> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Monday, December 22, 2014 8:24 PM
> +++ b/lib/librte_compat/Makefile
>[...]
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +
> +# install includes
> +SYMLINK-y-include :=3D rte_compat.h
> +
> +include $(RTE_SDK)/mk/rte.lib.mk
>
I just realized that we can avoid doing the _INSTALL change below if we inc=
lude
mk/rte_install.mk instead of mk/rte_lib.mk, as it is done in librte_net.

Regards,
Sergio

> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 81bf8e1..cbd439b 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -40,10 +40,17 @@ VPATH +=3D $(SRCDIR)
> [...]
> +
>  _BUILD =3D $(LIB)
> -_INSTALL =3D $(INSTALL-FILES-y) $(SYMLINK-FILES-y)
> $(RTE_OUTPUT)/lib/$(LIB)
> +_INSTALL =3D $(INSTALL-FILES-y) $(SYMLINK-FILES-y) ifneq ($(LIB),)
> +_INSTALL +=3D $(RTE_OUTPUT)/lib/$(LIB) endif
>  _CLEAN =3D doclean
>=20
>  .PHONY: all
> --
> 1.9.3