From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5F06F255 for ; Thu, 29 Jan 2015 18:36:55 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 29 Jan 2015 09:36:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,487,1418112000"; d="scan'208";a="519747715" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 29 Jan 2015 09:29:38 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.64]) by IRSMSX104.ger.corp.intel.com ([169.254.5.229]) with mapi id 14.03.0195.001; Thu, 29 Jan 2015 17:35:10 +0000 From: "Gonzalez Monroy, Sergio" To: Thomas Monjalon , "Pattan, Reshma" Thread-Topic: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library Thread-Index: AQHQKpiSJ99grof1Y0S/MrS0cK39D5zIuSkAgA6/J+A= Date: Thu, 29 Jan 2015 17:35:09 +0000 Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004F43DE1@IRSMSX108.ger.corp.intel.com> References: <1420648753-17136-1-git-send-email-reshma.pattan@intel.com> <9416100.1lhCgRCuAQ@xps13> In-Reply-To: <9416100.1lhCgRCuAQ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 17:36:55 -0000 Hi Thomas, > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, January 20, 2015 8:01 AM > To: Pattan, Reshma > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library >=20 > Hi, >=20 > 2015-01-07 16:39, Reshma Pattan: > > 1)New library to provide reordering of out of ordered > > mbufs based on sequence number of mbuf. Library uses reorde= r > buffer structure > > which in tern uses two circular buffers called ready and or= der buffers. > > *rte_reorder_create API creates instance of reorder buffer. > > *rte_reorder_init API initializes given reorder buffer inst= ance. > > *rte_reorder_reset API resets given reorder buffer instance= . > > *rte_reorder_insert API inserts the mbuf into order circula= r buffer. > > *rte_reorder_fill_overflow moves mbufs from order buffer to= ready > buffer > > to accomodate early packets in order buffer. > > *rte_reorder_drain API provides draining facility to fetch = out > > reordered mbufs from order and ready buffers. > > > > Signed-off-by: Reshma Pattan > > Signed-off-by: Richardson Bruce >=20 > I think 2 things are missing in this patchset: >=20 > 1) Could you show some performance numbers to compare a simple > forwarding with and without this library, in the commit log? >=20 I'm not allowed to provide specific performance numbers. I could try to give some kind of relative performance estimate (%), but any= one else is free to provide those numbers. > 2) Could you add some documentation in doc/ directory for programmer's > guide? >=20 I'll be sending a v2 shortly with a new entry for the programmers guide. Thank you, Sergio > Thank you > -- > Thomas