From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 342BA2E81 for ; Fri, 30 Jan 2015 10:35:11 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 30 Jan 2015 01:35:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,491,1418112000"; d="scan'208";a="644988678" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga001.jf.intel.com with ESMTP; 30 Jan 2015 01:35:08 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.64]) by IRSMSX153.ger.corp.intel.com ([169.254.9.2]) with mapi id 14.03.0195.001; Fri, 30 Jan 2015 09:35:06 +0000 From: "Gonzalez Monroy, Sergio" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library Thread-Index: AQHQKpiSJ99grof1Y0S/MrS0cK39D5zIuSkAgA6/J+CAADniAIAA0sxQ Date: Fri, 30 Jan 2015 09:35:06 +0000 Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004F45138@IRSMSX108.ger.corp.intel.com> References: <1420648753-17136-1-git-send-email-reshma.pattan@intel.com> <9416100.1lhCgRCuAQ@xps13> <91383E96CE459D47BCE92EFBF5CE73B004F43DE1@IRSMSX108.ger.corp.intel.com> <20150129203936.GH1999@hmsreliant.think-freely.org> In-Reply-To: <20150129203936.GH1999@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 09:35:12 -0000 > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Thursday, January 29, 2015 8:40 PM > To: Gonzalez Monroy, Sergio > Cc: Thomas Monjalon; Pattan, Reshma; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library >=20 > On Thu, Jan 29, 2015 at 05:35:09PM +0000, Gonzalez Monroy, Sergio wrote: > > Hi Thomas, > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas > Monjalon > > > Sent: Tuesday, January 20, 2015 8:01 AM > > > To: Pattan, Reshma > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder > > > library > > > > > > Hi, > > > > > > 2015-01-07 16:39, Reshma Pattan: > > > > 1)New library to provide reordering of out of ordered > > > > mbufs based on sequence number of mbuf. Library uses > > > > reorder > > > buffer structure > > > > which in tern uses two circular buffers called ready an= d order > buffers. > > > > *rte_reorder_create API creates instance of reorder buf= fer. > > > > *rte_reorder_init API initializes given reorder buffer = instance. > > > > *rte_reorder_reset API resets given reorder buffer inst= ance. > > > > *rte_reorder_insert API inserts the mbuf into order cir= cular > buffer. > > > > *rte_reorder_fill_overflow moves mbufs from order > > > > buffer to ready > > > buffer > > > > to accomodate early packets in order buffer. > > > > *rte_reorder_drain API provides draining facility to fe= tch out > > > > reordered mbufs from order and ready buffers. > > > > > > > > Signed-off-by: Reshma Pattan > > > > Signed-off-by: Richardson Bruce > > > > > > > > > > I think 2 things are missing in this patchset: > > > > > > 1) Could you show some performance numbers to compare a simple > > > forwarding with and without this library, in the commit log? > > > > > I'm not allowed to provide specific performance numbers. > Can you elaborate on this? Why can you not provide specific performance > numbers from your testing? Is there some concern over the validity of th= e > measurements? Hi Neil, As far as I know, that is exactly the reason. Any Intel specific performance data goes through a performance validation t= eam before being released. Thanks, Sergio